Fixed Issues with stunned characters dialog

[DeathDaisy]

The new version of the update archive is now in place:
http://piratesahoy.bowengames.com/potc/Grey Roger/post_August31_fixes.zip

Several changes this month, including the above-mentioned new ships, dialogs and character. Also, in FreePlay, several wars throughout history are depicted by changes in international relations programmed into "StartStoryline.c". The War of the League of Augsburg was already there; now the Franco-Dutch War, the War of Spanish Succession and the Thirty Years War, among several others, are included.

A toggle in "InternalSettings.h" can be set to allow Sweden to enter the Caribbean. You can play as a Swedish character and you may meet Swedish ships.

Nice work! thanks for putting in the time!

I looked through it with WinMerge to merge with some of my personal changes and because I was curious, and I found a thing in stunned_dialog that gets weird. " This #sson# of a whore didn't seem a strong #sgender#..." was in my file
" This #sson#whore didn't seem a strong #sgender#...".

#sson# in the .c file is

                   string Whore;
                   if(PChar.sex == "woman")
                       Whore = "";
                   else
                       Whore = "son of ";
                   string addString = DLG_TEXT[14];
                   Preprocessor_Add("son", Whore);

(I even spelled "son of " wrong, shouldve been "son of a " ) which means it becomes "This of a whore" or "This son of of a whore". "daughter of a whore", while maybe a more unusual thing to say, is actually a less offensive alternative than what I was going for and easier to translate than the hardcoded english, so it's not a bad change. I'll upload a version with Preprocessor_Add("son", GetCharacterAddressForm(PChar, ADDR_CHILD, false, false)); instead if you wanna use that

And in diego cordoba_dialog there's a thing that's less of an issue and might be a file I changed and forgot to update or if it's a post-Daisy change, but

"I understand, alright. You are both a pirate AND a stupid #sgender#. Did you really think I would come here on my own? Guards! Kill this #sgender#!",

is in my file

"I understand, alright. You are both a pirate AND a stupid #sinsult#. Did you really think I would come here on my own? Guards! Kill this #sgender#!",

where #sinsult# is either bastard or trollop depending on gender, which gives the dialog a bit more color in my mind not a big deal, but uploading those anyway just in case

But anyway, nice and meaty update

 

[Grey Roger]

I looked through it with WinMerge to merge with some of my personal changes and because I was curious, and I found a thing in stunned_dialog that gets weird. " This #sson# of a whore didn't seem a strong #sgender#..." was in my file
" This #sson#whore didn't seem a strong #sgender#...".

Yes, I originally used WinMerge to scan all the "dialog.h" files to see what had changed, but initially assumed that you'd written the corresponding "dialog.c" files to correctly fill in the preprocessed variables. #sson# looked as though it should be "son" or "daughter", in which case "This son/daughter whore..." made no sense, whereas "This son/daughter of a whore..." did.

I'll upload a version with Preprocessor_Add("son", GetCharacterAddressForm(PChar, ADDR_CHILD, false, false)); instead if you wanna use that

Beaten you to it. See attached.

And in diego cordoba_dialog there's a thing that's less of an issue and might be a file I changed and forgot to update or if it's a post-Daisy change, but

"I understand, alright. You are both a pirate AND a stupid #sgender#. Did you really think I would come here on my own? Guards! Kill this #sgender#!",

is in my file

"I understand, alright. You are both a pirate AND a stupid #sinsult#. Did you really think I would come here on my own? Guards! Kill this #sgender#!",

where #sinsult# is either bastard or trollop depending on gender, which gives the dialog a bit more color in my mind not a big deal, but uploading those anyway just in case

The original version calls you "a stupid man". I felt it better to keep as close as possible to the original but replace "man" with "woman" if necessary.

 

[DeathDaisy]

Yes, I originally used WinMerge to scan all the "dialog.h" files to see what had changed, but initially assumed that you'd written the corresponding "dialog.c" files to correctly fill in the preprocessed variables. #sson# looked as though it should be "son" or "daughter", in which case "This son/daughter whore..." made no sense, whereas "This son/daughter of a whore..." did.

yeah, I realize I chose a very unfortunate name for that. I have terrible organizing habits. half of my potc texture projects are in my Sims 3 project folder

The original version calls you "a stupid man". I felt it better to keep as close as possible to the original but replace "man" with "woman" if necessary.

That's fair

 

[Grey Roger]

Corrected version of the update now uploaded with "stunned_dialog.c" modified. As a bonus, the War of 1812 is now included in the FreePlay setup.

 

[salonikasurf]

Yes, I originally used WinMerge to scan all the "dialog.h" files to see what had changed, but initially assumed that you'd written the corresponding "dialog.c" files to correctly fill in the preprocessed variables. #sson# looked as though it should be "son" or "daughter", in which case "This son/daughter whore..." made no sense, whereas "This son/daughter of a whore..." did.
Beaten you to it. See attached.


The original version calls you "a stupid man". I felt it better to keep as close as possible to the original but replace "man" with "woman" if necessary.

@Grey Roger, In the latest update 6 Oct - the stunned dialogue does not work now.
Error - file: dialogs\stunned_dialog.c; line: 131
Undeclared identifier: addString

 

[Grey Roger]

Try this version. Put it into "PROGRAM\DIALOGS".

 

[salonikasurf]

Try this version. Put it into "PROGRAM\DIALOGS".

@Grey Roger Worked like a charm. Thanks for your quick response.