1. Dismiss Notice
  2. GOG.com logo

    Thanks to YOUR votes, GOG.com now sells:
    - Sea Dogs - Sea Dogs: Caribbean Tales
    - Sea Dogs: City of Abandoned Ships

    Vote now to add Pirates of the Caribbean to the list!

    Dismiss Notice
  3. Under the Crossbones Podcast

    A Pirate Podcast with Interviews
    Music, Comedy and all things Pirate!

    - Episode Guide - About - Subscribe -
    - Twitter - Facebook - iTunes - Android -
    - Youtube - Fill the Coffers -

    Dismiss Notice
  4. New Horizons logo

    Quick links for PotC: New Horizons
    - Download latest version
    - Wiki - FAQ - Report bugs here
    - ModDB profile

  5. GOF logo

    Quick links for AoP2: Gentlemen of Fortune 2
    - Downloads and info
    - Historical Immersion Supermod
    - ModDB Profile

Dismiss Notice
New to the forum?
Please take a moment to read our Welcome Message and Forum Rules.

Fixed Blocking worst weapons from everyone

Discussion in 'Bug Archive' started by Tingyun, Sep 29, 2016.

  1. Tingyun

    Tingyun Corsair Storm Modder

    Joined:
    Aug 8, 2016
    Messages:
    1,445
    Gender:
    Male
    Felt bad leaving this to someone else. File attached.

    Will submit to new content (so it doesn't fall through the cracks while I am gone). I think further work in implementing some additional uses for the knives in barfights might make sense later.

    This is the moderate version--hatchets and daggers still available, I wrote the stuff to exclude them but commented it out for now.

    Seems to work and be correct now, but if further changes are needed, someone else please take over since I won't be around. :)
     

    Attached Files:

    Pieter Boelen likes this.
  2. Jack Rackham

    Jack Rackham HoO Team Member Quest Writer Storm Modder

    Joined:
    Jul 5, 2004
    Messages:
    3,288
    Gender:
    Male
    Occupation:
    math teacher
    Location:
    Sund, Ramsjö, Sweden
    I just saw this:

    If it's not already corrected ""
     
    Pieter Boelen and Tingyun like this.
  3. Tingyun

    Tingyun Corsair Storm Modder

    Joined:
    Aug 8, 2016
    Messages:
    1,445
    Gender:
    Male
    Thanks Jack Rackham--caught that error myself too, was already corrected in posted version.

    Sorry about the initial errors--lack of sleep and too much work made me rather careless.:p
     
  4. Levis

    Levis Find(Rum) = false; Staff Member Programmer Creative Support Storm Modder

    Joined:
    Oct 6, 2013
    Messages:
    6,697
    Gender:
    Male
    Occupation:
    ICT
    Location:
    University Twente (Netherlands)
    so this will do the trick?
    Please provide a version where you uncommented the lines so they actually work.
     
  5. Tingyun

    Tingyun Corsair Storm Modder

    Joined:
    Aug 8, 2016
    Messages:
    1,445
    Gender:
    Male
    @Levis The current posted version already blocks all knives and tools. I think the posted version it is good and ready for implementation.

    The commented lines we discussed would make it more extreme, blocking hatchets and daggers.

    I suggest we do the moderate version already posted first, and leave those more extreme lines commented. If people still complain, then we can uncomment them and block the daggers and hatchets too, but I think it best to start more moderate? :)
     
    Pieter Boelen and Levis like this.
  6. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,615
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    Sounds wise to me! :cheers
     
  7. Jason

    Jason Buccaneer Storm Modder

    Joined:
    Jan 1, 1970
    Messages:
    2,733
    Gender:
    Male
    Location:
    USA
    I think there is some work that needs to done here. I encountered a soldier on a war ship with a breadknife. A breadknife really? Must have been the cook. But he was in his full uniform so you would think we would have had time to grab a real blade. ;) Also found a soldier with a spade.

    No if feels more real if merchant sailors have things like axes and hatchets , but I don't think this is quite right.
     
  8. ANSEL

    ANSEL Corsair Storm Modder Hearts of Oak Donator

    Joined:
    Aug 18, 2013
    Messages:
    1,769
    Gender:
    Male
    Occupation:
    Artist,Painter
    Location:
    Viborg.Denmark
    Agree. I have seen those bread knife fighters to. Yes something have to
    change indeed.
     
  9. Tingyun

    Tingyun Corsair Storm Modder

    Joined:
    Aug 8, 2016
    Messages:
    1,445
    Gender:
    Male
    Hi @Jason

    Already fixed last week and slotted for inclusion in next release, here is a link for you to download: Fixed - Blocking worst weapons from everyone | Page 2 | PiratesAhoy!

    Hatchets and daggers remain by design, but all other knives and tools are blocked from being randomly equipped. If you want a more extreme version with hatchets and daggers blocked too, search for the prepreapred commented lines and uncomment them, and they will be blocked too.

    There is a separate issue of enemies getting wrong nationality weapons (i.e., all axes are marked pirate and should not appear on soldiers). That is still awaiting a fix, but is an old preexisting issue and shouldn't bother you too much in the meantime.

    So, download that file, press F11, and your issue should be basically fixed. :)
     
  10. Jason

    Jason Buccaneer Storm Modder

    Joined:
    Jan 1, 1970
    Messages:
    2,733
    Gender:
    Male
    Location:
    USA
    Thanks, Tingyun.
     
  11. ANSEL

    ANSEL Corsair Storm Modder Hearts of Oak Donator

    Joined:
    Aug 18, 2013
    Messages:
    1,769
    Gender:
    Male
    Occupation:
    Artist,Painter
    Location:
    Viborg.Denmark
    I'm not sure about that fix, I have it installed, but I think I still
    sees tools in navy ships crew, but led us wait and see what @Jason
    find out now.
     
  12. Tingyun

    Tingyun Corsair Storm Modder

    Joined:
    Aug 8, 2016
    Messages:
    1,445
    Gender:
    Male
    @ANSEL If that is the case then you have the old first attempt at the fix installed, which was an entirely different way of trying to fix that didn't work out. That was the one you reported installing in that thread, and then later we did something entirely different.

    The later very different fix that I linked has been tested, and does indeed work to block tools and knives, for newly generated characters after installation and pressing f11.
     
  13. ANSEL

    ANSEL Corsair Storm Modder Hearts of Oak Donator

    Joined:
    Aug 18, 2013
    Messages:
    1,769
    Gender:
    Male
    Occupation:
    Artist,Painter
    Location:
    Viborg.Denmark
    OK I will try to reinstall it. And I'd like to hear what @Jason find out to.
    Anyway there's a lot going on right now, keep an overview of it all can be
    hard, when you are testplaying. :)
     
  14. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,615
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    Very true! :yes
     
  15. Tingyun

    Tingyun Corsair Storm Modder

    Joined:
    Aug 8, 2016
    Messages:
    1,445
    Gender:
    Male
    @ANSEL completely understandable, and your willingness to test the initial prototype version was much appreciated and contributed to being able to make a better solution later.

    It might help players keep track and focus bug reports if @Levis includes the latest general fixes posted to New Content in his Levis Fixes release as well, most of the stuff posted to new content in the past several weeks hasn't been included.
     
  16. Levis

    Levis Find(Rum) = false; Staff Member Programmer Creative Support Storm Modder

    Joined:
    Oct 6, 2013
    Messages:
    6,697
    Gender:
    Male
    Occupation:
    ICT
    Location:
    University Twente (Netherlands)
    I will try to make a new zip again somewhere this week
     
    Tingyun and Pieter Boelen like this.

Share This Page