Fixed escorting merchant ships

[kaizerkat]

i had a mission and still do to escort this merchant to NEW GRENADA, cartegena and when i had arrived at port and to the pier i found no merchant to say thanks. Although, to find out he is still part of my fleet and still waiting to be escorted to the island. So, when i talked to him he states " i saw you fight with our cap, and according to our law, this is your ship now." and basically i can find it at palm beach. I was wondering why the quest was not completed when arriving at port. Any thoughts?

 

[Hylie Pistof]

Some of the escort missions are bugged. I haven't tried the Cartagena one but was under the impression it worked.

To end a bugged escort mission kill that Captain. The escort mission will be deleted with no loss of reputation.

 

[kaizerkat]

ok thanks and i will take the merchants cargo 1st

 

[Pieter Boelen]

I'm pretty sure I tested the Cartagena escort quest and it worked fine.

If anyone knows of specific ports that don't work, make a list so that I can test and fix them some time.

 

[pherox]

i had a mission and still do to escort this merchant to NEW GRENADA, cartegena and when i had arrived at port and to the pier i found no merchant to say thanks. Although, to find out he is still part of my fleet and still waiting to be escorted to the island. So, when i talked to him he states " i saw you fight with our cap, and according to our law, this is your ship now." and basically i can find it at palm beach. I was wondering why the quest was not completed when arriving at port. Any thoughts?

Just wanted to confirm that i had the same problem. i get to port and my character becomes stuck and the captain doesn't show up. :/

 

[Hylie Pistof]

Ok, I have started doing escort missions also and have not found a bad one yet, but have not been to Cartagena yet.

That mission looks to be broken. To get out of it go to that Captains cabin and kill him. That will make the mission disappear with no loss of reputation to you.

 

[Pieter Boelen]

Which modpack version was that? Can you post a savegame just prior to making port in Cartagena?

 

[Hylie Pistof]

I just got an escort mission to Cartagena and it is broken. I made it there ok but no one was on the dock. I could move freely. I went to the other ship and the Captain was talking gibberish, so I killed him. I then got -5 reputaion.

Here is a save from just before landing in the La Croix storyline.

 

[Pieter Boelen]

I think I found the problem. That was a SERIOUSLY well-hidden one!
Will you believe it was because the location init file was called "Cartagena.c" instead of "Colombia.c"?
The game got all confused on its town and island names and therefore it wouldn't work.

 

[Grey Roger]

Why does Cartagena work at all, then? I've certainly visited Cartagena and found all the significant buildings (store, shipyard, taverns etc.), though that was in Beta 3, and I wasn't escorting anything. What does "Cartagena.c" do, and what is broken if it is supposed to be "Colombia.c"?

 

[Pieter Boelen]

Everything works just fine. I had no clue that the file name made any difference whatsoever.
But this code here uses an "IslandsList":

      for(int di=sti(Locations[0].IslandsList.(sIsland).begin); di<sti(Locations[0].IslandsList.(sIsland).end); di++)
       {
         if(CheckAttribute(&locations[di],"townsack") && locations[di].townsack==pchar.quest.generate_convoy_quest.destination)
         {
           if(CheckAttribute(&locations[di],"id") && HasSubStr(locations[di].id,"port"))
           {
             sdest = locations[di].id;
             break;
           }
         }
         else
         {
           switch(sIsland)
           {
             case DEFAULT_TRADEISLAND: sdest = "Conceicao_shore_02"; break;
           }
           if(sdest!="") break;
         }
       }

And for some reason, that has been coded to depend on the filenames instead of the actual code inside them.
Anyway, it is caught now and will be fixed in the next modpack update.