1. Dismiss Notice
  2. GOG.com logo

    Thanks to YOUR votes, GOG.com now sells:
    - Sea Dogs - Sea Dogs: Caribbean Tales
    - Sea Dogs: City of Abandoned Ships

    Vote now to add Pirates of the Caribbean to the list!

    Dismiss Notice
  3. Under the Crossbones Podcast

    A Pirate Podcast with Interviews
    Music, Comedy and all things Pirate!

    - Episode Guide - About - Subscribe -
    - Twitter - Facebook - iTunes - Android -
    - Youtube - Fill the Coffers -

    Dismiss Notice
  4. New Horizons logo

    Quick links for PotC: New Horizons
    - Download latest version
    - Wiki - FAQ - Report bugs here
    - ModDB profile

  5. GOF logo

    Quick links for AoP2: Gentlemen of Fortune 2
    - Downloads and info
    - Historical Immersion Supermod
    - ModDB Profile

Dismiss Notice
New to the forum?
Please take a moment to read our Welcome Message and Forum Rules.

Fixed GetPatrolTimeText Can Cause Crashes

Discussion in 'Bug Archive' started by Mere_Mortal, May 27, 2016.

  1. lucho1392

    lucho1392 Sailor Apprentice

    Joined:
    Jun 27, 2015
    Messages:
    91
    Gender:
    Male
    Occupation:
    Database Administrator
    Location:
    Costa Rica
    Oh dont get confused. My carpet is called like that but it is the MoD game.

    Sorry, uploading the compile log.

    EDIT: Trying the smugling fix you linked may have fixed one crash. But got to try if there is random crashing ocurring.
     

    Attached Files:

    Last edited: Jun 13, 2016
  2. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,623
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    Might I assume you get these crashes when you are walking around ashore and/or if dialogs are being started with characters?
    Especially in taverns? Or perhaps when talking to one of your officers in certain locations?

    Thanks. Indeed you do have the very latest version I posted.

    However, the "latest version" is a bit out-of-date by now. Making a new one is high on my priority list, but may have to wait until Sunday or so.
    In the meantime, install the fix from here: Fixed - GetPatrolTimeText Can Cause Crashes | PiratesAhoy!

    According to your error.log file, that is indeed the problem that you ran into.
     
  3. lucho1392

    lucho1392 Sailor Apprentice

    Joined:
    Jun 27, 2015
    Messages:
    91
    Gender:
    Male
    Occupation:
    Database Administrator
    Location:
    Costa Rica
    Yeah hahaha wrote that the smugling crash was fixed but still need to see if theres any random crashes ocurring. Because before that smugling problem the game just crashed a lot. Like in the middle of sea battles, arriving at port, in the middle of a city, etc.
     
  4. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,623
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    Each crash must have a specific reason, in which case they'd need separate issues on the Bug Tracker.

    If there is no apparent reason, it becomes a "Random Crashes" issue, which are notoriously difficult (and virtually impossible) to fix.
    We have this recent report for example: Unconfirmed Bug - Inconsistent Crash After Boarding Completes | PiratesAhoy!
     
  5. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,623
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
  6. Babberdeggl

    Babberdeggl Landlubber

    Joined:
    Feb 9, 2017
    Messages:
    6
    Hello, first of all great mod thanks for that.

    I've got a problem with getting my hands on coastguard plans. Everytime i'm about to get said plans my game just crashes.
    I'm using build 14 beta 4 2.April 2016

    And this is what my error.log looks like:
    RUNTIME ERROR - file: smuggling.c; line: 962
    incorrect argument index
    RUNTIME ERROR - file: smuggling.c; line: 962
    Bad function argument
    RUNTIME ERROR - file: smuggling.c; line: 963
    missed attribute: start
    RUNTIME ERROR - file: smuggling.c; line: 963
    no rAP data
    RUNTIME ERROR - file: smuggling.c; line: 964
    missed attribute: end
    RUNTIME ERROR - file: smuggling.c; line: 964
    no rAP data

    Is there anything i can do about it?
     

    Attached Files:

  7. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,623
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    The only thing you can try at the moment is to update to the Mod Release - Build 14 Beta 4.1 WIP [Last Update: 7 January 2017] | PiratesAhoy! version.
    This does require you to start a new game, but should definitely be more playable.

    I don't remember that particular error from before, so I cannot guarantee it has already been fixed.
    But hopefully it will not happen again with the newer version.
     
  8. Babberdeggl

    Babberdeggl Landlubber

    Joined:
    Feb 9, 2017
    Messages:
    6
    I thought i'm using the latest version. I downloaded it from moddb :modding

    Well i guess i have to live with it then, because i invested way too much time in this save to start over. Thank you for the quick reply though.
     
  9. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,623
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    You have the latest public release. The real latest version is still considered "Work In Progress".
    It should, however, be objectively more playable than the ModDB version. We just haven't had the time to make a proper release of it.

    Can you upload your PROGRAM\smuggling.c file? I wonder if it is possible to create a quick-fix.

    @Grey Roger or @Jack Rackham: Could you also upload your version of the same file?
    Maybe this was already fixed and that fix could be easily adapted to the 2 Apr 2016 version?
    Would need to see by WinMerging both versions of the file.
     
  10. Babberdeggl

    Babberdeggl Landlubber

    Joined:
    Feb 9, 2017
    Messages:
    6
    Sure, here it is.
     

    Attached Files:

  11. Grey Roger

    Grey Roger Sea Dog Staff Member Storm Modder

    Joined:
    Feb 12, 2007
    Messages:
    6,415
    My version will be the one from the 7th January release. But I've no idea if it works because I never do smuggling.
     

    Attached Files:

    Pieter Boelen likes this.
  12. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,623
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    I think you're in luck! Looks like I did already make a fix for that last year:
    Fixed - GetPatrolTimeText Can Cause Crashes | PiratesAhoy!

    Save attached file to your PROGRAM folder.
    DON'T use the one attached in that thread, but this one instead.
     

    Attached Files:

  13. Babberdeggl

    Babberdeggl Landlubber

    Joined:
    Feb 9, 2017
    Messages:
    6
    thanks a lot i'll try it.
     
  14. Babberdeggl

    Babberdeggl Landlubber

    Joined:
    Feb 9, 2017
    Messages:
    6
    It is working, but when i get the plans, it just says: "the best time to go is." But it doesn't tell me any time.
    Is that supposed to be like this?

    And i just encountered a different minor problem. When i use the "sail to" option everything is fine, except the port names. It just shows #stown_name# Port.
     
    Last edited: Feb 9, 2017
  15. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,623
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    The reason why it crashed is because there aren't any patrols on the island at all.
    It isn't quite intentional (and should probably behave slightly better in the 7 Jan 2017 version), but you can interpret it as meaning "anything goes".
    In other words: In this case, the best time is whenever you want.

    Looks like that has happened to someone else before as well:
    Fixed - "#stown_name#" Showing in 3D Sailing Mode (Sail-To + Spyglass) | Page 2 | PiratesAhoy!
    This is what I suggested that time as a fix:
    See here point #4 for how to do that:
    Tutorial - Modding Tips & Tricks | PiratesAhoy!
     
  16. Babberdeggl

    Babberdeggl Landlubber

    Joined:
    Feb 9, 2017
    Messages:
    6
    Everthing is working. Big thanks for your effort. :monkeydance
     
    Pieter Boelen likes this.
  17. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,623
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands

Share This Page