• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Solved Hitman quest Jack Sparrow storyline

VanessaHudgensFan

Freebooter
Banned
So now the Larrouse and Turks quests works I'm moving on to the Hitman one. I should work already but it don't for some reason. When I enter the Sao Jorge Tavern where the quest should start (Ambroz Bricenos should apprear and talk to you) Thomas Tipman apprears and he talks to me and said nothing??? There is no dialog there so something should be wrong somewhere, not much errors to post exept this:
RUNTIME ERROR - file: utils.c; line: 2301
Invalid range

Here is my compile file, I think you can more with that and I hope you can see what is wrong here

Code:
ItemLogic: On load location Conceicao_Tavern
ItemLogic: found 0 buttons
Quest name Hit_start FOUND in QuestComplete
Quest name Hit_Rumor FOUND in QuestComplete
::: QUESTMOVIE: StartQuestMovie func call
::: QUESTMOVIE: start in Hit_start_check
Quest name hit_start_check FOUND in QuestComplete
SETTING MUSIC: music_tavern
SETTING MUSIC: music_tavern
 
That has always worked before for me. What would break it?

It can't be work for you because that quest isn't in that storyline yet :razz. I'm working on a way to add the side quests of the Standard storyline in the Jack Sparrow storyline and that is were the problems start. Most quests are already added but the Hitman quest causes trouble. Ambroz Bricenos doesn't apprear in the Tavern but there apprears a Thomas Tipman who talk to me with no dialog, what does he there, he isn't in that quest.
 
Sounds to me like a dialognode which isn't in his dialog file. This is probally cause a different character is send.
Check the jack sparrow characters init. maybe there is a thomas tipman in there with an other ID to make something else work in the storyline.
 
Sounds to me like a dialognode which isn't in his dialog file. This is probally cause a different character is send.
Check the jack sparrow characters init. maybe there is a thomas tipman in there with an other ID to make something else work in the storyline.

This is the only Thomas Tipman I can find there:

Code:
    ch.old.name = "Thomas";
    ch.old.lastname = "Tipman";
    ch.name = TranslateString("","Thomas");
    ch.lastname = TranslateString("","Tipman");;
    ch.id        = "Thomas Tipman";
    ch.model    = "Searcher";
    ch.sex = "man";
    GiveItem2Character(ch, BLADE_SABER);
    ch.equip.blade = BLADE_SABER;
    ch.location    = "";
    ch.location.group = "";
    ch.location.locator = "";
    ch.Dialog.Filename = "Thomas Tipman_dialog.c";
    ch.rank     = 1;
    ch.reputation = "None";
    ch.experience = "0";
    ch.skill.Leadership = "1";
    ch.skill.Fencing = "1";
    ch.skill.Sailing = "1";
    ch.skill.Accuracy = "1";
    ch.skill.Cannons = "1";
    ch.skill.Grappling = "1";
    ch.skill.Repair = "1";
    ch.skill.Defence = "1";
    ch.skill.Commerce = "1";
    ch.skill.Sneak = "1";
    ch.money = "10";
    LAi_SetStayType(ch); // PB
    LAi_SetLoginTime(ch, 0.0, 24.0);
    LAi_SetHP(ch, 80.0, 80.0);
    AddGameCharacter(n, ch);

Ambroz Bricenos even doesn't apprear in the Tavern. The Hitman quest thing in the startstoryline is there and the characters are in the Sparrow character too, maybe something wrong in both_reactions.c?
 
Maybe ... but if you copied it from the standard storyline it should work.
Could you post the relevant code for this part?
 
Eeeh this part, it's not a easy code to read....

Code:
    //Hitman Edited by SCM

        case "Hit_start":
            SetEnterLocationQuest("Conceicao_tavern", "Hit_start_check", 0);
            chrEnableReloadLocator("Muelle_town_01", "Reload21", 0);
            chrEnableReloadLocator("Greenford_town", "reload5", 0);
            chrEnableReloadLocator("Conceicao_town", "reload15", 0);
            chrEnableReloadLocator("Hit_house", "Reload2", 0); //SCM
            chrEnableReloadLocator("Hit_study", "Reload1", 0); //SCM
            chrEnableReloadLocator("Hit_study", "Reload2_back", 0); //SCM
            chrEnableReloadLocator("Hit_passage", "Reload10", 0); //SCM
            // NK -->
            PChar.quest.Hit_Rumor.win_condition.l1 = "rank";
            PChar.quest.Hit_Rumor.win_condition.l1.character = Pchar.id;
            PChar.quest.Hit_Rumor.win_condition.l1.value = 5;
            PChar.quest.Hit_Rumor.win_condition.l1.operation = ">=";
            PChar.quest.Hit_Rumor.win_condition = "Hit_Rumor";
        break;

        case "Hit_Rumor":
            SetRumourState("Hitman_start", true); // NK <--
        break;

        case "Hit_start_check":
            if(makeint(PChar.rank) >= 5)
            {
                SetRumourState("Hitman_start", false); // NK
                StartQuestMovie(true, false, false);TrackQuestMovie("start","Hit_start_check");

                bDisableFastReload = 1;

                ChangeCharacterAddressGroup(CharacterFromID("Ambroz Bricenos"), "Conceicao_tavern", "goto", "goto4");
                ChangeCharacterAddressGroup(CharacterFromID("Mateus Santos"), "Hit_house", "goto", "goto7"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Desiree' Muerte"), "Hit_house", "goto", "goto3"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Thug2"), "Hit_house", "goto", "goto4"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Thug3"), "Hit_house", "goto", "goto5"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Thug4"), "Hit_house", "goto", "goto1"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Thug5"), "Hit_house", "goto", "goto9"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Thug6"), "Hit_house", "goto", "goto6"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Thug7"), "Hit_house", "goto", "goto2"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Thug8"), "Hit_house", "goto", "goto8"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Thug9"), "Hit_passage", "sit", "sit1"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Camille Leone"), "Hit_passage", "goto", "goto9"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Pris1"), "Hit_passage", "goto", "goto1"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Pris2"), "Hit_passage", "goto", "goto2"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Pris3"), "Hit_passage", "goto", "goto3"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Pris4"), "Hit_passage", "goto", "goto4"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Geffrey Bampfylde"), "Hit_house1", "goto", "goto6"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Bucho"), "Hit_house1", "goto", "goto1"); //SCM
                ChangeCharacterAddressGroup(CharacterFromID("Amerigo Vieira"), "Hit_house2", "goto", "goto4");

                LAi_SetImmortal(CharacterFromID("Ambroz Bricenos"), 1);
                LAi_SetImmortal(CharacterFromID("Mateus Santos"), 1);
                LAi_SetImmortal(CharacterFromID("Desiree' Muerte"), 1); //SCM
                LAi_SetImmortal(CharacterFromID("Thug2"), 1);
                LAi_SetImmortal(CharacterFromID("Thug3"), 1);
                LAi_SetImmortal(CharacterFromID("Thug9"), 1);
                LAi_SetImmortal(CharacterFromID("Camille Leone"), 1);
                LAi_SetImmortal(CharacterFromID("Geffrey Bampfylde"), 1);
                LAi_SetImmortal(CharacterFromID("Bucho"), 1);
                LAi_SetImmortal(CharacterFromID("Pepin Bertillon"), 1);
                LAi_SetImmortal(CharacterFromID("Bertillon's guard1"), 1);
                LAi_SetImmortal(CharacterFromID("Bertillon's guard2"), 1);
                LAi_SetImmortal(CharacterFromID("Amerigo Vieira"), 1);
                LAi_SetImmortal(CharacterFromID("Vito Leone"), 1);

                LAi_SetWarriorType(CharacterFromID("Mateus Santos"));
                LAi_SetWarriorType(CharacterFromID("Desiree' Muerte")); //SCM
                LAi_SetWarriorType(CharacterFromID("Thug2"));
                LAi_SetWarriorType(CharacterFromID("Thug3")); //SCM
                LAi_SetWarriorType(CharacterFromID("Thug4")); //SCM
                LAi_SetWarriorType(CharacterFromID("Thug5")); //SCM
                LAi_SetWarriorType(CharacterFromID("Thug6")); //SCM
                LAi_SetWarriorType(CharacterFromID("Thug7")); //SCM
                LAi_SetWarriorType(CharacterFromID("Thug8")); //SCM

                LAi_warrior_SetStay(CharacterFromID("Mateus Santos"), 1);
                LAi_warrior_SetStay(CharacterFromID("Desiree' Muerte"), 1); //SCM
                LAi_warrior_SetStay(CharacterFromID("Thug2"), 1);
                LAi_warrior_SetStay(CharacterFromID("Thug3"), 1); //SCM
                LAi_warrior_SetStay(CharacterFromID("Thug4"), 1); //SCM
                LAi_warrior_SetStay(CharacterFromID("Thug5"), 1); //SCM
                LAi_warrior_SetStay(CharacterFromID("Thug6"), 1); //SCM
                LAi_warrior_SetStay(CharacterFromID("Thug7"), 1); //SCM
                LAi_warrior_SetStay(CharacterFromID("Thug8"), 1); //SCM
                LAi_warrior_SetStay(CharacterFromID("Camille Leone"), 1); //SCM

                LAi_warrior_DialogEnable(CharacterFromID("Mateus Santos"), 1);
                LAi_warrior_DialogEnable(CharacterFromID("Desiree' Muerte"), 1); //SCM
                LAi_warrior_DialogEnable(CharacterFromID("Thug2"), 1);
                LAi_warrior_DialogEnable(CharacterFromID("Thug3"), 1); //SCM
                LAi_warrior_DialogEnable(CharacterFromID("Thug4"), 1); //SCM
                LAi_warrior_DialogEnable(CharacterFromID("Thug5"), 1); //SCM
                LAi_warrior_DialogEnable(CharacterFromID("Thug6"), 1); //SCM
                LAi_warrior_DialogEnable(CharacterFromID("Thug7"), 1); //SCM
                LAi_warrior_DialogEnable(CharacterFromID("Thug8"), 1); //SCM
                LAi_warrior_DialogEnable(CharacterFromID("Thug9"), 1); //SCM
                LAi_warrior_DialogEnable(CharacterFromID("Camille Leone"), 1); //SCM

                //LAi_group_MoveCharacter(CharacterFromID("Mateus Santos"), "santos_group");
                //LAi_group_MoveCharacter(CharacterFromID("Desiree' Muerte"), "santos_group"); //SCM
                LAi_group_MoveCharacter(CharacterFromID("Thug2"), "santos_group");
                //LAi_group_MoveCharacter(CharacterFromID("Thug3"), "santos_group");
                LAi_group_MoveCharacter(CharacterFromID("Thug4"), "santos_group"); //SCM
                LAi_group_MoveCharacter(CharacterFromID("Thug5"), "santos_group"); //SCM
                LAi_group_MoveCharacter(CharacterFromID("Thug6"), "santos_group"); //SCM
                LAi_group_MoveCharacter(CharacterFromID("Thug7"), "santos_group"); //SCM
                LAi_group_MoveCharacter(CharacterFromID("Thug8"), "santos_group"); //SCM

                LAi_group_SetRelation("santos_group", "santos_group", LAI_GROUP_FRIEND);
                LAi_SetHuberType(characterfromID("Thug9")); //SCM
                LAi_SetActorType(CharacterFromID("Ambroz Bricenos"));
                Characters[GetCharacterIndex("Ambroz Bricenos")].dialog.currentnode = "wetjob";
                LAi_ActorDialog(CharacterFromID("Ambroz Bricenos"), PChar, "", 15.0, -1);
            }
        break;

        case "Hit_END":
            Characters[GetCharacterIndex("Ambroz Bricenos")].Location = "none";
            Characters[GetCharacterIndex("Mateus Santos")].Location = "none";
            Characters[GetCharacterIndex("Thug2")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug4")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug5")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug6")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug7")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug8")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug9")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Pris1")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Pris2")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Pris3")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Pris4")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Camille Leone")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Geffrey Bampfylde")].Location = "none";
            Characters[GetCharacterIndex("Bucho")].Location = "none";
            Characters[GetCharacterIndex("Pepin Bertillon")].Location = "none";
            Characters[GetCharacterIndex("Bertillon's guard1")].Location = "none";
            Characters[GetCharacterIndex("Bertillon's guard2")].Location = "none";
            Characters[GetCharacterIndex("Amerigo Vieira")].Location = "none";
            Characters[GetCharacterIndex("Vito Leone")].Location = "none";

            chrEnableReloadLocator("Muelle_town_01", "Reload21", 0);
            chrEnableReloadLocator("Greenford_town", "reload5", 0);
            chrEnableReloadLocator("Conceicao_town", "reload15", 0);

            PChar.quest.Hitman = "end";
            PChar.quest.Hitman.over = "yes";
            CloseQuestHeader("Hitman");
        break;

        case "Hit_END_timer":
            Characters[GetCharacterIndex("Ambroz Bricenos")].Location = "none";
            Characters[GetCharacterIndex("Mateus Santos")].Location = "none";
            Characters[GetCharacterIndex("Desiree' Muerte")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug2")].Location = "none";
            Characters[GetCharacterIndex("Thug3")].Location = "none";
            Characters[GetCharacterIndex("Thug4")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug5")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug6")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug7")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug8")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Thug9")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Camille Leone")].Location = "none"; //SCM
            Characters[GetCharacterIndex("Geffrey Bampfylde")].Location = "none";
            Characters[GetCharacterIndex("Bucho")].Location = "none";
            Characters[GetCharacterIndex("Pepin Bertillon")].Location = "none";
            Characters[GetCharacterIndex("Bertillon's guard1")].Location = "none";
            Characters[GetCharacterIndex("Bertillon's guard2")].Location = "none";
            Characters[GetCharacterIndex("Amerigo Vieira")].Location = "none";
            Characters[GetCharacterIndex("Vito Leone")].Location = "none";

            chrEnableReloadLocator("Muelle_town_01", "Reload21", 0);
            chrEnableReloadLocator("Greenford_town", "reload5", 0);
            chrEnableReloadLocator("Conceicao_town", "reload15", 0);

            PChar.quest.Hitman = "end";

            //Add journal entry
            AddQuestRecord("Hitman", 21);
            CloseQuestHeader("Hitman");
        break;

        case "Hit_timer1":
            PChar.quest.Hit_timer1.win_condition.l1 = "Timer";
            PChar.quest.Hit_timer1.win_condition.l1.date.day = GetAddingDataDay(0, 3, 0);    //TALISMAN was 0,1,0 which closes quest when player exits Santos house right after being given task
            PChar.quest.Hit_timer1.win_condition.l1.date.month = GetAddingDataMonth(0, 3, 0);
            PChar.quest.Hit_timer1.win_condition.l1.date.year = GetAddingDataYear(0, 3, 0);    //TALISMAN was 0,1,0 which closes quest when player exits Santos house right after being given task
            PChar.quest.Hit_timer1.win_condition = "Hit_END_timer";
        break;

        case "Hit_timer2":
            PChar.quest.Hit_timer2.win_condition.l1 = "Timer";
            PChar.quest.Hit_timer2.win_condition.l1.date.day = GetAddingDataDay(0, 3, 0);     //TALISMAN was 0,1,0 which closes quest when player exits Santos house right after being given task
            PChar.quest.Hit_timer2.win_condition.l1.date.month = GetAddingDataMonth(0, 3, 0);
            PChar.quest.Hit_timer2.win_condition.l1.date.year = GetAddingDataYear(0, 3, 0);     //TALISMAN was 0,1,0 which closes quest when player exits Santos house right after being given task
            PChar.quest.Hit_timer2.win_condition = "Hit_END_timer";
        break;

        case "Hit_timer3":
            PChar.quest.Hit_timer3.win_condition.l1 = "Timer";
            PChar.quest.Hit_timer3.win_condition.l1.date.day = GetAddingDataDay(0, 3, 0);     //TALISMAN was 0,1,0 which closes quest when player exits Santos house right after being given task
            PChar.quest.Hit_timer3.win_condition.l1.date.month = GetAddingDataMonth(0, 3, 0);
            PChar.quest.Hit_timer3.win_condition.l1.date.year = GetAddingDataYear(0, 3, 0);     //TALISMAN was 0,1,0 which closes quest when player exits Santos house right after being given task
            PChar.quest.Hit_timer3.win_condition = "Hit_END_timer";
        break;

        case "Hit_timer4":
            PChar.quest.Hit_timer4.win_condition.l1 = "Timer";
            PChar.quest.Hit_timer4.win_condition.l1.date.day = GetAddingDataDay(0, 3, 0);     //TALISMAN was 0,1,0 which closes quest when player exits Santos house right after being given task
            PChar.quest.Hit_timer4.win_condition.l1.date.month = GetAddingDataMonth(0, 3, 0);
            PChar.quest.Hit_timer4.win_condition.l1.date.year = GetAddingDataYear(0, 3, 0);     //TALISMAN was 0,1,0 which closes quest when player exits Santos house right after being given task
            PChar.quest.Hit_timer4.win_condition = "Hit_END_timer";
        break;

        case "Hit_timer5":
            PChar.quest.Hit_timer5.win_condition.l1 = "Timer";
            PChar.quest.Hit_timer5.win_condition.l1.date.day = GetAddingDataDay(0, 3, 0);     //TALISMAN was 0,1,0 which closes quest when player exits Santos house right after being given task
            PChar.quest.Hit_timer5.win_condition.l1.date.month = GetAddingDataMonth(0, 3, 0);
            PChar.quest.Hit_timer5.win_condition.l1.date.year = GetAddingDataYear(0, 3, 0);     //TALISMAN was 0,1,0 which closes quest when player exits Santos house right after being given task
            PChar.quest.Hit_timer5.win_condition = "Hit_END_timer";
        break;

        case "Hit_refused_Ambroz":
        // dialog exit from Ambroz
            DeleteEnterLocationQuest("Conceicao_tavern", "Hit_start_check");
            LAi_ActorGoToLocation(CharacterFromID("Ambroz Bricenos"), "reload", "reload1", "none", "", "", "Hit_refused_Ambroz_end", 3.0);
        break;

        case "Hit_refused_Ambroz_end":
            EndQuestMovie();TrackQuestMovie("end","Hit_refused_Ambroz_end");
            bDisableFastReload = 0;

            //END QUEST
            LAi_QuestDelay("Hit_END", 0.0);
        break;

        case "Hit_start1":
        // dialog exit from Ambroz
            DeleteEnterLocationQuest("Conceicao_tavern", "Hit_start_check");
            PChar.quest.Hitman = "goto_mateus";
            LAi_ActorGoToLocation(CharacterFromID("Ambroz Bricenos"), "reload", "reload1", "Conceicao_shore_02", "goto", "citizen06", "Hit_start2", 3.0);
            chrEnableReloadLocator("Muelle_town_01", "reload21", 1);

            //Add journal entry
            SetQuestHeader("Hitman");
            AddQuestRecord("Hitman", 1);
        break;

        case "Hit_start2":
            EndQuestMovie();TrackQuestMovie("end","Hit_start2");

            bDisableFastReload = 0;

            LAi_SetWarriorType(CharacterFromID("Ambroz Bricenos"));
            LAi_warrior_SetStay(CharacterFromID("Ambroz Bricenos"), 1);
            LAi_warrior_DialogEnable(CharacterFromID("Ambroz Bricenos"), 1);

            PChar.quest.Hit_start3.win_condition.l1 = "location";
            PChar.quest.Hit_start3.win_condition.l1.location = "Hit_house";
            PChar.quest.Hit_start3.win_condition = "Hit_start3";
        break;

        case "Hit_start3":
            StartQuestMovie(true, false, false);TrackQuestMovie("start","Hit_start3");
            LAi_SetActorType(PChar);
            Characters[GetCharacterIndex("Mateus Santos")].dialog.currentnode = "start";
            LAi_ActorDialog(PChar, CharacterFromID("Mateus Santos"), "", 10.0, -1);
        break;
 
What's wrong with it?

Code:
Quest name Hit_start FOUND in QuestComplete
Quest name Hit_Rumor FOUND in QuestComplete
::: QUESTMOVIE: StartQuestMovie func call
::: QUESTMOVIE: start in Hit_start_check
Quest name hit_start_check FOUND in QuestComplete
SETTING MUSIC: music_tavern
SETTING MUSIC: music_tavern
SetCharacterTask_GotoPoint -> locator 'stay1' in group 'tables' not found
Template <goto> -> path not found chr.id = Conceicao_officiant
 
Either your WIP files are added by Pieter or there is a WIP version of the hitman quest in it already.
At least in the files I have at row 8453 there is Thomas Tipman who comes to you for the hitman quest but no dialog node is assigned to him so he says nothing.
I think there is your problem.
Remove the pieces which are already added. Search for the quest headers in quest_reactions.c (in jack sparrow storyline).
 
Eeeehm with file are you talking about exactly and where can I find that Thomas Tipman part?

Why is he there, he has nothing to do with the Hitman quest, it's Ambroz Bricenos who has to be there not Thomas Tipman and Bricenos has a dialog doesn't he.

Which lines must I delete and which must I add? I don't get it I'm afraid.

If you want I can send you my both_reaction file from the Jack Sparrow storyline so you can take a look at it but it's not finished for all side quests, I'm working on the Santiago quest too and it isn't finished yet, almost I think
 
Search for hit_start in quest_reactions then you will find it.
He changed it a bit so Thats why thomas is used, but he never finnished it.
 
Don't see Thomas Tipman, think I need some glasses or something :p

This is what I got in both_reaction in the Jack Sparrow storyline, copy from the text in the quest_reaction of Standard one. Can you tell me what I must do to get it working and which rules must be deleted or do it for me, little bit busy at the moment ;)

Time is really a problem, or you have to much or to little hehehe :p
 

Attachments

  • Both reaction file.zip
    37.6 KB · Views: 87
Last edited:
look in QUEST_REACTIONS not both_reactions
 
look in QUEST_REACTIONS not both_reactions

He you're right, I see him, what is he doing there? Never add him there but anyway how can I fix this problem. Normally Ambroz Bricenos should be there shouldn't he. How can I fix it, which lines need to be changed exactly?
 
Back
Top