Fixed Levelling: Missing Ships and Crashes on Encounter Reload from Worldmap to Sea

[ANSEL]

When You find a enemy ship, on the worldmap, and goes to Sea game crash's.
The ship encounter act weird too, sometimes there is no enemy ship at all, or if there
are it is ind a very long distance, tasting go to ship, game crash's again. I have notice
this for some times. Haven't got any errorlog yet.

 

[Levis]

Haven't had this error...
Can you think of any thing you have different from the way the game is set up (changes in the internal settings etc)?

 

[Pieter Boelen]

For some time? How long? Give or take....
Need to know in which modpack version of started.

Is this only with worldmap encounters? Or DirectSail too.
Last time I had crashes on the map, it was because of a infinite loop in the code that I caused, but that was a few months back and is already fixed now.

 

[ANSEL]

Maybe a week or two. DirectSail too I think, its a little vague I know. It occurs after I
have played the game for some time. Sorry I cant be more exactly right now.
PS. It happens just now, and this time it gave a errorlog.

 

[ANSEL]

Is it intended nation is set as personal, per default, in the standard storyline now?
Its a little strange, I think, and maybe this is the reason for some problems I had
in this storyline. I give up playing it now. Try to give it a chance in a new game.
Crashes at Sea and some bugs on Martinique stop me playing it.

 

[Pieter Boelen]

Starting nation had been Personal in the Standard Storyline since Build 13 when we didn't even have storylines at all.
So that isn't new.

 

[ANSEL]

I'm standing corrected

 

[Pieter Boelen]

@ANSEL: Can you show a screenshot of your Nations Relations Interface? And were you flying a Personal Flag when the crashes occurred?

I may have a clue of what is going on:
If you start the game with only the Pirates hostile and you get them to turn neutral too, then you have no enemies left.
Which means the game may try to generate a hostile worldmap ship to follow you, but fails because that results in an infinite loop.

This could be a side effect of me fixing that code so it actually looks at your real relations and flag.
It never used to do anything correct until I rewrote the code two months back.

It used to generate such ships based on the stock game relations of Pirate and France being hostile and nobody else.
This was completely regardless of your actual nation relations and also ignored the flag you were flying.
Not anymore....

 

[ANSEL]

I'm just about to start a new game, the old one is deleted, so later I will do it.
Don't know if it will be tonight, haven't sleep enough the latest 2 or 3 days

 

[Pieter Boelen]

So.... No screenshot then? Do you remember if you did have any enemies?

Without that to confirm my suspicion, we still have no clue where this comes from.

 

[ANSEL]

So.... No screenshot then? Do you remember if you did have any enemies?

I will play the standard storyline later today, see what happens now. The french nation was hostile to me at a point, Spanish too.

 

[Pieter Boelen]

Alright then. In the meantime, I'm unconfirming this one as we have no idea if the crashes are at all related to the thread title.

 

[Levis]

Unconfirmed Bug - Crashes due to nation relations | PiratesAhoy!

Could these be related to each other?

 

[Pieter Boelen]

Unconfirmed Bug - Crashes due to nation relations | PiratesAhoy!

Could these be related to each other?

IF that crash on the worldmap indeed does have something to do with nation relations as we have been suspecting, that should apply ONLY to the worldmap.
Because the worldmap call a function that it technically shouldn't call, but it is the game engine doing it, so I can't change the function call.
What I CAN do (and already did do in the past for that very reason) is edit that function and make it behave differently if it is indeed called while the worldmap is active.

Anyway, that has nothing to do with 3D sailing mode.

 

[Levis]

IF that crash on the worldmap indeed does have something to do with nation relations as we have been suspecting, that should apply ONLY to the worldmap.
Because the worldmap call a function that it technically shouldn't call, but it is the game engine doing it, so I can't change the function call.
What I CAN do (and already did do in the past for that very reason) is edit that function and make it behave differently if it is indeed called while the worldmap is active.

Anyway, that has nothing to do with 3D sailing mode.

There is also an encouter generating code working in 3d sailing. Maybe that could cause the same problem?

 

[Pieter Boelen]

There is also an encouter generating code working in 3d sailing. Maybe that could cause the same problem?

That encounter generating code doesn't work the same way. The only potential CTD that I know of is that other issue.
I'll continue in the other thread to detail that one to avoid cluttering this issue with unrelated stuff.

 

[Pieter Boelen]

To clarify: The issue that I know of happens exclusively on the worldmap when the game engine tries to find a hostile nation to generate a "follow ship".
If you search PROGRAM\NATIONS\nations.c for "worldmap", you'll find an exception in a function so that it behaves differently if you're on the worldmap.
That was because of this reason.

I can imagine that for similar reasons, the game may end up in a infinite loop when there are no hostile nations to be found.
But I have absolutely NO clue if that happened here at all. And even if it did, it would be independent from any problems encountered in 3D sailing mode.

 

[ANSEL]

Alright then. In the meantime, I'm unconfirming this one as we have no idea if the crashes are at all related to the thread title.[/QUOTE
I tried again and this time it crash so bad it shut the computer down! Screenshot just before going to Martinique.

I tried again and this time it crash so bad it shut the computer down! Screenshot just before going to Martinique.

 

[ANSEL]

And once again: This time I was allowed to land at the harbor, but I could not move,
hit the console, to the tavern, talk to the captain,got the papers, show it to the
harbor master, escort the ship and sunk it. But now I could not leave the scene
for it, could not go to worldmap any more. It was a real hard job to test this tings.

 

[ANSEL]

The questbook entry is acting crazy now. The screenshot is before I even
have done a thing. Same happen at Spiegtown after talking with the drunk
captain,then it says I completed the escort job successfully even before I
arrived at Martinique? and it don't close after sinking the escort ship.