Fixed Officer error log

A.H · Sep 30, 2015

RUNTIME ERROR - file: seadogs.c; line: 709
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 709
Ghost A reference
RUNTIME ERROR - file: seadogs.c; line: 709
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 709
Ghost A reference
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: Loc_ai\LAi_events.c; line: 3196
missed attribute: sex
RUNTIME ERROR - file: Loc_ai\LAi_events.c; line: 3196
no rAP data
RUNTIME ERROR - file: Loc_ai\LAi_events.c; line: 3196
missed attribute: deathx
RUNTIME ERROR - file: Loc_ai\LAi_events.c; line: 3196
no rAP data
RUNTIME ERROR - file: Loc_ai\LAi_events.c; line: 3196
missed attribute: deathy
RUNTIME ERROR - file: Loc_ai\LAi_events.c; line: 3196
no rAP data
RUNTIME ERROR - file: Loc_ai\LAi_events.c; line: 3196
missed attribute: deathz
RUNTIME ERROR - file: Loc_ai\LAi_events.c; line: 3196
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: seadogs.c; line: 714
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 714
Ghost A reference
RUNTIME ERROR - file: seadogs.c; line: 714
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 714
Ghost A reference
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data
RUNTIME ERROR - file: seadogs.c; line: 714
Ghost A reference
RUNTIME ERROR - file: seadogs.c; line: 714
Ghost A reference
RUNTIME ERROR - file: seadogs.c; line: 714
Ghost A reference
RUNTIME ERROR - file: seadogs.c; line: 714
Ghost A reference
RUNTIME ERROR - file: seadogs.c; line: 714
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 714
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 714
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 714
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 725
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 725
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 725
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 725
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 725
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 725
Save - ARef to non existing attributes branch
RUNTIME ERROR - file: seadogs.c; line: 725
Save - ARef to non existing attributes branch

Haven't posted error logs in a while.. feels nice to do so again

Pieter Boelen · Sep 30, 2015

Code:

RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data

This one @Levis?

Levis · Sep 30, 2015

Pieter Boelen said:

Code:

RUNTIME ERROR - file: officers.c; line: 655
missed attribute: skills
RUNTIME ERROR - file: officers.c; line: 655
null ap
RUNTIME ERROR - file: officers.c; line: 655
no rAP data

This one @Levis?

I've seen this one before. Still looking for the cause. Doesnt seem to be gamebreaking

Pieter Boelen · Sep 30, 2015

Levis said:
I've seen this one before. Still looking for the cause. Doesnt seem to be gamebreaking

What is the related section of code where it errors out?

Levis · Sep 30, 2015

Code:

int GetEffectiveSkillByValue(ref character, string skillName, int skillPoints)
{
    // TODO: do we need to check main char or is it included in companions?
    // seems as if main char is companion 0...
    if(IsCompanion(character) || skillName == SKILL_FENCING)
    {
        return skillPoints;
    }

    if(CheckAttribute(character, "quest.officerType"))
    {
        int skillFactor;
        string officType = character.quest.officerType;
        if(CheckAttribute(OfficerTypes, officType))   <-----------------THIS LINE
            skillFactor = sti(OfficerTypes.(officType).skills.(skillName)); // KK
        else
            skillFactor = 2;

This could either be because I made a typo in one of the officertypes and typed a skill wrong. Or because a specific officertype is set which doesn't have the skills.
I need to add some debug code to figure this out.

Pieter Boelen · Sep 30, 2015

So an officer type that doesn't have skills set?
Indeed some debug lines should shed light on that one. :onya

Code:

  // TODO: do we need to check main char or is it included in companions?
  // seems as if main char is companion 0...

That is correct, the player is indeed companion 0. :yes

Levis · Sep 30, 2015

Pieter Boelen said:
So an officer type that doesn't have skills set?
Indeed some debug lines should shed light on that one.

Code:

// TODO: do we need to check main char or is it included in companions? // seems as if main char is companion 0...

That is correct, the player is indeed companion 0.

still need to clean up some of the comments in leveling and officers.
A lot of copying from other documents happened in the past

.

Levis · Oct 2, 2015

The log came because some characters where set to a "Combat" officertype. I think this is because something wasn't set and stuff wasn't removed right.
At least there is a clean for it now and also an extra check to prevent this error so you shouldn't see this anymore with these files:
Mod Release - Levis' Stuff [okt 2] | PiratesAhoy!

Pieter Boelen · Oct 2, 2015

Indeed I was seeing this one quite often during my testing yesterday.

Pieter Boelen · Oct 3, 2015

Included in here: Mod Release - Build 14 Beta 4 Internal WIP For Testing | PiratesAhoy!

Fixed Officer error log

A.H

Privateer

Pieter Boelen

Navigation Officer

Levis

Find(Rum) = false;

Pieter Boelen

Navigation Officer

Levis

Find(Rum) = false;

Pieter Boelen

Navigation Officer

Levis

Find(Rum) = false;

Levis

Find(Rum) = false;

Pieter Boelen

Navigation Officer

Pieter Boelen

Navigation Officer