Fixed Ship Sinking on Game Start

[A.H]

Just started new game as pirate.. I receive a sinking ship lol.. historically speaking that wouldn't be fictional at all considering i'm a pirate

So now I quickly went to open world to avoid my ship being sunk and somehow screen froze before I arrived @ port.. but will keep trying to make sure this isn't a repetitive thing


EDIT: yea my game now is unplayable.. not sure what the issue is.. I keep trying to land @ pirate settlement in Nevis but couldn't find it.. and I only have 1 shot to transport to sea screen before my ship start sinking, so during open map if I don't find the port spot, I reload the save file to try and find the port at another try if you get what I mean.. now either while reloading or quick saving I get the screen freeze.

Attached error file btw

 

[Levis]

which character did you pick? which storyline?

 

[A.H]

Roco braziliano.. Pirate nation.. Golden age of piracy.. Marine background.. Gaff schooner starting ship.. Adventurer difficulty.

I attached save files ZIP.. if you look @ the latest one.. it can't load.. the screen freezes before the game loads and your ship mate says "Sails ahoy" or something like that.. I hope you also witness it else you might think i'm going crazy

And new error log.. I think similar codes as previous file but a newer version.

 

[Pieter Boelen]

@Hylie Pistof, indeed I doubt code changes on our part influenced performance much.
Apart from the Shipyard Interface work @Levis did, none of the recent modding efforts have focused on performance.
Still.... If it's better than it was, it's not something complain about.

@A.H., did you use stormy start? What difficulty and realism settings are you on?
Please post also a screenshot of your exact starting settings so we'll know for sure how try and replicate your sinking ship.

 

[A.H]

Yea I used the same start shortcut as I did from the previous patch.. I already have it pinned to my start menu.. is that a possible cause?

I attached the first 3 save files also, first one is where I automatically land when starting a new game.
Difficulty Adventurer.. and realism I didn't touch that options.. only the control settings and the general gameplay settings.

In addition to this screen on open sea:

 

[Pieter Boelen]

I meant a screenshot of the Select Storyline menu showing your settings.
So you're definitely on the Build default Realistic Game Mode?
Surprising.... You strike me as the kind of player who would switch to Arcade at the earliest possible opportunity.
If you didn't do that yet, it is worth a try to do that, then start a new game.

Also worth a try to see if you get a similar problem with other characters and other storylines.

 

[A.H]

Yea I never tried arcade .. always did realistic ... at this moment of my life I can't afford experiencing the high seas in real ship.. so my best method is to experience it as close as possible on video gaming


The settings;


A tiny issue though.. as you read under "Pirate settlement - Nevis" .. I landed on Martinique.. and on every new game I start I never land in the port where it's described in the Create a character screen.. is it meant to be this way because of the storm?


I'll give it a try tomorrow to see with different characters and let you know if I run by the same issue. I will also try removing the ENGINE.exe from my start menu and replace with the one from current patch, maybe it would make a big difference. Anyhow until tomorrow; have fun.

 

[Levis]

the starting location is correct. because of stormy start this is randomized. If you for example take jean latiffe you will find it does work cause it has an other kind of start.

I have to look into it but I see you got a very "poor" ship, so maybe the stormy start does to much damage to this ship. Normally this would be programmed to give a percentual damage but I think I've seen different percentages of damage so maybe it gives a absolute amount of damage and for this ship it's to much.....
@Pieter Boelen could that be the problem?

 

[A.H]

Alrighty, started new game with exact same settings as I posted above but instead of Braziliano I took Morgan Terror.
Ship was perfect.. only had 1 crew, but 50% hull and 80% sails. (Same choice, Gaff schooner dark color)

Sailed a bit and no freeze.. but I will test sailing more to make sure that the freeze was with Rocco only.

Now I found several errors.. as you can see on file and I can confirm from gameplay even before this patch and the patch before that.. the monk that walks around.. he only spoke to me the very first time I started playing POTC.. which was 3 patches ago.
Ever since then, he opens dialog but has blank speech so he doesn't say anything.


Secondly, I tried hiring boatswain in pirate port @ Nevis.. bartender says "Oh what a coincidence....." but no boatswain character comes anywhere in the tavern, nor do I have the option of hiring one.. you can see log on file.


Other than that, I don't notice anything else odd at this time, but the log file shall explain all.. save files included for reference.

(Ps. Error file is 2nd version.. first version had double number of logs and it had at least 2 more entries other than the BArtender hire, and the monk dialog ... itwas auto deleted once I opened the game without even entering a save file.. hope in the future patches you can change the setting of auto deletion of error file to only when you enter a game and not when just opening the ENGINE file)


EDIT: new error (copy) with Ghost log.. whatever that is

 

[Pieter Boelen]

I have to look into it but I see you got a very "poor" ship, so maybe the stormy start does to much damage to this ship. Normally this would be programmed to give a percentual damage but I think I've seen different percentages of damage so maybe it gives a absolute amount of damage and for this ship it's to much.....
@Pieter Boelen could that be the problem?

Looks to be related. The chosen ships are schooner1/2 with an HP of 1250, which isn't very high.
Selecting a PIRATE character applies a modifier of 0.8 because of shipstatsmult.n3.HP = 0.80;
That leaves 1000 HP for a healthy ship. Tutorial code applies 40% ship damage, leaving 590-600 HP points.
Then stormy start does its thing:

PChar.ship.hp = GetCharacterShipHP(PChar) * rand(6)/10 +10;

This can vary between 360 and 10(!) HP points.

To make matters worse, I think this has the potential to apply to ANY ship you choose.
After all, the call to rand selects a random number between 0 and 6 but can also return 0.
So that leaves the ship HP multiplied by 0 plus 10. That's.... not so very good.

The whole section looks a bit tricky to begin with:

        PChar.ship.hp = GetCharacterShipHP(PChar) * rand(4)/10 +10;   // stormdamage to ship
         SetCrewQuantity(PChar, GetCrewQuantity(PChar) * 0 +1);   // stormdamage to crew
       } else {
         PChar.ship.hp = GetCharacterShipHP(PChar) * rand(6)/10 +10;   // stormdamage to ship
         SetCrewQuantity(PChar, GetCrewQuantity(PChar) * rand(6)/10 +1 );   // stormdamage to crew

Note how each of those lines has the potential to return a really low number.

 

[Levis]

yeah so we just need to change the rand(x) to (rand(x-2)+2) or something like that.

 

[Pieter Boelen]

My initial suggestion:

        PChar.ship.hp = GetCharacterShipHP(PChar) * (rand(4)/10+0.1);     // Storm Damage: Between 10% and 50% of previous number
         SetCrewQuantity(PChar, 1);                       // This is intentionally EVIL
       } else {
         PChar.ship.hp = GetCharacterShipHP(PChar) * (rand(6)/10+0.2);     // Storm Damage: between 20% and 80% of previous number
         SetCrewQuantity(PChar, GetCrewQuantity(PChar) * (rand(6)/10+0.2));   // Storm Damage: between 20% and 80% of previous number

I'm also not sure if we need to do this at all. Both the Standard and Free Play storylines apply some storm damage to your ship already to ensure you've got something to do during the turorial.
With this code, we're applying damage on damage.

And on that subject, if you DO play the tutorial, it makes sense to have storm damage.
But perhaps the custom starts should NOT get that damage, because they bypass the tutorial altogether.
Thoughts?

 

[Levis]

I sugest to do it like this:

PChar.ship.hp = GetCharacterShipHP(PChar) * (rand(3)+2)/10; // stormdamage to ship between 20 and 50 %
SetCrewQuantity(PChar, GetCrewQuantity(PChar) * (rand(3)+2)/10); // stormdamage to crew between 20 and 50 %
} else {
PChar.ship.hp = GetCharacterShipHP(PChar) * (rand(5)+3)/10; // stormdamage to ship between 30 and 80 %
SetCrewQuantity(PChar, GetCrewQuantity(PChar) * (rand(5)+3)/10); // stormdamage to crew between 30 and 80 %

 

[Pieter Boelen]

This it is then:

        PChar.ship.hp =  GetCharacterShipHP(PChar) * (rand(4)+1)/10;     // PB Storm Damage: Between 10% and 50% of previous number
         SetCrewQuantity(PChar, 1);                       // This is intentionally EVIL
       } else {
         PChar.ship.hp =  GetCharacterShipHP(PChar) * (rand(6)+2)/10;     // PB Storm Damage: between 20% and 80% of previous number
         SetCrewQuantity(PChar, GetCrewQuantity(PChar) * (rand(6)+2)/10);   // PB Storm Damage: between 20% and 80% of previous number

 

[A.H]

On other threads you posted twice the link to the ZIP compliation.. would this be the same as yesterday's or a more recent one updated as of today 4th July?

And if it's a more recent one, has the hiring officer issue been solved?

 

[Pieter Boelen]

On other threads you posted twice the link to the ZIP compliation.. would this be the same as yesterday's or a more recent one updated as of today 4th July?

You do realize that the last update date is IN the name of the ZIP file? Again, the answer to your question is already available to you.

And if it's a more recent one, has the hiring officer issue been solved?

I also posted about that one in the relevant thread.
If you compare the date that I posted that (just now) with the date of the ZIP file (yesterday), you can deduce that I didn't post it yet.
That's because I'm still working on things. If I would keep posting new stuff all day long, I'd have no time left to actually make new stuff.

 

[A.H]

Oh alright, just checking in.. I saw 8 thread replies.. got confused which is which

 

[Pieter Boelen]

Ship HP on Stormy Start should be much more reasonable as per the latest ZIP posted here:
http://www.piratesahoy.net/threads/build-14-beta-3-5-internal-wip-for-testing.24817