Fixed Missing chr_ai

[A.H]

Usually says the same thing always.. but it keeps repeating.
Maybe it has something to do with the shiplog because it keeps ringing a lot..
but with regards to that i will try exploring more on the shiplog issue then see if it's worth making a thread about.


And is it me or does everyone also get in fights with soldiers everytime they enter a tavern?
for me i have LOM with spain, i have a high rank with them too and good repuation.. and everytime i enter a tavern we are at a fight with the spanish soldiers inside.. and i mean EVERYTIME ... maybe they are racist against frenchies?

by fight, i mean once we enter tavern my comrades and i have red flashing on our logos upon entering the building.. and not by talking in conversation then getting in fight

 

[Levis]

for the guard problem look here:
Needs Testing - Friendly guards attacking you | Page 2 | PiratesAhoy!

Hmmm there indeed seems to be a logic fail here.

bool bDead = false;
    if (CheckAttribute(chr, "chr_ai.hp") == false) bDead = true;
    if (stf(chr.chr_ai.hp) < 1.0) bDead = true;
    //JRH -->
    if (bDead && !IsMainCharacter(chr))
    {
        if(CheckCharacterItem(chr, "blademketK"))
        {
            TakeItemFromCharacter(chr, "blademketK");
            GiveItem2Character(chr, "blade_mKnife");
            GiveItem2Character(chr, "pistolmket");
        }

        if(CheckCharacterItem(chr, "blademketB"))
        {
            TakeItemFromCharacter(chr, "blademketB");
            GiveItem2Character(chr, "pistolmketB");
        }
    }
    //<-- JRH
    return bDead;

I sugest to put the second if in an else clause

Put attached file in PROGRAM\Loc_ai

 

[Pieter Boelen]

I sugest to put the second if in an else clause

Thanks! That should work.

 

[Pieter Boelen]

This now included in here: Mod Release - Build 14 Beta 4 Internal WIP For Testing | PiratesAhoy!

It may help @Jack Rackham because it could have affected the "Blade Musket looting".

 

[Jack Rackham]

Thanks.

 

[Jack Rackham]

But Pieter I think you need some of my original code though, at least the part with the fist equip.
A gun item won't equip without an equipped blade item (first).

if(CheckCharacterItem(chr, "blademketK"))
{
RemoveCharacterEquip(chr, GUN_ITEM_TYPE);
RemoveCharacterEquip(chr, BLADE_ITEM_TYPE);
TakeItemFromCharacter(chr, "blademketK");
GiveItem2Character(chr, "blade_mKnife");
GiveItem2Character(chr, "pistolmket");
EquipCharacterByItem(chr, "blade_mKnife");
EquipCharacterByItem(chr, "pistolmket");
}
else
{
if(CheckCharacterItem(chr, "blademketB"))
{
RemoveCharacterEquip(chr, GUN_ITEM_TYPE);
RemoveCharacterEquip(chr, BLADE_ITEM_TYPE);
TakeItemFromCharacter(chr, "blademketB");
GiveItem2Character(chr, "pistolmketB");
if(!CheckCharacterItem(chr, "bladeX4")) GiveItem2Character(chr, "bladeX4");
EquipCharacterByItem(chr, "bladeX4");
EquipCharacterByItem(chr, "pistolmketB");
}
}

If you think so too the file is here. If not never mind.

 

[Pieter Boelen]

But equipping doesn't matter on a dead character, does it?
And by the time you loot, it isn't even actually a character anymore at all.

 

[Jack Rackham]

Well I thought so, but if you're sure everything's fine.

 

[Pieter Boelen]

Only way to know for sure is from testing.
And I'm not doing that now.