Fixed Attack of the Clones at Antigua

[Grey Roger]

This is what happens if you go to Antigua and talk to the port admiral, and you're hostile to England:


He has his own army of Nathaniel clones.

 

[Pieter Boelen]

Search for the "Ambush" call in his dialog file. Probably that one refers to a non-existent character model (group).

 

[Pieter Boelen]

@Grey Roger: The problem is due to this line:

Ambush("navy", 3, LAI_GROUP_ENEMY, LAI_GROUP_NEUTRAL, "");

"navy" is not an existing model ID.
It IS an existing character model GROUP though, which contains all the various navy uniforms.
However, since the function call here doesn't specify nation, I think you may get random models for ALL nations.
But only in PERIOD_COLONIAL_POWERS and later as before that navy uniforms are disabled in the game.

Probably the easiest solution:

Ambush("Soldiers", 3, LAI_GROUP_ENEMY, LAI_GROUP_NEUTRAL, "");

Would that be good enough or should we want something more special?

 

[Grey Roger]

That is exactly what I did. I was waiting until I'd tested it before reporting back. This is the result:


"Ambush" looks for a model type, e.g. "Soldiers". However, it passes through a whole succession of intermediate functions before ending up at "GetRandomModelForTypeEx", which checks if the type is actually a specific model and returns it straight back if it is. For some reason "Ambush" (and some of the intermediates) has this:

if(modeltype == "Soldiers" || modeltype == "Navy_office4" || HasSubStr(modeltype, "Soldier")) // PB: Add ANY soldiers

Why is it looking specifically for "Navy_office4"? There are other naval uniforms besides that one.

In any case, for this purpose "Soldiers" is fine. There don't seem to be any specific uniforms for marines, i.e. naval soldiers, so when the Admiral calls for the guards, they'll be basic redcoats - the guards outside the door are also "Soldiers".

 

[Pieter Boelen]

Why is it looking specifically for "Navy_office4"? There are other naval uniforms besides that one.

That's specifically for the "Merchant Guild" ambush that gets triggered if you kill an item trader.

 

[Grey Roger]

Here's "antigua_portadmiral.c" with the "Ambush" line changed to call for "Soldiers". This is the dialog file which I used for the test which produced the picture of the redcoats. It works.

 

[Pieter Boelen]

Thanks you kindly!

 

[Pieter Boelen]

Fix for this now included in here: Mod Release - Build 14 Beta 4.1 WIP | PiratesAhoy!