Fixed examine_ and equip_item_types

[Jack Rackham]

Neither examine_item_type nor equip_item_type work any longer.
(both are quest_item_type.)
The oldest game version I have left is from 12 jan and the problem is already there.
My guess is that it could have something to do with the "Toss item" button introduced?

The code for these types are in items.c, items.h & initItems.

 

[Pieter Boelen]

In what way do they not work? What are they supposed to do again? I can't remember now.

 

[Jack Rackham]

They don't have examine or equip buttons any longer. Just toss item (disabled).

 

[Pieter Boelen]

That might indeed be relatedto the Toss button. This was working in Beta 3.2, right?

 

[Jack Rackham]

It was working earlier yes - must have been in the 3.2.

 

[Pieter Boelen]

@Levis, do you have any ideas about this? Or do I need to have a look and see what's going on?

 

[Levis]

as far as I can think off this can't be related to the TOSS button, but I could take a look at it...

 

[Levis]

@Jack Rackham do you have an item for which I can test it?

 

[Pieter Boelen]

Have a look through initItems.c for EXAMINE_ITEM_TYPE . I'm a bit surprised, since isn't that used for the image-based readable books as well?

 

[Levis]

Yes but they are normal items while this is concerning quest items I believe, so probally there is a problem with how quest items are handled. I think that while disabling the tossbutton for all questitems maybe accedently the examine/equip button is also disabled for them.

 

[Jack Rackham]

Start woodesrogers (as they are questitems) and give yourself
book55A (examine item)
it should give you book55B (examine) --> book55C (equip) --> book55D (equip)

 

[Levis]

book55A is only defined in goldbug not in the woodesrogers so I can't test it on that one in there. How do I enable goldbug again cause it seems all these items are for goldbug...
For normal items it still work so if there is a problem it is for questitems only...

 

[Jack Rackham]

Sorry, yes of course it's the GoldBug. Namechange the GoldBug StartStoryline_off.c to StartStoryline.c

 

[Levis]

sorry to say but it was your own fault

  switch(id)
  {
    case "skull_ring":                qstitm.groupID        = EQUIP_ITEM_TYPE;       
                                  qstitm.skipequip    = false;                break;
    case "Montejo_Book":            qstitm.skill.Sneak    = +1;                    break;
                                  qstitm.skipequip    = false;                break;
    case "moccasins":               qstitm.groupID        = EQUIP_ITEM_TYPE;       
                                  qstitm.skipequip    = false;                break;

spot the fault here, can you see it?
Remove the break; at the 5th line, because of this it didn't process the rest of the things. so the type was never set.

 

[Jack Rackham]

Thanks for finding it Levis.
In fact it wasn't me but I have made so many mistakes so I can take one extra.

 

[Pieter Boelen]

Montejo Book? Might have been me when I set that up for Bartolomeu. That section of code has had a lot of going back-and-forth-ing lately.
Thanks for figuring it out, @Levis!