Playtest: 12.1(full)+prebuild13+21 Aug 06+ a few fixes

[LarryHookins]

Pieter, leave the actual updategroupleader function in the code, but don't call it. It should be ok to call it when a ship sinks, as that seems to be working. But don't call it from the boarding code.

Hook

 

[Black Bart]

<!--quoteo(post=169312:date=Oct 30 2006, 09:36 PM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Oct 30 2006, 09:36 PM) [snapback]169312[/snapback]</div><div class='quotemain'><!--quotec-->
If this issue occurs in Beta 5 or 6:
Hook said that the "Update Group Leader" code that he wrote doesn't work properly and should be removed from the modpack. I forgot to actually do that though. Perhaps doing that will fix something?

I will remove this code from the next beta once I get to work on that. Sorry for this; I should have removed it straight away. <img src="style_emoticons/<#EMO_DIR#>/oops3.gif" style="vertical-align:middle" emoid="ops2" border="0" alt="oops3.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->

i noticed the nations.c file that is in the beta6 is dated 14/10/06(i think, earlier than hooks update fix i have anyway) and the nations.c file that was hooks fix for the 'mass-surrender' is dated 17/10/06. It certainly seems to have an effect in game anyway in beta6 testing so far, but its early stages for me so i may see other results as i get into it further?

 

[Pieter Boelen]

To Hook: Could you please make the required code changes for the group leader update? Not sure what would happen if I'd try. Could you also please check if your mass surrender fix actually IS in Beta 6?

 

[Black Bart]

i have both versions with me and will try to attatch them here, if it doesnt work than they are slightly different from each other, if anything the 14/10/06 version of nations.c has more changes in it(towards the end of the file) than the 17/10/06 version i downloaded from the ftp. Still in the beta6 game - i was seeing slightly odd surrender behaviour, that didnt happen after applying the 17/10/06 version of nations.c

no i cant attatch the files sadly. They are different though.

 

[LarryHookins]

Pieter: Delete the call to UpdateGroupLeader() from LAi_boarding.c but leave the function in place in case someone wants to try to implement it later.

Also, comment out the line:

DeleteAttribute(&boarding_enemy,"surrendered");

from LAi_boarding.c which should fix a variety of problems. This has always been there, but new code for releasing a surrendered ship will cause problems because it expects to see that attribute some time later in the code.

These are the only two changes I know of that make any difference. The rest of the process has me overwhelmed at the moment and is why I'm taking a break from the game.

Hook

 

[Pieter Boelen]

To Black Bart: Can you put the fixed nations.c on the FTP please?

To Hook: Thanks a lot! <img src="style_emoticons/<#EMO_DIR#>/doff.gif" style="vertical-align:middle" emoid="" border="0" alt="doff.gif" />

 

[Black Bart]

<!--quoteo(post=169553:date=Nov 1 2006, 08:57 PM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Nov 1 2006, 08:57 PM) [snapback]169553[/snapback]</div><div class='quotemain'><!--quotec-->
To Black Bart: Can you put the fixed nations.c on the FTP please?

To Hook: Thanks a lot! <img src="style_emoticons/<#EMO_DIR#>/doff.gif" style="vertical-align:middle" emoid="" border="0" alt="doff.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->

doh! will the bugtracker do? i put two files there in this bugs section - the 'fixed' nations.c i got from the ftp origonaly from Hooks folder(that was the 17/10/06 file).Yeah so the two different files are on the bugtracker for people to look at <img src="style_emoticons/<#EMO_DIR#>/dunno.gif" style="vertical-align:middle" emoid="" border="0" alt="dunno.gif" />