Fixed Updating the Governor Quest Dialog

[Pieter Boelen]

DONE: Governor Ship Hunting Quest slight dialog update to add in nation description as suggested earlier by @Grey Roger

This one is done as well:

I also took the opportunity to change the text about that other sidequest to indicate it is NOT an easy one.

 

[Levis]

How does it tie in with the smuggling quest? Does that dialog still work now?

 

[Pieter Boelen]

I only changed the text, not the code.
So should work as well as it did before.

 

[Levis]

I only changed the text, not the code.
So should work as well as it did before.

I mean does the dialog still "flow".
If the smuggling quest is active it will add something to the text you showed. Hence I wondered if it still fits right now.

 

[Pieter Boelen]

I mean does the dialog still "flow".
If the smuggling quest is active it will add something to the text you showed. Hence I wondered if it still fits right now.

Should work as well as it did before. I only just added a single word in the middle.

It should be one of these options if there is a quest:

Oh yes? There are some hostiles in our waters. You could prove your loyalty to #snation# by helping with this.
Oh yes? There are some hostiles in our waters. You could prove your loyalty to #snation# by helping with this. Also I've got a problem with smugglers.
I've got a problem with smugglers.

 

[Pieter Boelen]

I've got to admit this dialog sounds somewhat silly:

Maybe that "prove your loyalty" part should be added AFTER the other quests have been mentioned?
@Levis, you can sort-of do that with the Smuggling one too, right?

 

[Levis]

I can take a look at it yes

 

[Pieter Boelen]

I can take a look at it yes

You don't need to actually DO anything there. Just want your feedback on if this would make more sense:

Oh yes? There are some hostiles in our waters. Also I've got a problem with smugglers. You could prove your loyalty to #snation# by helping with this.

I'd just make that last sentence its own line and skip it if the governor belongs to PERSONAL_NATION .
Actually, we could skip it if you are already have a LoM or are a naval officer as it may not need explaining then.

It also occurred to me: Should a Personal governor give the Smuggler Quest as well?
I think I can easily change the IsInServiceOf function to ALWAYS return true for Personal Nation.
After all, not only are you in the service of Personal Nation, technically the governor should be in YOUR service!
Just let me know if you want that too; I'm still messing around with governor stuff for now anyway.

 

[Pieter Boelen]

I split the dialog lines and swapped them around:

And also prevented that last part from showing if you're already in the service of the nation:

         if (!IsInServiceOf(iNation)) stemp = stemp + " " + DLG_TEXT[102];
         if (otherquest) dialog.text = stemp;

Plus used my suggestion of having the player ALWAYS "in the service" of his/her own nation:

bool IsInServiceOf(int iNation)
{
   ref PChar = GetMainCharacter();
   if (iNation == PERSONAL_NATION)         return true;
   if (HaveLetterOfMarque(iNation))       return true;
   if (ProfessionalNavyNation() == iNation)   return true;
   return false;
}

The above screenshot shows the MAXIMUM text you will get to see.
I admit I faked this a bit, because for personal nation you will not actually get that "You could prove your loyalty" part anymore.

Anyway, as far as I'm concerned, this is also "Fixed".

 

[Talisman]

Dialog could be worded: -

Oh yes? There are enemy ships in our waters, and then there is the never ending problem of smuggling. You could prove your loyalty to ___ by helping me deal with these.

Not sure if "enemy ships" would work if the hostiles were pirates - but this is the Governor Ship Hunting quest isn't it and they always give other countries ships to attack don't they?

 

[Grey Roger]

No, governor quests can also give you pirates to hunt. Which, if you have multiple LoM's from nations which are at war with each other and you don't want to lose one of them, is a good thing - pirates are always fair game. It's also useful if, due to variable relations, a nation finds itself at peace with all other nations; the governor quest would probably break the game if it couldn't give you a pirate target. But pirates count as "enemy ships" as well, so the dialog is still valid.

 

[Pieter Boelen]

Oh yes? There are enemy ships in our waters, and then there is the never ending problem of smuggling. You could prove your loyalty to ___ by helping me deal with these.

Annoying part is that it could be ONLY the ship hunting quest OR only the smuggling one OR both.
For proper grammar, I could change it to:

You could prove your loyalty to #sgov_nation# through your assistance.

Not sure if "enemy ships" would work if the hostiles were pirates - but this is the Governor Ship Hunting quest isn't it and they always give other countries ships to attack don't they?

Pirates are hostile to all nations, so they could be generated as enemies too.

If you want to, you'd be welcome to play around with this further and see if you can improve on the wording.
This is the relevant section from PROGRAM\DIALOGS\governor.c:

         bool otherquest = false;
         stemp = "";
         if (!CheckAttribute(pchar, "quest.generate_kill_quest") && GetNationRelation2MainCharacter(iNation) != RELATION_ENEMY)
         {
           Preprocessor_Add("gov_nation", XI_ConvertString(GetNationNameByType(iNation)));
           stemp = DLG_TEXT[14];
           link.l1 = DLG_TEXT[15];
           link.l1.go = "kill_pirate";
           otherquest = true;
         }
         //Added by Levis for the smuggler guild
         if (!CheckAttribute(pchar,"quest.smuggling_guild.governor_quest") && IsInServiceOf(iNation) && iNation != PIRATE)
         {
           if(otherquest)   stemp = stemp + DLG_TEXT[81];
           stemp = stemp + DLG_TEXT[82];
           link.l2 = DLG_TEXT[83];
           link.l2.go = "smuggler guild";
           otherquest = true;
         }
         if (!IsInServiceOf(iNation)) stemp = stemp + " " + DLG_TEXT[102];
         if (otherquest) dialog.text = stemp;

 

[Pieter Boelen]

This now included in here:
Mod Release - Build 14 Beta 4 Internal WIP For Testing | PiratesAhoy!