• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Blacksmith troubles

C

CatalinaThePirate

Unholy Terror,
Storm Modder
Alan, please check this posting out and see if you can help them!

<a href="http://forum.piratesahoy.net/sutra93274.php#93274" target="_blank">http://forum.piratesahoy.net/sutra93274.php#93274</a>

Thanks! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/onya.gif" style="vertical-align:middle" emoid=":onya" border="0" alt="onya.gif" />
 
I started a new game just to check blacksmith out.

Would have been nice to have started the "SWAK/Stormy Start " thing at the same time! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/mad.gif" style="vertical-align:middle" emoid=":c" border="0" alt="mad.gif" />

Anyway, another thing about Blacksmith, while he charges too much, he has yet to collect any charges.
 
"Yet to collect any charges"? Does he not actually take your money, you mean?

I'll look into that other problem; just glancing at it now. Black screens are often caused by a reference to a model that's not really there... I'll read it all closely now.
 
Yep, Alan, they state the fee, perform the work, but no money is removed from player.

Actually, it works out like a really neat cheat, they fix your sword for free, then you can go and sell it.
 
no no no, I can't condone that; that isn't right... why, it's... it's piracy, man!

And it's all the 'smiths doing this, not just one? I was certain they actually -took- the money.
 
Y'know, I have been meaning to mention that... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/mybad.gif" style="vertical-align:middle" emoid=":facepalm" border="0" alt="mybad.gif" />
 
Ech, it's true. I don't get it. Even RobC's original Douwesen smith (in my mod anyway; I shall have to try `re-installing` his mod alone... even though I didn't change his dialog at all) doesn't take your personal money or your crew's pot. I never noticed if he ever did to begin with; I just assumed he did.

The reason for this is absolutely beyond me. All I could figure to fix it is changing the dialog so he just charges you a flat rate, on quality, regardless of the weapon itself. "giveitemtocharacter(-money", different from the command he wrote, is bound to work. But I'll only consider myself forced to resort to this if no one else has a suggestion how to restore it. He wrote his mod well after one of the builds split money into the personal and group types, right?

And that thing about the blackscreen with the smuggler house... more code I forgot to cut, sorry. I'll fix it when I send Cat my update, but for now you just have to open the concieco.c location file, find the smuggler HQ, and delete those calls for the sword, gun and cannon models.
 
Wow, I just took a look at the Blacksmith_dialog.c files - very elegant code, written precisely... Not at all like other dialog.c files. Yyou are right about him writing this mod well after splitting the money. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />

I'm guessing these are the spots that need work (using the "excellent" example) -

<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->            // Make the player pay

   PlayerMoney -= GetBladeUpgradePrice(BladeID, GetBladeQualityByID(BladeID), QUALITY_EXELLENT);

   MainChar.money = PlayerMoney;<!--c2--></div><!--ec2-->

As far as I can tell, the code looks right, calling the correctly (AFAIK) set up references of MainChar and PlayerMoney... As you know, I am NOT some kind of coding genius, so this has to be taken into account with my musings here... I've looked into ProgramInterface files such as itemstrade.c and money.c but can't make heads or tails out of it. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" />

So I confess, I'm confused. I wish I knew what to tell you. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/sad.gif" style="vertical-align:middle" emoid=":(" border="0" alt="sad.gif" />

I will tell you this, tho - I tried to improve upon CCC's Borgia Blade in his SWAK - just out of curiosity - and found that the Blacksmith charged me "-52" for it, and took my blade! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/urgh.gif" style="vertical-align:middle" emoid=":urgh" border="0" alt="urgh.gif" /> (no biggie, I had FIVE of them, LOL!)
 
Yeah, that needs to be a disclaimer in these releases, that none of the swak weapons can be taken to a 'smith. It'd be a painful lot of work but maybe the notation of whether or not a sword can be improved should be written in its description, for those who don't already know; or a note in the swak weapons descriptions that they can't be improved.

A perhaps quicker solution but one outside my means would be for the smith to check whether an item can be improved or not, and refuse to work on a swak.
 
Maybe you can have your Smith check the blade and see that it's a SWAK and say, "Oh these are illegal, I must confiscate this for the governor!" and let it go at that... Once someone does it one time, they won't do it again! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/laugh.gif" style="vertical-align:middle" emoid="xD:" border="0" alt="laugh.gif" />
 
Getting in trouble for possessing illegal wepons might be a nice twist, I'll think about it (Now who has the sadistic ideas here <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/icon_wink.gif" style="vertical-align:middle" emoid=";)" border="0" alt="icon_wink.gif" /> )

For the time being i have a simple check for SWAK weapons :
In the dialog of the Smithee's (punalarm <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/icon_eek.gif" style="vertical-align:middle" emoid=":shock:" border="0" alt="icon_eek.gif" /> ) is a check if you have a blade:

// Blacksmith asks whether or not the current weapon should be fixed
case "SelectFix":
if (BladeID != "" )
{

There we add a second check if a repairprice can be calculated. If not, e.g. special weapons, the dialog switches to the "Can't fix such stuff" node:


// Blacksmith asks whether or not the current weapon should be fixed
case "SelectFix":
if (BladeID != "" && makeint(GetBladeUpgradePrice(BladeID, BladeQuality, QUALITY_EXELLENT)) > 0 )
{



That the payment doesn't work is another case of not matching variabletypes. The GetBladeUpgradePrice function yields a STRING, i.e. a text, and you can't calculate anything with a textvariable. It must be numeric.
makeint(GetBladeUpgradePrice converts the string into an integer value that can be deducted from the player's money:



// Make the player pay
PlayerMoney -= makeint(GetBladeUpgradePrice(BladeID, GetBladeQualityByID(BladeID), QUALITY_EXELLENT));

MainChar.money = PlayerMoney;


If you don't mind I'll put both fixes into the SWAK package, which now finally should be finished tomorrow <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />
 
<!--QuoteBegin-CouchcaptainCharles+--><div class='quotetop'>QUOTE(CouchcaptainCharles)</div><div class='quotemain'><!--QuoteEBegin-->(Now who has the sadistic ideas here <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/icon_wink.gif" style="vertical-align:middle" emoid=";)" border="0" alt="icon_wink.gif" /> )<!--QuoteEnd--></div><!--QuoteEEnd--> Ooooh, <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/piratesing.gif" style="vertical-align:middle" emoid=":shock" border="0" alt="piratesing.gif" /> ME, ME!!! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/william.gif" style="vertical-align:middle" emoid=":will" border="0" alt="william.gif" /> Can I do it next??? <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/william.gif" style="vertical-align:middle" emoid=":will" border="0" alt="william.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/whippa.gif" style="vertical-align:middle" emoid=":whipa" border="0" alt="whippa.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/laugh.gif" style="vertical-align:middle" emoid="xD:" border="0" alt="laugh.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/icon_wink.gif" style="vertical-align:middle" emoid=";)" border="0" alt="icon_wink.gif" />

As I am having some issues with getting my Sneaky Trader to do what I want him to do, I'm becoming afraid I won't be able to get him working as quickly as I'd like. (mod becoming more complicated than originally planned, LOL!) <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/urgh.gif" style="vertical-align:middle" emoid=":urgh" border="0" alt="urgh.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" /> Oh well... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/dunno.gif" style="vertical-align:middle" emoid=":shrug" border="0" alt="dunno.gif" /> Just have to keep banging away at it. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/modding.gif" style="vertical-align:middle" emoid=":modding" border="0" alt="modding.gif" />
 
This might not be a blacksmith caused problem but then again, ... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/dev.gif" style="vertical-align:middle" emoid=":d:" border="0" alt="dev.gif" /> I'll mention it here.

Has anyone recently gone beyond the waterfall?

My game has those in catacombs as skeletons and those in Oxbay canyon and behind the waterfall as pirates.

Anyway, the ones guarding Voysey's treasure don't have weapons so they just follow you around. More strange is the fact that you are not allowed to draw yours. You get the "that is not a good idea" message
 
Damn! Yes, that's my fault too... my gosh, what hath I wrought? I don't even remember all the changes I made to the game...

I dunno why they're skeletons and I hope that has nothing to do with me. And I don't know why they have no weapons... But they don't hack and slash because I was playtesting in that area and kept getting hacked and slashed, so I disabled fighting on the beach. It's just one line of code to remove, but I'll make the change in my update...

I'm surprised nobody mentioned the blacksmith shops having the wrong backgrounds... that was one problem I knew about but was too lazy to change yet.

Dora.: There is one blacksmith in B12, on the dock on Douwesen; he looks like the main character. You're best to stick with him for now. But once I have all the bugs worked out, this here is a mod to put blacksmiths in shops on most of the islands.

CCC: So, that'll fix the money problem? Good, I don't want Pietro getting away with his free swords anymore...
 
<b>Petros, </b>there is a switch in BuildSettings.h that will make the smugglers in the catacombs skellies if you wish. Check that - perhaps the skellies are enabled. You can switch them back to smugglers.

I just recently found that problem with the Voysey/waterfall quest too. (my game has the smugglers set) <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" /> So I just walked around them and got the silver treasure - and 100 gold coins to add to that as well! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/mybad.gif" style="vertical-align:middle" emoid=":facepalm" border="0" alt="mybad.gif" />

<img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" /> That locator USED to have the 4 barrel pistol. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />

<img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/mad.gif" style="vertical-align:middle" emoid=":c" border="0" alt="mad.gif" /> ALAN!!! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/laugh.gif" style="vertical-align:middle" emoid="xD:" border="0" alt="laugh.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/mybad.gif" style="vertical-align:middle" emoid=":facepalm" border="0" alt="mybad.gif" /> What are we going to do with you? <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/whippa.gif" style="vertical-align:middle" emoid=":whipa" border="0" alt="whippa.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/diomed.gif" style="vertical-align:middle" emoid=":dio" border="0" alt="diomed.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/laugh.gif" style="vertical-align:middle" emoid="xD:" border="0" alt="laugh.gif" />

This is why we don't allow EVERYONE to upload fixes to the CVS server! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/icon_wink.gif" style="vertical-align:middle" emoid=";)" border="0" alt="icon_wink.gif" />

Don't worry, you'll figure it out... Isolate everything you know impacts the blacksmith, and `re-write` the program files on a CLEAN install of the files... That should help.

I keep at least TWO copies of the PotC Program folder to separate what I'm modding - AND two installations of the game - one clean install (for "clean" testing), and the one I "mess up"... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/icon_mrgreen1.gif" style="vertical-align:middle" emoid=":cheeky" border="0" alt="icon_mrgreen1.gif" />
 
Em, yeah, if someone wants to take the defective file off the server till it's fixed... enough people have the mod I should still be getting regular error reports.

---

A lot of randitom/box locations that used to give you specific weapons don't anymore, not since the last few builds. You also don't get the `dual-barelled` pistol in that otherwise empty spot in IM anymore. The code's still there for specific items but the game overwrites that for some reason.
 
Heh... I haven't played many of the side quests for quite a while now. Just did the Artois side of that quest because I just could never get the Nigel side to work quite right.

That 100 gold coins find was rather `anti-climactic`. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/laugh.gif" style="vertical-align:middle" emoid="xD:" border="0" alt="laugh.gif" />

<img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/mybad.gif" style="vertical-align:middle" emoid=":facepalm" border="0" alt="mybad.gif" /> I should go back now and test it to see if Nigel works. He's such a pain otherwise, I keep expecting him to do something and he behaves himself! <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/laugh.gif" style="vertical-align:middle" emoid="xD:" border="0" alt="laugh.gif" /> <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/icon_wink.gif" style="vertical-align:middle" emoid=";)" border="0" alt="icon_wink.gif" />

I'll get that file off of the server, Alan. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/onya.gif" style="vertical-align:middle" emoid=":onya" border="0" alt="onya.gif" />
 
<!--`QuoteBegin-CatalinaThePirate`+--><div class='quotetop'>QUOTE(CatalinaThePirate)</div><div class='quotemain'><!--QuoteEBegin--><b>Petros, </b>there is a switch in BuildSettings.h that will make the smugglers in the catacombs skellies if you wish.  Check that - perhaps the skellies are enabled.  You can switch them back to smugglers.[/quote]

<img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/hi.gif" style="vertical-align:middle" emoid=":gday" border="0" alt="hi.gif" />
Oh no, I set that to skellies myself, I prefer it that way.

I just mentioned it in case that was somehow contributing to the problem.
 
It shouldn't contribute to the troubles... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />

I like the skellies too, kinda miss them elsewhere... <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/dunno.gif" style="vertical-align:middle" emoid=":shrug" border="0" alt="dunno.gif" /> You can enable skellies for the tailor mod, but you can't make "talking heads" because there is no separate head for the skellies. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" /> Too bad. <img src="http://www.piratesahoy.com/forum/style_emoticons/<#EMO_DIR#>/urgh.gif" style="vertical-align:middle" emoid=":urgh" border="0" alt="urgh.gif" />
 
You must log in or register to reply here.
Back
Top