NathanKell
...
Ooh, I think I get it.
Probably what they meant was for it to _not_ happen when you're doing a convoy quest (because then both the shooting and the escorted merchant paying you would happen at once).
I think what it should be written as is:
if(!checkquestattribute("generate_convoy_quest_progress", "begin") && !checkquestattribute("generate_convoy_quest_progress", "completed"))
i.e. only allow shooting of Artois if quest is not beginning/running or completing.
The problem was that the way it was written, it would return true if no convoy quest was running _only_ if you had already done at least one (and the attribute existed to be checked; checkquestattribute returns false if the attribute does not exist, even if the string to check the attribute against is "").
Probably what they meant was for it to _not_ happen when you're doing a convoy quest (because then both the shooting and the escorted merchant paying you would happen at once).
I think what it should be written as is:
if(!checkquestattribute("generate_convoy_quest_progress", "begin") && !checkquestattribute("generate_convoy_quest_progress", "completed"))
i.e. only allow shooting of Artois if quest is not beginning/running or completing.
The problem was that the way it was written, it would return true if no convoy quest was running _only_ if you had already done at least one (and the attribute existed to be checked; checkquestattribute returns false if the attribute does not exist, even if the string to check the attribute against is "").