Fixed BBF: Missing officer image

[ANSEL]

No pictures in interfaces and you cant scroll between the officers .

 

[Pieter Boelen]

Yikes, CONFIRMED!

This is a NEW problem. @Levis, do you have any thoughts here?

These officers are added to the player BEFORE being loaded into the first location:

        // First Mate
         AddPassenger(pchar, characterFromID("William Sullivan"), -1);
         LAi_SetOfficerType(characterFromID("William Sullivan"));
         // Navigator
         AddPassenger(pchar, characterFromID("David O'Hara"), -1);
         LAi_SetOfficerType(characterFromID("David O'Hara"));
         // Gunner
         AddPassenger(pchar, characterFromID("Brian Darcy"), -1);
         LAi_SetOfficerType(characterFromID("Brian Darcy"));
         // Boatswain
         AddPassenger(pchar, characterFromID("Killian Kildare"), -1);
         LAi_SetOfficerType(characterFromID("Killian Kildare"));
         // Surgeon
         AddPassenger(pchar, characterFromID("Emily Butler"), -1);
         LAi_SetOfficerType(characterFromID("Emily Butler"));
         // Carpenter
         AddPassenger(pchar, characterFromID("Uriah O'Bannon"), -1);
         LAi_SetOfficerType(characterFromID("Uriah O'Bannon"));
         // Quartermaster
         AddPassenger(pchar, characterFromID("Angus Calhoun"), -1);
         LAi_SetOfficerType(characterFromID("Angus Calhoun"));

From the Free Play StartStoryline.c .

Could it be that they aren't correctly initialized now that some initialization code has been depreciated?

There are some nasty error logs to go with it:

RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\passengers.c; line: 187
missed attribute: faceid
RUNTIME ERROR - file: interface\passengers.c; line: 187
no rAP data
RUNTIME ERROR - file: interface\passengers.c; line: 187
missed attribute: faceid
RUNTIME ERROR - file: interface\passengers.c; line: 187
no rAP data
RUNTIME ERROR - file: interface\passengers.c; line: 187
missed attribute: faceid
RUNTIME ERROR - file: interface\passengers.c; line: 187
no rAP data
RUNTIME ERROR - file: interface\passengers.c; line: 187
missed attribute: faceid
RUNTIME ERROR - file: interface\passengers.c; line: 187
no rAP data
RUNTIME ERROR - file: interface\passengers.c; line: 187
missed attribute: faceid
RUNTIME ERROR - file: interface\passengers.c; line: 187
no rAP data
RUNTIME ERROR - file: interface\passengers.c; line: 187
missed attribute: faceid
RUNTIME ERROR - file: interface\passengers.c; line: 187
no rAP data
RUNTIME ERROR - file: interface\passengers.c; line: 187
missed attribute: faceid
RUNTIME ERROR - file: interface\passengers.c; line: 187
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data
RUNTIME ERROR - file: interface\utilite.c; line: 489
missed attribute: faceid
RUNTIME ERROR - file: interface\utilite.c; line: 489
no rAP data

 

[ANSEL]

Oh dear me! It seems to bee a time with a lot of problems to handle, right now

 

[Pieter Boelen]

It is a time with a lot of things being massively changed. I'm very grateful that you're FINDING these issues!
Would be terrible if they'd slip under the radar.

That being said, I do so look forward to having a good, stable version again. It's been too long.

 

[Levis]

which options do I need to choose to get these officers?
try this file (and start a new savegame) and see if it helps.
Place in:
POTC\PROGRAM\Characters

 

[Pieter Boelen]

@Levis: I'm restoring DoCharactersPostInit() in characters_init.c as that seems to fix this problem.
Of course that means I removed the newly added SetBaseShipData call as well.

This same problem affected all the Hornblower companion ships at game start.
It may not be the best for performance, but it is only on Start New Game and if it caused these issues, who knows what other issues got caused by it as well?
Better safe than sorry for the time being, perhaps?

@ANSEL: Extract attached to PROGRAM\Characters . That seems to fix it for me.

 

[Pieter Boelen]

which options do I need to choose to get these officers?

Start New Game on the Free Play storyline; default settings.
After the talk with Robert Fletcher, check your Passengers menu. You'll notice it soon enough....

Looks like you are looking at the same code I found.
But if I understand correctly, CreateCharacter is called ONLY when characters are loaded into the location.
For these officers, they're in your Passengers list from game start, but NOT in the same location.
So I think that function may never get called for them, with all the side-effects that brings with it. Same applies to those Hornblower ones.
And who knows if any other characters are affected that normally don't get loaded in a scene with the player before the game tries to use them?

For tomorrow's release, I think I'll just use my simple approach which seems to work.
Perhaps it is better to be safe than sorry now, with all the crazy problems that have been cropping up left, right and centre lately.

 

[ANSEL]

@ANSEL: Extract attached to PROGRAM\Characters . That seems to fix it for me

Thats it! you got it. Now its working

 

[Pieter Boelen]

"Fixed" it is then!

 

[Pieter Boelen]

Old code restored as per this update: Mod Release - Build 14 Beta 4 Internal WIP For Testing | PiratesAhoy!

Seems to have fixed the problem and hopefully addresses some other undesignated weirdness too.