• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Bug Tracker registration

C

CouchcaptainCharles

COO (Chief Oddity Officer)
Storm Modder
Pirate Legend
The Bug Tracker looks like an excellent tool to orginize a common debugging effort, so I thought I'd register there and tackle some of the reports.

Did that yesterday but haven't received the necessary confirmation mail yet. Does anyone know if that is a normal delay? Or has anyone here access to the registration process?
 
Registered or not, here is a first small fix for a minor bug:

0000219: NPC who trains melee OR defense has it backwards.

Fix: two texts in the dialogtext array dialogs\english\Enc_Walker.h were swapped. Here is the fixed file:
 
Bug No. 0000238: Barracks on Cayman Islands rocking
Description: Barracks on Cayman Islands were rocking as lizard(?) that barracks are tied to moves around causing entire building to shake.


Can't confirm that. That building is motionless in my game. Though I won't rule out that a buldingcharacter might move in exceptional cases. Anyone else having that problem?
 
Please check your PMs. I hope I sorted out your Bug Tracker problem now.

Thanks a lot for that fix! It's great to have you active again! <img src="style_emoticons/<#EMO_DIR#>/w00t.gif" style="vertical-align:middle" emoid=":woot" border="0" alt="w00t.gif" />
 
Thank you. Thought I would start with some small, easy bugs to get going again. (BTW it is incredible how much has been done in the last few months. Congratulations to all who took part <img src="style_emoticons/<#EMO_DIR#>/me.gif" style="vertical-align:middle" emoid=":onya" border="0" alt="me.gif" /> )

Here's another little one:

Bug 0000228: Oxbay Relic Monk
Description: Speaking to the Monk can cause him to steal your weapons as it says in dialog, however if you apologise Dialog says he returns your weapons, however your weapons arent returned even if your on friendly terms and answer his questions correctly.

Fix: The code for returning the weapons was actually missing completely in dialogs\monk_dialog.c . This one has it and works:
 
You're able to log in now then? I have given you the "Developer" status at the Bug Tracker, which means you have more "powers" there than the bug reporters. <img src="style_emoticons/<#EMO_DIR#>/whistling.gif" style="vertical-align:middle" emoid=":wp" border="0" alt="whistling.gif" />

Some things I wonder about:
- Should the monk ever give your weapons back? Might be a fun and evil mod to make him NOT give your weapons back ever. The dialog should be changed then to reflect that, of course. <img src="style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" />
- If you hire an officer, you can take his money afterwards. Should we prevent that? It's a bit odd to "steal" from your just-hired officer. Even more so, should the officer be given the money you just paid him to become an officer? I don't think so, because then hiring officers is basically for free because you can get all that money back again.
- If you give money to a beggar, should that money actually be added to the character? If so, you can steal it back again. Should that be a possibility?
 
<!--quoteo(post=166072:date=Oct 7 2006, 12:28 PM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Oct 7 2006, 12:28 PM) [snapback]166072[/snapback]</div><div class='quotemain'><!--quotec-->
Please check your PMs. I hope I sorted out your Bug Tracker problem now.
<!--QuoteEnd--></div><!--QuoteEEnd-->
I'm in now, thanks a lot <img src="style_emoticons/<#EMO_DIR#>/smile.gif" style="vertical-align:middle" emoid=":)" border="0" alt="smile.gif" />

A procedure question: if I upload a fix there, will you find it automatically or shall I notify you? And is it correct if I set Resolution to "fixed" if I think I've got it?

I assume you'll set the STATUS to "fixed" once you have checked and compiled it ?
 
<!--quoteo(post=166119:date=Oct 7 2006, 05:35 PM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Oct 7 2006, 05:35 PM) [snapback]166119[/snapback]</div><div class='quotemain'><!--quotec-->
- Should the monk ever give your weapons back? Might be a fun and evil mod to make him NOT give your weapons back ever. The dialog should be changed then to reflect that, of course. <img src="style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->
I'd leave it that way. I fear many people will complain if the monk steals their weapons for good just because they were too rash. FAIK Scheffnow's no-save monk isn't that popular anyway, maybe it isn't clear enough that the main idea is the thrill you should get if you can't save your game.


<!--quoteo--><div class='quotetop'>QUOTE</div><div class='quotemain'><!--quotec-->
- If you hire an officer, you can take his money afterwards. Should we prevent that? It's a bit odd to "steal" from your just-hired officer. Even more so, should the officer be given the money you just paid him to become an officer? I don't think so, because then hiring officers is basically for free because you can get all that money back again.
<!--QuoteEnd--></div><!--QuoteEEnd-->
Yes, I always found it a cheat that you can take back the money you just paid him. (Can't resist the temptation nevertheless <img src="style_emoticons/<#EMO_DIR#>/whistling.gif" style="vertical-align:middle" emoid=":wp" border="0" alt="whistling.gif" /> ) As you said, an easy fix would be if the hiring sum would NOT go into the pocket of the officer.

<!--quoteo--><div class='quotetop'>QUOTE</div><div class='quotemain'><!--quotec-->
- If you give money to a beggar, should that money actually be added to the character? If so, you can steal it back again. Should that be a possibility?
<!--QuoteEnd--></div><!--QuoteEEnd-->
IMHO yes. After all there is a risk in stealing, so you deserve a reward. That's only fair... sort of <img src="style_emoticons/<#EMO_DIR#>/icon_mrgreen1.gif" style="vertical-align:middle" emoid=":cheeky" border="0" alt="icon_mrgreen1.gif" />

Only my opinions, don't insist on them. Don't mind if you leave things as they are.
 
<!--quoteo(post=166133:date=Oct 7 2006, 12:15 PM:name=CouchcaptainCharles)--><div class='quotetop'>QUOTE(CouchcaptainCharles @ Oct 7 2006, 12:15 PM) [snapback]166133[/snapback]</div><div class='quotemain'><!--quotec-->
<!--quoteo(post=166119:date=Oct 7 2006, 05:35 PM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Oct 7 2006, 05:35 PM) [snapback]166119[/snapback]</div><div class='quotemain'><!--quotec-->
- If you hire an officer, you can take his money afterwards. Should we prevent that? It's a bit odd to "steal" from your just-hired officer. Even more so, should the officer be given the money you just paid him to become an officer? I don't think so, because then hiring officers is basically for free because you can get all that money back again.
<!--QuoteEnd--></div><!--QuoteEEnd-->
Yes, I always found it a cheat that you can take back the money you just paid him. (Can't resist the temptation nevertheless <img src="style_emoticons/<#EMO_DIR#>/whistling.gif" style="vertical-align:middle" emoid=":wp" border="0" alt="whistling.gif" /> ) As you said, an easy fix would be if the hiring sum would NOT go into the pocket of the officer.

<!--QuoteEnd--></div><!--QuoteEEnd-->
<img src="style_emoticons/<#EMO_DIR#>/hi.gif" style="vertical-align:middle" emoid=":gday" border="0" alt="hi.gif" /> CCC and welcome back! <img src="style_emoticons/<#EMO_DIR#>/monkeydance.gif" style="vertical-align:middle" emoid=":mi" border="0" alt="monkeydance.gif" />
Strange, I've always found that officers you hire never had more money than what the character/abilities screen showed prior to you hiring them.

If they had 1000, and you paid them 3000, they still only had 1000 for you to take once they were officers.
 
Oh, quite possible, I never checked THAT <img src="style_emoticons/<#EMO_DIR#>/whistling.gif" style="vertical-align:middle" emoid=":wp" border="0" alt="whistling.gif" /> Simply assumed it is their headmoney.

Thanks for the correction <img src="style_emoticons/<#EMO_DIR#>/doff.gif" style="vertical-align:middle" emoid=":doff" border="0" alt="doff.gif" />

So one would have to set their money to 0 upon generation. IF it is worth the effort, though...
 
<!--quoteo(post=166125:date=Oct 7 2006, 06:00 PM:name=CouchcaptainCharles)--><div class='quotetop'>QUOTE(CouchcaptainCharles @ Oct 7 2006, 06:00 PM) [snapback]166125[/snapback]</div><div class='quotemain'><!--quotec-->
A procedure question: if I upload a fix there, will you find it automatically or shall I notify you? And is it correct if I set Resolution to "fixed" if I think I've got it?
<!--QuoteEnd--></div><!--QuoteEEnd-->
Yes to both questions. If the problem wasn't fixed after all, we can always reopen the issue. <img src="style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />

<!--quoteo(post=166133:date=Oct 7 2006, 06:15 PM:name=CouchcaptainCharles)--><div class='quotetop'>QUOTE(CouchcaptainCharles @ Oct 7 2006, 06:15 PM) [snapback]166133[/snapback]</div><div class='quotemain'><!--quotec-->
I'd leave it that way. I fear many people will complain if the monk steals their weapons for good just because they were too rash. FAIK Scheffnow's no-save monk isn't that popular anyway, maybe it isn't clear enough that the main idea is the thrill you should get if you can't save your game.
<!--QuoteEnd--></div><!--QuoteEEnd-->
Very well then. <img src="style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />

<!--quoteo(post=166133:date=Oct 7 2006, 06:15 PM:name=CouchcaptainCharles)--><div class='quotetop'>QUOTE(CouchcaptainCharles @ Oct 7 2006, 06:15 PM) [snapback]166133[/snapback]</div><div class='quotemain'><!--quotec-->
Yes, I always found it a cheat that you can take back the money you just paid him. (Can't resist the temptation nevertheless <img src="style_emoticons/<#EMO_DIR#>/whistling.gif" style="vertical-align:middle" emoid=":wp" border="0" alt="whistling.gif" /> ) As you said, an easy fix would be if the hiring sum would NOT go into the pocket of the officer.
<!--QuoteEnd--></div><!--QuoteEEnd-->
I was thinking of setting NPChar.money = 0; in the dialog after hiring him. The we can be sure you won't actually MAKE money from hiring an officer. I hired an officer for 200 gold and he had 1000 gold with him, so I actually MADE money from hiring him.

I wonder if we could give officers <i>wealth</i> as well. This wealth can not be "stolen" by the player,b ut each time you pay your officer, his wealth increases. And it decreases again when in towns, because of the officer buying rum. But sometimes an officer might save his money and if the officer has a lot of personal wealth, he might leave your service and get his own ship. This would be an idea for Build 14 though.

<!--quoteo(post=166133:date=Oct 7 2006, 06:15 PM:name=CouchcaptainCharles)--><div class='quotetop'>QUOTE(CouchcaptainCharles @ Oct 7 2006, 06:15 PM) [snapback]166133[/snapback]</div><div class='quotemain'><!--quotec-->
IMHO yes. After all there is a risk in stealing, so you deserve a reward. That's only fair... sort of <img src="style_emoticons/<#EMO_DIR#>/icon_mrgreen1.gif" style="vertical-align:middle" emoid=":cheeky" border="0" alt="icon_mrgreen1.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->
*Agrees* <img src="style_emoticons/<#EMO_DIR#>/doff.gif" style="vertical-align:middle" emoid=":doff" border="0" alt="doff.gif" />

<!--quoteo(post=166138:date=Oct 7 2006, 06:36 PM:name=Petros)--><div class='quotetop'>QUOTE(Petros @ Oct 7 2006, 06:36 PM) [snapback]166138[/snapback]</div><div class='quotemain'><!--quotec-->
Strange, I've always found that officers you hire never had more money than what the character/abilities screen showed prior to you hiring them.
If they had 1000, and you paid them 3000, they still only had 1000 for you to take once they were officers.
<!--QuoteEnd--></div><!--QuoteEEnd-->
That is indeed the way how it currently works. But Maximus added a line of code that will give the officer the hiring sum and I was wondering if that line of code should be added. I think not.
 
I like the idea of putting it in the officer's wealth. Should be an easy fix. Any money you give the officer in the exchange screen should be available for you to take back later, but officer pay should belong to the officer.

Hook
 
Indeed. If you could make that change, please do. At the moment the only money that should be officer's wealth is the hiring fee, the salary and the money the officer has before hiring. In Build 14 we can extend that and make the officer actually do things with his money.
 
The officer gets a fair chunk of change when you divide the loot, too.

Currently what shows up as officer wealth is the amount of money he has on him. I think I can fix it so he gets to keep that, but can still carry gold around for you.

Hook
 
That would be excellent! <img src="style_emoticons/<#EMO_DIR#>/w00t.gif" style="vertical-align:middle" emoid=":woot" border="0" alt="w00t.gif" />
 
hmm yeah cool - so money would work for Officers like it does for the player? a personal stash and a poolable amount - access to the poolable amount by the Captain(player) but once its in the personal stash its untouchable? what would happen when they die? And what rules would govern money going from poolable to personal, or do we just keep it simple and seperate(one for Officer wages/one for carrying gold around for you)?
 
I think we should keep it simple for the time being. It can always be extended and improved, but it's best to start simple. <img src="style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />
 
<!--quoteo(post=166133:date=Oct 7 2006, 11:15 AM:name=CouchcaptainCharles)--><div class='quotetop'>QUOTE(CouchcaptainCharles @ Oct 7 2006, 11:15 AM) [snapback]166133[/snapback]</div><div class='quotemain'><!--quotec-->
<!--quoteo(post=166119:date=Oct 7 2006, 05:35 PM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Oct 7 2006, 05:35 PM) [snapback]166119[/snapback]</div><div class='quotemain'><!--quotec-->
- Should the monk ever give your weapons back? Might be a fun and evil mod to make him NOT give your weapons back ever. The dialog should be changed then to reflect that, of course. <img src="style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->
I'd leave it that way. I fear many people will complain if the monk steals their weapons for good just because they were too rash. FAIK Scheffnow's no-save monk isn't that popular anyway, maybe it isn't clear enough that the main idea is the thrill you should get if you can't save your game. <!--QuoteEnd--></div><!--QuoteEEnd-->
HArr! Having yer weapons taken by de monk be de key tew Fred Bob's Infamous Quaker Exploit! <img src="style_emoticons/<#EMO_DIR#>/laugh.gif" style="vertical-align:middle" emoid="xD:" border="0" alt="laugh.gif" /> Once ye loose yer weapons, none o' de game's original NPC's will attack ye at all! <img src="style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" /> Ye kin stroll through de catacombs an' Inca temple widout gittin' bothered at all by pesky mummies, skellies, or bandits! <img src="style_emoticons/<#EMO_DIR#>/icon_mrgreen1.gif" style="vertical-align:middle" emoid=":cheeky" border="0" alt="icon_mrgreen1.gif" /> Boardin' wid yer officers be funny cause nobody e'er attacks ye, so's ye kin plunder yer enemies treasure whilst yer crew be fightin'! Only exception be CCC's Vice City-type NPC's, which will still be attackin' ye even widout yer weapons! <img src="style_emoticons/<#EMO_DIR#>/mybad.gif" style="vertical-align:middle" emoid=":facepalm" border="0" alt="mybad.gif" />
 
AH! A CHEAT! That must be prevented. <img src="style_emoticons/<#EMO_DIR#>/dev.gif" style="vertical-align:middle" emoid=":d:" border="0" alt="dev.gif" />
Thanks for notifying me of that issue, Fred Bob. I am going to make it so that when your weapons are stolen, you equip your fists automatically. That way you won't ever end up with no weapons. <img src="style_emoticons/<#EMO_DIR#>/whippa.gif" style="vertical-align:middle" emoid=":whipa" border="0" alt="whippa.gif" />
 
pacisfism has no place in PotC? <img src="style_emoticons/<#EMO_DIR#>/sad.gif" style="vertical-align:middle" emoid=":(" border="0" alt="sad.gif" />

<img src="style_emoticons/<#EMO_DIR#>/wink.gif" style="vertical-align:middle" emoid=";)" border="0" alt="wink.gif" />
 
You must log in or register to reply here.
Back
Top