• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Governors Ships Quest fixed

K

kblack

Landlubber
Storm Modder
Hi all.

Don't know if someone has fixed it already, so my apologies in advance....



When you get "kill ships" missions from Governors, the target ships appeared with a white flag.
When it surrenders, you can't board it.
Also you get a tremendous drop in your reputation
Also, if you board it (before surrender) you get a nice empty deck, and you have to reload as there is no way to get out.


I have found the reason:

In quests_reaction.c
In GeneratePirateQuest

The call ref rFantom = characterFromID("Quest pirate") returns an incorrect value for rFantom.nation (returns 7 --> no one)

So the pirate ship HAS NOT nation... so nothing works.

Solved with this code

if (rFantom.nation > 5 ) {rFantom.nation = "3";} just below the call to characterfromId


Now everything works.

Regards.

Kblack
 
<img src="style_emoticons/<#EMO_DIR#>/hi.gif" style="vertical-align:middle" emoid=":gday" border="0" alt="hi.gif" />
kblack very good thanks thousand times <img src="style_emoticons/<#EMO_DIR#>/bow.gif" style="vertical-align:middle" emoid=":bow" border="0" alt="bow.gif" /> <img src="style_emoticons/<#EMO_DIR#>/bow.gif" style="vertical-align:middle" emoid=":bow" border="0" alt="bow.gif" /> <img src="style_emoticons/<#EMO_DIR#>/bow.gif" style="vertical-align:middle" emoid=":bow" border="0" alt="bow.gif" /> <img src="style_emoticons/<#EMO_DIR#>/doff.gif" style="vertical-align:middle" emoid=":doff" border="0" alt="doff.gif" /> <img src="style_emoticons/<#EMO_DIR#>/laugh.gif" style="vertical-align:middle" emoid="xD:" border="0" alt="laugh.gif" />
Bye CapHawk <img src="style_emoticons/<#EMO_DIR#>/buds.gif" style="vertical-align:middle" emoid=":drunk" border="0" alt="buds.gif" /> <img src="style_emoticons/<#EMO_DIR#>/buds.gif" style="vertical-align:middle" emoid=":drunk" border="0" alt="buds.gif" /> <img src="style_emoticons/<#EMO_DIR#>/me.gif" style="vertical-align:middle" emoid=":onya" border="0" alt="me.gif" /> <img src="style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" /> <img src="style_emoticons/<#EMO_DIR#>/w00t.gif" style="vertical-align:middle" emoid=":woot" border="0" alt="w00t.gif" /> <img src="style_emoticons/<#EMO_DIR#>/par-ty.gif" style="vertical-align:middle" emoid=":cheers" border="0" alt="par-ty.gif" /> <img src="style_emoticons/<#EMO_DIR#>/icon_mrgreen1.gif" style="vertical-align:middle" emoid=":cheeky" border="0" alt="icon_mrgreen1.gif" />
 
Thank you very much. <img src="style_emoticons/<#EMO_DIR#>/doff.gif" style="vertical-align:middle" emoid=":doff" border="0" alt="doff.gif" />
Why aren't all pirates generated as nation pirate anyway? Why is it returning 7 in the first place??? <img src="style_emoticons/<#EMO_DIR#>/piratesing.gif" style="vertical-align:middle" emoid=":shock" border="0" alt="piratesing.gif" />
 
<!--quoteo(post=142659:date=Mar 20 2006, 08:09 PM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Mar 20 2006, 08:09 PM) [snapback]142659[/snapback]</div><div class='quotemain'><!--quotec-->
Thank you very much. <img src="style_emoticons/<#EMO_DIR#>/doff.gif" style="vertical-align:middle" emoid=":doff" border="0" alt="doff.gif" />
Why aren't all pirates generated as nation pirate anyway? Why is it returning 7 in the first place??? <img src="style_emoticons/<#EMO_DIR#>/piratesing.gif" style="vertical-align:middle" emoid=":shock" border="0" alt="piratesing.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->

Well, it's supposed that a Gov can quest you to sink an enemy ship (as the Spanish Gov asking me to sunk a Netherlands Corvette)

OTOH, I haven't any idea why is it returning 7... mainly because at the end is being called an internal function.

Who knows? Who cares? If it works, don't fix it :)
 
Can the governor order you to sink ships from other nations? Maybe that is an unfinished feature, because I don't ever recall you to have to sink anything but pirate ships. <img src="style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
 
<!--quoteo(post=142738:date=Mar 21 2006, 10:05 AM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Mar 21 2006, 10:05 AM) [snapback]142738[/snapback]</div><div class='quotemain'><!--quotec-->
Can the governor order you to sink ships from other nations? Maybe that is an unfinished feature, because I don't ever recall you to have to sink anything but pirate ships. <img src="style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->

I will confirm you this tomorrow morning...

...yesterday I finished to play POTC when the Governor of Isla Muelle ordered to sink the "Prince Louie" ship...

and ,IIRC , earlier, just before docking at Isla Muelle, I saw a couple of enemy Netherlanden ships: a Frigate called Prince something, and a Brigantine, Corvette or Pinnace called Prince Louie....

Also, IIRC, in stock POCT I am almost completely sure to have had to sink French warships in one mission.

More news soon.... ;-)
 
This entire functionality was not in the stock game at all... <img src="style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
The function itself is named GeneratePirateQuest, which suggests that it is supposed to generate only pirates. <img src="style_emoticons/<#EMO_DIR#>/dunno.gif" style="vertical-align:middle" emoid=":shrug" border="0" alt="dunno.gif" />
 
Hey, this'll be great if this bug is finally fixed for good.

Well done, in anticipation.

Cheers <img src="style_emoticons/<#EMO_DIR#>/par-ty.gif" style="vertical-align:middle" emoid=":cheers" border="0" alt="par-ty.gif" />
 
<!--quoteo(post=142787:date=Mar 21 2006, 04:15 PM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Mar 21 2006, 04:15 PM) [snapback]142787[/snapback]</div><div class='quotemain'><!--quotec-->
This entire functionality was not in the stock game at all... <img src="style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />
The function itself is named GeneratePirateQuest, which suggests that it is supposed to generate only pirates. <img src="style_emoticons/<#EMO_DIR#>/dunno.gif" style="vertical-align:middle" emoid=":shrug" border="0" alt="dunno.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->


Well, you're right.... I had to sink a pirate ship called "Princesse Loiuse"... and there was also a couple of Netherlanden raiders one of them called "Prinses louise"...

definitely, my mistake was understandable ;-)

Anyhow, touching the code seems feasible to have quest no only to catch pirates but also raiders... we will see... in the next build ;-)

See you

BTW do you suggest a bug specifically to go to catch? Plz remember I'm not a modder, so I prefer sailing related ones.
 
Thanks a great lot for fixing that old nagging bug <img src="style_emoticons/<#EMO_DIR#>/me.gif" style="vertical-align:middle" emoid=":onya" border="0" alt="me.gif" />
That the lack of a nation is the problem explains that some "BOARDERMODEL" model selections worked and some not. E.g. "standard" looks for the nation, while "corsair" selects a characterskin regardless of the country.

While you are at it <img src="style_emoticons/<#EMO_DIR#>/icon_wink.gif" style="vertical-align:middle" emoid=";)" border="0" alt="icon_wink.gif" /> some people have reported that after a certain amount of missions the governor quests don't work anymore (though I can't remember the details )
 
<!--quoteo(post=142952:date=Mar 23 2006, 10:49 AM:name=CouchcaptainCharles)--><div class='quotetop'>QUOTE(CouchcaptainCharles @ Mar 23 2006, 10:49 AM) [snapback]142952[/snapback]</div><div class='quotemain'><!--quotec-->
Thanks a great lot for fixing that old nagging bug <img src="style_emoticons/<#EMO_DIR#>/me.gif" style="vertical-align:middle" emoid=":onya" border="0" alt="me.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->

"No las merece" ! anyway, it's funny to help :)

<!--quoteo(post=142952:date=Mar 23 2006, 10:49 AM:name=CouchcaptainCharles)--><div class='quotetop'>QUOTE(CouchcaptainCharles @ Mar 23 2006, 10:49 AM) [snapback]142952[/snapback]</div><div class='quotemain'><!--quotec-->
That the lack of a nation is the problem explains that some "BOARDERMODEL" model selections worked and some not. E.g. "standard" looks for the nation, while "corsair" selects a characterskin regardless of the country.
<!--QuoteEnd--></div><!--QuoteEEnd-->

Yes.

<!--quoteo(post=142952:date=Mar 23 2006, 10:49 AM:name=CouchcaptainCharles)--><div class='quotetop'>QUOTE(CouchcaptainCharles @ Mar 23 2006, 10:49 AM) [snapback]142952[/snapback]</div><div class='quotemain'><!--quotec-->
While you are at it <img src="style_emoticons/<#EMO_DIR#>/icon_wink.gif" style="vertical-align:middle" emoid=";)" border="0" alt="icon_wink.gif" /> some people have reported that after a certain amount of missions the governor quests don't work anymore (though I can't remember the details )
<!--QuoteEnd--></div><!--QuoteEEnd-->

Well, as I like a lot to do governor quest, sooner or later I will find that, and, if it's a bug, it will be catched <img src="style_emoticons/<#EMO_DIR#>/keith.gif" style="vertical-align:middle" emoid=":keith" border="0" alt="keith.gif" /> and eliminated <img src="style_emoticons/<#EMO_DIR#>/danse1.gif" style="vertical-align:middle" emoid=":dance" border="0" alt="danse1.gif" />
 
<!--quoteo(post=142997:date=Mar 23 2006, 03:14 PM:name=kblack)--><div class='quotetop'>QUOTE(kblack @ Mar 23 2006, 03:14 PM) [snapback]142997[/snapback]</div><div class='quotemain'><!--quotec-->
Well, as I like a lot to do governor quest, sooner or later I will find that, and, if it's a bug, it will be catched <img src="style_emoticons/<#EMO_DIR#>/keith.gif" style="vertical-align:middle" emoid=":keith" border="0" alt="keith.gif" /> and eliminated <img src="style_emoticons/<#EMO_DIR#>/danse1.gif" style="vertical-align:middle" emoid=":dance" border="0" alt="danse1.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->
THAT'S THE SPIRIT! <img src="style_emoticons/<#EMO_DIR#>/bow.gif" style="vertical-align:middle" emoid=":bow" border="0" alt="bow.gif" />
 
You must log in or register to reply here.
Back
Top