Fixed Jack Sparrow - Dialog #sFather# for Priests Name not working

[Talisman]

Talking to the Priests in Bridgetown while doing Ammand - Help the Church Side Quest

Ballister has priests name in dialog OK - as it is in .h file as text

"I'd like to ask you some questions about the priest named ",
"Father Jerald",

But Father Jerald - has #sFather# in his .h file and the Priests name does not appear. Yet sometimes it does .

"I'm only too happy to welcome a new member to the congregation. I'm ",
". ",
"Wonderful, then I hope you'll accept my gift to the Church.",
"Can I talk with you, #sFather#?",

"But I've never seen these before.",
"They're in your handwriting, #sFather#. And they show the full picture of your degradation.",

"I swear to you I wrote no such letters! But dear God, who will believe me when they see these?!",
"Hmm. You're either a very good actor, #sFather#, or you really didn't write these letters. I'm glad it's not up to me to make that decision.",
"Don't despair, #sFather#. I can see now you're telling the truth. There's still hope.",

No error log generated

 

[Pieter Boelen]

Extract attached files to PROGRAM\Storyline\JackSparrow\dialogs and see if that helps.

 

[Talisman]

Yes - That Worked

 

[Pieter Boelen]

Then the problem is that the most recent updates weren't applied to the Jack Sparrow storyline folder.
I've been afraid of issues like that and that was one of the reasons I have tried to reduce the amount of double code in the game.
But not enough, because there is still lots and lots of that left, which may cause similar problems like this.

I know that both @Grey Roger and @pedrwyth made some updates to sidequests, including the Church Help/Animists one.
If at all possible, I would hope they could compare their work with the Jack Sparrow storyline and make sure that their fixes are applied there too.

But in the meantime, at least this one should be fixed then!

 

[pedrwyth]

I know that both @Grey Roger and @pedrwyth made some updates to sidequests, including the Church Help/Animists one.
If at all possible, I would hope they could compare their work with the Jack Sparrow storyline and make sure that their fixes are applied there too.

No simple answer to that one.

The animist code changes by me in the standard storyline (now in quests_side.c) are not in Jack Sparrow (in both_reaction.c) but never having played Jack Sparrow I wonder if they even need to be! The standard story fix was for where you had earlier killed the prison warden (when searching for the idol collection for Silehard) which may well not occur in Jack Sparrow since you are not following Nathaniel Hawke plot line?

The more recent fix for boarding crashes as it affects the animists ships also already has a different code solution in JS based on the health points of the ships (EDIT - HP or is that hit points) not the death of the captains and the block against boarding seems to be already commented out - which I presume works too?

There is also different code in JS which looks like another improvement. In the standard storyline in "with _teacher_to_muelle" (and ....muelle_21) the reload for on-ship dialogue with Teacher takes place to denielle_deck which seems to be a generic onboard location for side quests. In JS as I read the code this has been changed to put you on the correct PChar ship deck which is presumably a better scenario.

It looks like it may need close comparison by someone who knows how both behave so that a best of both worlds can emerge.

For now I would leave JS as is in regard to my standard storyline changes - because it may not be broke in the same way - unless someone who knows JS tells me you can meet the dead warden impasse BUT I would bring the JS improvement from using denielle_deck into the quests_side.c code (assuming it works as it reads).

 

[Pieter Boelen]

No simple answer to that one.

The animist code changes by me in the standard storyline (now in quests_side.c) are not in Jack Sparrow (in both_reaction.c) but never having played Jack Sparrow I wonder if they even need to be! The standard story fix was for where you had earlier killed the prison warden (when searching for the idol collection for Silehard) which may well not occur in Jack Sparrow since you are not following Nathaniel Hawke plot line?

The more recent fix for boarding crashes as it affects the animists ships also already has a different code solution in JS based on the health points of the ships (EDIT - HP or is that hit points) not the death of the captains and the block against boarding seems to be already commented out - which I presume works too?

There is also different code in JS which looks like another improvement. In the standard storyline in "with _teacher_to_muelle" (and ....muelle_21) the reload for on-ship dialogue with Teacher takes place to denielle_deck which seems to be a generic onboard location for side quests. In JS as I read the code this has been changed to put you on the correct PChar ship deck which is presumably a better scenario.

It looks like it may need close comparison by someone who knows how both behave so that a best of both worlds can emerge.

For now I would leave JS as is in regard to my standard storyline changes - because it may not be broke in the same way - unless someone who knows JS tells me you can meet the dead warden impasse BUT I would bring the JS improvement from using denielle_deck into the quests_side.c code (assuming it works as it reads).

Thanks for checking this. Maybe @Talisman can confirm based on that if indeed any of your changes are needed.
If not, I'll leave it as-is until somebody says otherwise.