One of the conditions defined in "quests_check.c" is "relation". This activates if your relation with a given nation changes to a given status - "Friendly", "Hostile" or "Neutral".
As far as I know, at present I'm the only one using this check. Lucia and Edmundo de la Vega, being daughter and son of a Spanish governor, are patriotic and will only accept your hand in marriage or a post as officer on your ship if you are at peace with Spain. If, having married or hired them, you then turn hostile to Spain, they regard this as a personal betrayal and leave you.
But that condition check uses 'GetNationRelation2Character' to determine your relation to the nation. After some checking, this ends up calling 'GetFlagRMRelation'. So Lucia and Edmundo feel betrayed if you hoist a false enemy flag.
Any objection to changing the check to use 'GetRMRelation' and 'GetRMRelationType' instead, so it looks at your genuine relation to the nation, not your flag's relation?
As far as I know, at present I'm the only one using this check. Lucia and Edmundo de la Vega, being daughter and son of a Spanish governor, are patriotic and will only accept your hand in marriage or a post as officer on your ship if you are at peace with Spain. If, having married or hired them, you then turn hostile to Spain, they regard this as a personal betrayal and leave you.
But that condition check uses 'GetNationRelation2Character' to determine your relation to the nation. After some checking, this ends up calling 'GetFlagRMRelation'. So Lucia and Edmundo feel betrayed if you hoist a false enemy flag.
Any objection to changing the check to use 'GetRMRelation' and 'GetRMRelationType' instead, so it looks at your genuine relation to the nation, not your flag's relation?