Fixed Selling cannons first gives more money

[Levis]

If you sell your cannons first and then sell the ship you get more value out of the ship

Can someone confirm this? If so this shouldn't happen

 

[Levis]

Can someone test this for some ships and let me know?

 

[ANSEL]

Sales price for ship with cannons: 177,788. After removing cannons:192,548.

 

[Pieter Boelen]

Wha? The actual sale prices goes up after selling the cannons???
That really makes zero sense.

 

[DavyJack]

Tested it with the latest version.
Ship price WITH cannons:
After selling them cannons,
Ship price with NO cannons:

@ContraProductive is right.
*No error.log generated.

 

[Pieter Boelen]

 

[Levis]

I guess there is a - or + somewhere inverted. will look at this later .

 

[Levis]

Looking at the code but some weird things happen and I need to sleep now too.
Could someone maybe test the following for me:

Try selling a ship with cargo
and selling the cargo first at the shop and then sell the ship
and see what difference this makes
My guess is it has the same problem as the canons

 

[DavyJack]

Ship price with cargo:
After selling or discarding cargo:
Ship price with no cargo: (selling) (discarding)

*Not the same problem with the cannons.

 

[Levis]

https://www.dropbox.com/s/hy6zz8hn28m409d/shipyard.c?dl=0

please try this file (had to upload it like this cause the network I'm on blocks uploading to this site). place it in PROGRAM/INTERFACE
let me know if this fixes the problem or even works at all cause I couldn't test it here.

@DavyJack you probally have a savegame there which you can use to test this really quick .

 

[ANSEL]

Still the same problem

 

[ANSEL]

Could it be in this file the problem hides.The more expensive cannons I install , the cheaper the
sale price will be. Also I can only confirm the sale transaction with the buy button?
I have chanced the attached file to: Program/Interface/cannons

 

[ANSEL]

I have chanced the attached file to PROGRAM/INTERFACE/cannons.

 

[Levis]

What did you change in the file?
I cant really imagine the problem being in that file....

 

[ANSEL]

I haven`t chanced anything, I just want you to have a look into it. There is a lot of stuff about selling
and buying cannons in that file.

 

[Red Back Dude]

"
Selling cannons first gives more money
_______________________________________________"

Because Cannons with experience , a degree from university and years of hands on work experience are worth ALOT more money.



Exchanging the cannons for new work experience scrub cannons is like selling to a pawn shop , you're gonna get screwed.

 

[Levis]

Fixes:
- When selling cannons ship price changes accordingly
- Buy price of a ship is now shown correcly in the interface, so the sellprice is already substracted.
- Bug in cannons.c which could cause some errors at some ports

 

[ANSEL]

Works fine ! .