Fixed Shipyard Exploit: Repeated Upgrades

[Grey Roger]

Originally reported in Buggy Mess:
When you sell a ship which has upgrades, the upgrades are lost but the upgraded stats remain. You can then buy the ship again; apply the upgrades again to get the stats further improved; sell it again; buy it again; upgrade it again; repeat until the ship is as maxed out as you like, you're broke, or you're bored.

In my case it was the last condition. Money is not an issue, I've got 60 million gold. So I started with a captured frigate whose Turn rating was 78, sold it, bought it, bought the "Long Masts", "Cotton Sails" and "Stays" upgrades, sold it, bought it, bought the upgrades, and repeated this several times. There's only a small increase to the speed and turn stats with each cycle, but they mounted up and I eventually quit when Turn was up to 85. I can't remember what Speed was but it had certainly gone up.

 

[Levis]

- I sold a Pinnace with many goods in the cargo, and bought a Merchant Pinnace. When I wanted to buy the Pinnace again, I saw that the sell price of the Merchant Pinnace was higher than its buy price, because the goods of the Pinnace were transfered in the Merchant Pinnace instead of being sold with the ship. So I can sell my Merchant Pinnace again, buy the Pinnace, and gain money infinitely.

Could someone confirm if this is solved in 3.5 already?
This might be an issue with just this one ship need to look into it later when I have time.

 

[Pieter Boelen]

I don't know if that report was made with or without the "No Lag Band-Aid" posted here: http://www.piratesahoy.net/threads/modpack-performance-issues.24859/
That one doesn't include your shipyard fixes and would explain why this could still happen after your work on that.

I wouldn't worry about this one unless it is reported again with the next Beta 3.5 WIP that I'll release later this week.

 

[Levis]

Added another post (first post) which is also about the shipyard

 

[Pieter Boelen]

Added another post (first post) which is also about the shipyard

I thought there was already a Bug Tracker entry for that one, but I can't seem to find it now.
That one is indeed Confirmed.

 

[Levis]

Put in:
PROGRAM\INTERFACE

This should fix the problem. While I was at it if you sell a ship with upgrades this will be remembered and you will still see them and if you buy the ship again it still has the upgrades.
Also made the buy price a bit dependable on the commerce skill and the sell price also.