USEMAXPOTION_ONKEYPRESS's definition counterintuitive

[MrMister]

#define USEMAXPOTION_ONKEYPRESS in InternalSettings.h, which defaults to 0, has the explanation "BOOL - If pressing the use potion key, the SMALLEST potions will be used first."

I assume that that the "if enabled" is implicit in the explanation, and so what I get from this is that enabling "USEMAXPOTION" makes you use the smallest potion.

While not a bug per se, I'd like to know if the explanation is wrong, if the ellipsis is "If disabled" instead since that's its it default state, or if the variable's name is really counterintuitive.

 

[Pieter Boelen]

Fair question; I'm not entirely sure, so I can't rule anything out.

What you could do is to use trick #3 described here:
Tutorial - Modding Tips & Tricks
Then you can search for the variable name and see how it is used.
That should explain exactly what it does. I hope...

 

[MrMister]

Found its definition, and it is as I suspected: someone forgot to write "if disabled as by default" on its description. When it's enabled the potion hotkey uses the most health-restoring potion in the inventory, and if it is disabled it uses the least powerful one. To fix it just correct its description in InternalSettings.h

Now, this raises another point of interest, which I'll create another thread for in Brainstorming.

 

[Pieter Boelen]

@Grey Roger, would you be able to change that description when you've got the chance?

 

[Grey Roger]

Done - this is how it will look after the next update:

#define USEMAXPOTION_ONKEYPRESS           0    // BOOL - If 0 (default), when pressing the use potion key the SMALLEST potions will be used first. If 1, the LARGEST potion will be used first.