• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Beta2

N

Nosie_old

Captain Victorious
<img src="style_emoticons/<#EMO_DIR#>/hi.gif" style="vertical-align:middle" emoid=":gday" border="0" alt="hi.gif" /> Pieter, here I go playing your latest update:
The Flag Issue has been fixed, but the 'F' shortcut
has still got the same problem as before.
So, starting the stormy one lieves you without a Pistol!
However it's not realy a big Problem as long as you keep
an eye on it! <img src="style_emoticons/<#EMO_DIR#>/buds.gif" style="vertical-align:middle" emoid=":drunk" border="0" alt="buds.gif" />
 
I noticed that as well. I'm trying to figure out which line causes that issue. I did figure out that if I change Hook's guns to the boarders fix line, I can make the Quick Equip button work properly again. But I don't understand why, because the code in Beta 2 looks like it should work properly, while it's that same code that seems to cause the Quick Equip button to stop working properly. Also Hook says it does work properly in his game, so I'm completely at sea. <img src="style_emoticons/<#EMO_DIR#>/wacko.gif" style="vertical-align:middle" emoid=":wacko:" border="0" alt="wacko.gif" />

You can, of course, manually equip your pistol through the Inventory screen. But I prefer to get thsi fixed. <img src="style_emoticons/<#EMO_DIR#>/modding.gif" style="vertical-align:middle" emoid=":modding" border="0" alt="modding.gif" />
 
I have not experiened any difficulty with quick equip pistols button in either beta. The problem I have is crew are not using firearms in boarding.
 
There's something really weird with this. The code that IncredibleHat wrote looks wrong, but does work right with the Quick-Equip button. Hook made a fix for the code that should enable boarders to use firearms. However, this fix causes the Quick Equip button to not equip guns anymore. Even more strange: Everything DOES work properly for Hook himself. So I really don't understand this anymore. <img src="style_emoticons/<#EMO_DIR#>/wacko.gif" style="vertical-align:middle" emoid=":wacko:" border="0" alt="wacko.gif" />
 
I have been testing this some more. Apparently there is a major difference between how blades work and how guns work. Both blade and gun work the same way in initItems.c and in the Quick Equip key code. But that doesn't work. It only works if the gun works in the complete opposite way. CRAZY! <img src="style_emoticons/<#EMO_DIR#>/wacko.gif" style="vertical-align:middle" emoid=":wacko:" border="0" alt="wacko.gif" />

<!--sizeo:3--><span style="font-size:12pt;line-height:100%"><!--/sizeo--><b>Original code:</b><!--sizec--></span><!--/sizec-->
Quick Equip key works properly.
<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->void InitWeaponItemArrays()
{
    ref WeaponItem;
    ref Item;
    BLADE_HIGH = -1;
    GUN_HIGH   = -1;
    int i;
    for(i = 0; i < ITEMS_QUANTITY; i++)
    {
        makeref(Item,Items);
        if(CheckAttribute(Item,"groupID"))
        {
            if (Item.groupID == BLADE_ITEM_TYPE && !sti(Item.skipequip))
            {
                BLADE_HIGH++;
                makeref(WeaponItem,BladeItems[BLADE_HIGH]);
                CopyAttributes(WeaponItem,Item);
            }
            else
            {
                if (Item.groupID == GUN_ITEM_TYPE && sti(Item.skipequip))                {
                    GUN_HIGH++;
                    makeref(WeaponItem,GunItems[GUN_HIGH]);
                    CopyAttributes(WeaponItem,Item);
                }
            }
        }
    }<!--c2--></div><!--ec2-->
<!--sizeo:3--><span style="font-size:12pt;line-height:100%"><!--/sizeo--><b>Hook's fixed code:</b><!--sizec--></span><!--/sizec-->
Quick Equip key doesn't work properly anymore, even though the fixed code looks like it is correct and the original code looks like it's bugged. With the fixed code, apparently <i>FindCharacterItemByGroup(&PChar, GUN_ITEM_TYPE);</i> always returns "". I tested this by putting these two lines in console.c:
<i>LogIt("Blade: " + FindCharacterItemByGroup(&PChar, BLADE_ITEM_TYPE));
LogIt("Gun: " + FindCharacterItemByGroup(&PChar, GUN_ITEM_TYPE));
</i>
No matter what gun I had, it would keep returning nothing whatsoever. <img src="style_emoticons/<#EMO_DIR#>/modding.gif" style="vertical-align:middle" emoid=":modding" border="0" alt="modding.gif" />
<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->void InitWeaponItemArrays()
{
    ref WeaponItem;
    ref Item;
    BLADE_HIGH = -1;
    GUN_HIGH   = -1;
    int i;
    for(i = 0; i < ITEMS_QUANTITY; i++)
    {
        makeref(Item,Items);
        if(CheckAttribute(Item,"groupID"))
        {
            if (Item.groupID == BLADE_ITEM_TYPE && !sti(Item.skipequip))
            {
                BLADE_HIGH++;
                makeref(WeaponItem,BladeItems[BLADE_HIGH]);
                CopyAttributes(WeaponItem,Item);
            }
            else
            {
                if (Item.groupID == GUN_ITEM_TYPE && !sti(Item.skipequip))        // LDH 18Sep06 was "&& sti(Item.skipequip)"!!
                {
                    GUN_HIGH++;
                    makeref(WeaponItem,GunItems[GUN_HIGH]);
                    CopyAttributes(WeaponItem,Item);
                }
            }
        }
    }<!--c2--></div><!--ec2-->
<!--sizeo:3--><span style="font-size:12pt;line-height:100%"><!--/sizeo--><b>My rewrite of Hook's fixed code:</b><!--sizec--></span><!--/sizec-->
This does the exact same thing as Hook's fixed code. This rewrite makes it clear that guns and blades work EXACTLY the same. But with this code, where gun and blade work exactly the same, the Quick Equip key does work properly for blades, but not for guns. How crazy is that??? <img src="style_emoticons/<#EMO_DIR#>/wacko.gif" style="vertical-align:middle" emoid=":wacko:" border="0" alt="wacko.gif" />
<!--c1--><div class='codetop'>CODE</div><div class='codemain'><!--ec1-->void InitWeaponItemArrays()
{
    ref WeaponItem;
    ref Item;
    BLADE_HIGH = -1;
    GUN_HIGH   = -1;
    int i;
    for(i = 0; i < ITEMS_QUANTITY; i++)
    {
        makeref(Item,Items);
        if(CheckAttribute(Item,"groupID") && !sti(Item.skipequip))
        {
            switch(Item.groupID)
            {
                case BLADE_ITEM_TYPE:
                    BLADE_HIGH++;
                    makeref(WeaponItem,BladeItems[BLADE_HIGH]);
                    CopyAttributes(WeaponItem,Item);
                break;
                case GUN_ITEM_TYPE:
                    GUN_HIGH++;
                    makeref(WeaponItem,GUNItems[GUN_HIGH]);
                    CopyAttributes(WeaponItem,Item);
                break;
            }
        }
    }<!--c2--></div><!--ec2-->
 
I have now found out that it DOES work right if the weaponsmod is off, but not when it is on. Now we still need to figure out how to solve this when the weaponsmod is on... <img src="style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" />
 
I am not sure this will be new information but I am playing Beta 2 + the fix. The quick equip button for pistols works in my game. Crew do not use firearms during boarding.

Also I got a CTD twice on boarding the thrid ship in an engagement.
 
<!--quoteo(post=165017:date=Oct 2 2006, 06:45 PM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Oct 2 2006, 06:45 PM) [snapback]165017[/snapback]</div><div class='quotemain'><!--quotec-->
I have now found out that it DOES work right if the weaponsmod is off, but not when it is on. Now we still need to figure out how to solve this when the weaponsmod is on... <img src="style_emoticons/<#EMO_DIR#>/rolleyes.gif" style="vertical-align:middle" emoid=":rolleyes:" border="0" alt="rolleyes.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->
<img src="style_emoticons/<#EMO_DIR#>/poet.gif" style="vertical-align:middle" emoid=":hmm" border="0" alt="poet.gif" /> Well, Pieter, I don't wanna disapoint you but I've been playing the
game with the Wheapons mod off all the time and come accross that faulty
'F' button every time!!! BUGGER!! <img src="style_emoticons/<#EMO_DIR#>/mybad.gif" style="vertical-align:middle" emoid=":facepalm" border="0" alt="mybad.gif" />
 
<!--quoteo(post=165138:date=Oct 3 2006, 01:53 PM:name=Jason)--><div class='quotetop'>QUOTE(Jason @ Oct 3 2006, 01:53 PM) [snapback]165138[/snapback]</div><div class='quotemain'><!--quotec-->
I am not sure this will be new information but I am playing Beta 2 + the fix. The quick equip button for pistols works in my game. Crew do not use firearms during boarding.
<!--QuoteEnd--></div><!--QuoteEEnd-->
With Quick Equip button for pistols do you mean the [F] key or the [2] key? I have tested myself for a bit and Hook's fix prevents the F-key from working properly IF the weaponsmod is on. I turned the weaponsmod off and the Quick Equip button did work right. Perhaps the boarders would also use firearms if the weaponsmod is off, because Hook does say it works properly for him and that is the only difference between his game and the game I tested that I know of. Can you please turn the weaponsmod off, start a new game and see if boarders do use firearms that way?

<!--quoteo(post=165138:date=Oct 3 2006, 01:53 PM:name=Jason)--><div class='quotetop'>QUOTE(Jason @ Oct 3 2006, 01:53 PM) [snapback]165138[/snapback]</div><div class='quotemain'><!--quotec-->
Also I got a CTD twice on boarding the thrid ship in an engagement.
<!--QuoteEnd--></div><!--QuoteEEnd-->
Not sure why that might happen... <img src="style_emoticons/<#EMO_DIR#>/unsure.gif" style="vertical-align:middle" emoid=":?" border="0" alt="unsure.gif" />

<!--quoteo(post=165144:date=Oct 3 2006, 02:50 PM:name=Nosie)--><div class='quotetop'>QUOTE(Nosie @ Oct 3 2006, 02:50 PM) [snapback]165144[/snapback]</div><div class='quotemain'><!--quotec-->
<img src="style_emoticons/<#EMO_DIR#>/poet.gif" style="vertical-align:middle" emoid=":hmm" border="0" alt="poet.gif" /> Well, Pieter, I don't wanna disapoint you but I've been playing the
game with the Wheapons mod off all the time and come accross that faulty
'F' button every time!!! BUGGER!! <img src="style_emoticons/<#EMO_DIR#>/mybad.gif" style="vertical-align:middle" emoid=":facepalm" border="0" alt="mybad.gif" />
<!--QuoteEnd--></div><!--QuoteEEnd-->
Using which modpack version is that? I'm not entirely sure which modpack versions do and don't contain Hook's fix. I believe I remove Hook's fix from the latest one again. Perhaps the F-key works properly if the weaponsmod is on and Hook's fix isn't in there and works properly if the weaponsmod is off and Hook's fix IS in there. Anyway: There is a problem here and it'll need some more testing and fixing.
 
<!--quoteo--><div class='quotetop'>QUOTE</div><div class='quotemain'><!--quotec--> do you mean the [F] key or the [2] key?<!--QuoteEnd--></div><!--QuoteEEnd-->

I mean the [2] key.

Ok I will try it iwth the weapons mod off. Do I reinit or start a new game?

What do we loose with weapons mod?
 
Ok, I have dactived weapons mod, played through three boardings and saw no evidence my crew is using firearms.
 
<!--quoteo(post=165223:date=Oct 3 2006, 07:07 PM:name=Jason)--><div class='quotetop'>QUOTE(Jason @ Oct 3 2006, 07:07 PM) [snapback]165223[/snapback]</div><div class='quotemain'><!--quotec-->
I mean the [2] key.
<!--QuoteEnd--></div><!--QuoteEEnd-->
Please check the [F] key as well.

<!--quoteo(post=165223:date=Oct 3 2006, 07:07 PM:name=Jason)--><div class='quotetop'>QUOTE(Jason @ Oct 3 2006, 07:07 PM) [snapback]165223[/snapback]</div><div class='quotemain'><!--quotec-->
Ok I will try it iwth the weapons mod off. Do I reinit or start a new game?
<!--QuoteEnd--></div><!--QuoteEEnd-->
A reinit would work, but you'll lose most of your items. I would recommend a new game.

<!--quoteo(post=165223:date=Oct 3 2006, 07:07 PM:name=Jason)--><div class='quotetop'>QUOTE(Jason @ Oct 3 2006, 07:07 PM) [snapback]165223[/snapback]</div><div class='quotemain'><!--quotec-->
What do we loose with weapons mod?
<!--QuoteEnd--></div><!--QuoteEEnd-->
With the weaponsmod off, there are no quality distinctions anymore. So there are Sabers and Rapiers, but no Worn Sabers or Good Rapiers.

<!--quoteo(post=165254:date=Oct 3 2006, 09:41 PM:name=Jason)--><div class='quotetop'>QUOTE(Jason @ Oct 3 2006, 09:41 PM) [snapback]165254[/snapback]</div><div class='quotemain'><!--quotec-->
Ok, I have dactived weapons mod, played through three boardings and saw no evidence my crew is using firearms.
<!--QuoteEnd--></div><!--QuoteEEnd-->
You are using Beta 2 + latest fix, right? I recall I took out Hook's fix from that version, so that would explain it. I am going to check this issue out a bit more. Please test this again with Beta 3 once it's released.
 
<img src="style_emoticons/<#EMO_DIR#>/poet.gif" style="vertical-align:middle" emoid=":hmm" border="0" alt="poet.gif" /> using the latest Beta 2. <img src="style_emoticons/<#EMO_DIR#>/duel_pa.gif" style="vertical-align:middle" emoid=":ixi" border="0" alt="duel_pa.gif" />
 
<!--quoteo--><div class='quotetop'>QUOTE</div><div class='quotemain'><!--quotec-->Please test this again with Beta 3 once it's released.<!--QuoteEnd--></div><!--QuoteEEnd-->

Sure.
 
I have found that the bug is most certainly in the InitGun function in PROGRAM\ITEMS\initItems.c. I found out that when using Hook's fix everything works fine when the weaponsmod is off, but everything is messed up when the weaponsmod is on. I have now replaced the code in InitGun with the code that was in InitStdGun and it works now fine with the weaponsmod on as well. However, the game now works as if the weaponsmod is off, of course. But at least I now figured out where the error is.
 
<!--quoteo--><div class='quotetop'>QUOTE</div><div class='quotemain'><!--quotec-->However, the game now works as if the weaponsmod is off, of course. <!--QuoteEnd--></div><!--QuoteEEnd-->

Pieter, nice work.

Do I understand that with the fix desribed in your post, if you set the weaponsmod to on, the game still behaves as if the mod is off, ie, none of the new blades and pistols, and no quality for weapons?
 
<!--sizeo:3--><span style="font-size:12pt;line-height:100%"><!--/sizeo--><b>Fix found!</b><!--sizec--></span><!--/sizec-->
After much work, I have discovered that the gun.skipequip attribute was missing from InitGun(). That explains why it wasn't working properly. The fix is simple: Just add the attribute. In combination with Hook's fix, I dare say that this will make everything work properly again. I tested the [F] key and it works without trouble now. With a bit of luck, this will also fix the boarders not using any guns bug. <img src="style_emoticons/<#EMO_DIR#>/icon_mrgreen1.gif" style="vertical-align:middle" emoid=":cheeky" border="0" alt="icon_mrgreen1.gif" />

Note: If you were testing with the weaponsmod off, don't forget to turn it on again now. <img src="style_emoticons/<#EMO_DIR#>/icon_wink.gif" style="vertical-align:middle" emoid=";)" border="0" alt="icon_wink.gif" />
 
<img src="style_emoticons/<#EMO_DIR#>/par-ty.gif" style="vertical-align:middle" emoid=":cheers" border="0" alt="par-ty.gif" /> Peiter,

Good work.

New game or reinit?
 
NICE WORK Pieter!!!!!
<img src="style_emoticons/<#EMO_DIR#>/par-ty.gif" style="vertical-align:middle" emoid=":cheers" border="0" alt="par-ty.gif" />


H.M.M.
 
<!--quoteo(post=165213:date=Oct 4 2006, 02:00 AM:name=Pieter Boelen)--><div class='quotetop'>QUOTE(Pieter Boelen @ Oct 4 2006, 02:00 AM) [snapback]165213[/snapback]</div><div class='quotemain'><!--quotec-->
Using which modpack version is that? I'm not entirely sure which modpack versions do and don't contain Hook's fix. I believe I remove Hook's fix from the latest one again. Perhaps the F-key works properly if the weaponsmod is on and Hook's fix isn't in there and works properly if the weaponsmod is off and Hook's fix IS in there. Anyway: There is a problem here and it'll need some more testing and fixing.
<!--QuoteEnd--></div><!--QuoteEEnd-->
<img src="style_emoticons/<#EMO_DIR#>/poet.gif" style="vertical-align:middle" emoid=":hmm" border="0" alt="poet.gif" /> It's Beta2 and I never have used the '2' as I never have it
on because of accidental hitting(big fingers).I will try again and let you know.
...and the crew uses it's firearms at boarding, never have any problems with that!
<img src="style_emoticons/<#EMO_DIR#>/yes.gif" style="vertical-align:middle" emoid=":yes" border="0" alt="yes.gif" />
 
You must log in or register to reply here.
Back
Top