Fixed Fetch Quest Bugs

[Levis]

Just a couple of reminders here:

- Fetch Quests showed up at the very top in the dialog tree, which made them a bit too prominent; this *may* be improved in the Beta 3.5 WIP, but I'd like confirmation on that.

Need to check that. How did you fix it?
We could just use an absolute positions. but than we need to know for sure there isn't another dialog option there.
Else I have to rewrite my dialog sorting cause now it assumes that added dialog is important so it will always be put on top.

- Gunsmith Fetch Quests can require Gunpowder, which could be annoying since that is an important regular ship supply as well.

As soon as I introduced some new goods like Iron we can remove the gunpowder

- Fetch Quests apparently don't expire qucikly enough, eventually leaving many open quests all over the Caribbean and many depleted goods.

It's between 2 and 6 months now. What are better paramameters? Maybe have it depended if you are using open sea mod or not?

- Quest isn't concluded until AFTER the dialog is closed, allowing you to complete it several times in a row.

Need to look into this. Would it be the case for all fetch quests or just some?

1 - There was a shipyard in need of something and i bought it from the plantation of the same city. Can't remember which it was, though.

Fair point. forgot you could also buy stuff at a plantation. That has to be changed.

2 - There was a gunsmith who was in need of gunpowder. I am playing ammo and gunpowder off, so...

Need to make a check for this too indeed.

 

[Levis]

@Pieter Boelen how can the quest be finished twice trough the dialog?

 

[Pieter Boelen]

Need to check that. How did you fix it?

If I recall, I set the Fetch Quest links in the First and Second Time cases to .l10 instead of a lower number.
That seems to have moved it down the list. There were some comments on this a while back, but haven't heard them recently so assume it is no longer a concern.

There was something weird with the ordering of the various links, but I can't remember now what it was.
Perhaps it was that the ordering would place .l10 before .l2 because it starts with a "1" or something.

@Pieter Boelen how can the quest be finished twice trough the dialog?

I never got round to testing it myself. Was it not @Grey Roger who reported it?
From what I understood, the dialog did not close upon finishing a Fetch Quest and you were able to do it again.
I just looked through the code for this and don't understand how that could be possible; there is only an exit case with the completion.

 

[Levis]

This new version of dialog.c should fix the sorting issue.
Say you have a l1 in your first dialog file and in the second dialog file they will be put after each other.
the numbering now is:
link number _ dialog file number

so if dialog 1 has:
l1
l2
l3
l4

and dialog 2 has:
l1
l3
l9

it will make it:
l11
l12
l21
l31
l32
l41
l92

So you see this could go wrong if a character has more then 9 dialog files linked to him. If that is the case I think something else is going wrong already , and if that isn't we can then fix that by just introducing a 0 in front of single digits.
let me know how this works out. Maybe the numbering of some of the files has to be changed to finetune it.

 

[Pieter Boelen]

At the moment there are no characters with more than 2 dialog files, so weer should be good there.

We'll see what this does in the game then!

 

[Grey Roger]

If I recall, I set the Fetch Quest links in the First and Second Time cases to .l10 instead of a lower number.
That seems to have moved it down the list. There were some comments on this a while back, but haven't heard them recently so assume it is no longer a concern.

It certainly seems to have been fixed as far as I can see. Various blacksmiths and shipyards have had the dialog line about them needing resources but it's not the top line any more.

I never got round to testing it myself. Was it not @Grey Roger who reported it?
From what I understood, the dialog did not close upon finishing a Fetch Quest and you were able to do it again.
I just looked through the code for this and don't understand how that could be possible; there is only an exit case with the completion.

The report in which I mentioned that was in the second paragraph of this post:
http://www.piratesahoy.net/threads/new-fetch-quest-for-3-3-needs-testing.21152/page-15#post-501529

Were the other issues fixed? Gunpowder being a fetch item, which anyone playing a combat-based game will have in large amounts? Fetch items being exports from the colony in question, making the whole premise of the fetch quest silly?

 

[Levis]

Still working on the other issues

 

[Pieter Boelen]

Error.log entry:

RUNTIME ERROR - file: quests\quests_common.c; line: 515
missed attribute: island
RUNTIME ERROR - file: quests\quests_common.c; line: 515
no rAP data

    //If there are less then 2 fetchquests on the island see if one is generated
     if(fetchquest < MAX_NUMBER_FETCH_QUEST)
     {
       if(rand(CHANCE_FETCH_QUEST)<1)
       {
         int townnum = rand(GetIslandTownsQuantity(tisland.id)-1)+1;
         if(townnum>0)
         {
           ref ttown = GetTownFromID(GetTownIDFromIsland(tisland.id, townnum));
           if(DEBUG_FETCH_QUEST) trace("FETCH QUEST: make fetch quest for "+tisland.name+" with "+townnum+" towns. Pick town "+ttown.name);
           cargoid = GenerateFetchCargo(ttown);
           AnnounceFetchQuestEvent(sti(ttown.island), cargoid); // <-------------- THIS LINE ---------------
         }
       }
     }

Seems to happen often in Early Explorers, which is weird because I thought we fixed that.

 

[Levis]

Tought we did indeed. Have to look into it

 

[Levis]

The fetchquest now checks if you are using the ammo mod before using gunpowder as fetch item (untill I have something better).
Also found something weird in the code which might explain some of the weird things.
Please test them after installing this:
http://www.piratesahoy.net/threads/levis-stuff-v-1-5.25316/

 

[Pieter Boelen]

Also found something weird in the code which might explain some of the weird things.

Such as the time travel, you mean?

 

[Levis]

dont see how it could create time travel. but there was something weird going on with the island array so that could influence a lot of stuff.

 

[Pieter Boelen]

Just got all this on a new game in Early Explorers:

RUNTIME ERROR - file: quests\quests_common.c; line: 549
missed attribute: island
RUNTIME ERROR - file: quests\quests_common.c; line: 549
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid index -1 [size:24]
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid array index
RUNTIME ERROR - file: quests\quests_common.c; line: 549
function 'getFetchQuestCargo' stack error
RUNTIME ERROR - file: dialogs\tailor.c; line: 143
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 143
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 532
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 532
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 532
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 532
no rAP data
RUNTIME ERROR - file: dialogs\tailor.c; line: 144
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 144
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 537
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 537
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 537
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 537
no rAP data
RUNTIME ERROR - file: dialogs\tailor.c; line: 145
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 145
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 591
missed attribute: economy
RUNTIME ERROR - file: quests\quests_common.c; line: 591
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 549
missed attribute: island
RUNTIME ERROR - file: quests\quests_common.c; line: 549
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid index -1 [size:24]
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid array index
RUNTIME ERROR - file: quests\quests_common.c; line: 549
function 'getFetchQuestCargo' stack error
RUNTIME ERROR - file: dialogs\tailor.c; line: 143
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 143
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 532
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 532
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 532
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 532
no rAP data
RUNTIME ERROR - file: dialogs\tailor.c; line: 144
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 144
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 537
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 537
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 537
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 537
no rAP data
RUNTIME ERROR - file: dialogs\tailor.c; line: 145
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 145
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 591
missed attribute: economy
RUNTIME ERROR - file: quests\quests_common.c; line: 591
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 549
missed attribute: island
RUNTIME ERROR - file: quests\quests_common.c; line: 549
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid index -1 [size:24]
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid array index
RUNTIME ERROR - file: quests\quests_common.c; line: 549
function 'getFetchQuestCargo' stack error

 

[Levis]

Just got all this on a new game in Early Explorers:

RUNTIME ERROR - file: quests\quests_common.c; line: 549
missed attribute: island
RUNTIME ERROR - file: quests\quests_common.c; line: 549
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid index -1 [size:24]
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid array index
RUNTIME ERROR - file: quests\quests_common.c; line: 549
function 'getFetchQuestCargo' stack error
RUNTIME ERROR - file: dialogs\tailor.c; line: 143
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 143
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 532
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 532
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 532
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 532
no rAP data
RUNTIME ERROR - file: dialogs\tailor.c; line: 144
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 144
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 537
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 537
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 537
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 537
no rAP data
RUNTIME ERROR - file: dialogs\tailor.c; line: 145
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 145
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 591
missed attribute: economy
RUNTIME ERROR - file: quests\quests_common.c; line: 591
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 549
missed attribute: island
RUNTIME ERROR - file: quests\quests_common.c; line: 549
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid index -1 [size:24]
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid array index
RUNTIME ERROR - file: quests\quests_common.c; line: 549
function 'getFetchQuestCargo' stack error
RUNTIME ERROR - file: dialogs\tailor.c; line: 143
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 143
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 532
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 532
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 532
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 532
no rAP data
RUNTIME ERROR - file: dialogs\tailor.c; line: 144
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 144
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 537
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 537
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 537
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 537
no rAP data
RUNTIME ERROR - file: dialogs\tailor.c; line: 145
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 145
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 542
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 542
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 591
missed attribute: economy
RUNTIME ERROR - file: quests\quests_common.c; line: 591
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 549
missed attribute: island
RUNTIME ERROR - file: quests\quests_common.c; line: 549
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid index -1 [size:24]
RUNTIME ERROR - file: quests\quests_common.c; line: 549
invalid array index
RUNTIME ERROR - file: quests\quests_common.c; line: 549
function 'getFetchQuestCargo' stack error

I didn't get it while testing so should be a problem with the new period settings. So need the new files first.

 

[Pieter Boelen]

Happens only sometimes. Might be because of Antigua being disabled now, but that should be already in last week's upload.

 

[Pieter Boelen]

I managed to replicate this problem very reliably. I also don't even remotely understand what is going on.
To replicate, start Free Play as Francis Drake. Go to the Tortuga tailor and talk to the French one.
You'll notice loading the dialog takes a while, which is because it is busy writing error logs:

RUNTIME ERROR - file: quests\quests_common.c; line: 555
missed attribute: island
RUNTIME ERROR - file: quests\quests_common.c; line: 555
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 555
invalid index -1 [size:24]
RUNTIME ERROR - file: quests\quests_common.c; line: 555
invalid array index
RUNTIME ERROR - file: quests\quests_common.c; line: 555
function 'getFetchQuestCargo' stack error
RUNTIME ERROR - file: dialogs\tailor.c; line: 143
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 143
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 534
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 534
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 534
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 534
no rAP data
RUNTIME ERROR - file: dialogs\tailor.c; line: 144
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 144
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 541
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 541
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 541
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 541
no rAP data
RUNTIME ERROR - file: dialogs\tailor.c; line: 145
missed attribute: island
RUNTIME ERROR - file: dialogs\tailor.c; line: 145
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 546
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 546
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 546
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 546
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 546
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 546
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 546
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 546
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 546
missed attribute: cargos
RUNTIME ERROR - file: quests\quests_common.c; line: 546
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 546
null ap
RUNTIME ERROR - file: quests\quests_common.c; line: 546
no rAP data
RUNTIME ERROR - file: quests\quests_common.c; line: 597
missed attribute: economy
RUNTIME ERROR - file: quests\quests_common.c; line: 597
no rAP data

I did several DumpAttributes on the troublesome spots:

::getFetchQuestCargo::
old =
  name = Sir Richard
  lastname = Dutton
  middlename = Martínez
name = Sir Richard
lastname = Dutton
::getCargoAmount::
id = FalaiseDeFleur
model = FalaiseDeFleur
filespath =
  models = islands\FalaiseDeFleur
refl_model = FalaiseDeFleur_refl
locators = FalaiseDeFleur_locators
visible = 1
smuggling_nation = 1
interfacetextures =
  t1 = battle_interface\moor-town.tga
  h = 4
  v = 16
  t2 = battle_interface\moor-shores.tga
  h = 4
  v = 16
trade =
  export =
  id1 = 7
  id2 = 12
  id3 = 25
  id4 = 24
  id5 = 10
  import =
  id1 = 8
  id2 = 19
  id3 = 1
  id4 = 32
  id5 = 9
  id6 = 15
  contraband =
  id1 = 18
  id2 = 30
  id3 = 11
towns =
  1 = Falaise de Fleur
  quantity = 1
reload =
  l1 =
  label = Saint Pierre Port
  name = reload_1
  go = Falaise_de_fleur_port_01
  emerge = sea
  radius = 200.0000000
  pic = 15
  tex = t1
  goto_enable = 0
  x = 24.3258
  y = 0
  z = 131.444
  ships =
  l0 =
  x = 10.29
  y = 0
  z = 105.411
  ay = -0.858024
  l1 =
  x = 55.0651
  y = 0
  z = 132.727
  ay = -1.09843
  l2 =
  x = 39.9681
  y = 0
  z = 170.038
  ay = -0.801283
  l3 =
  x = -12.7078
  y = 0
  z = 194.084
  ay = -0.840789
  l4 =
  x = -56.3987
  y = 0
  z = 131.261
  ay = 0.146066
  l5 =
  x = -31.1575
  y = 0
  z = 258.423
  ay = -0.189116
  l6 =
  x = 40.7665
  y = 0
  z = 236.267
  ay = -1.46412
  l7 =
  x = -89.488
  y = 0
  z = 192.107
  ay = -0.0143101
  old =
  label = #stown_name# Port
  l2 =
  label = Octopus Bay
  name = reload_2
  go = Falaise_de_Fleur_shore
  emerge = reload1
  radius = 200.0000000
  pic = 21
  tex = t2
  goto_enable = 0
  x = 650.843
  y = 0
  z = 554.778
  ships =
  l0 =
  x = 632.701
  y = 0
  z = 647.002
  ay = 0.138386
  l1 =
  x = 696.199
  y = 0
  z = 603.633
  ay = 1.5981
  l2 =
  x = 701.562
  y = 0
  z = 495.971
  ay = 0.444826
  l3 =
  x = 765.005
  y = 0
  z = 514.076
  ay = 0.320117
  l4 =
  x = 796.451
  y = 0
  z = 629.147
  ay = 0.0146511
  l5 =
  x = 697.521
  y = 0
  z = 683.926
  ay = 0.284106
  l6 =
  x = 812.787
  y = 0
  z = 475.995
  ay = 0.902231
  l7 =
  x = 836.358
  y = 0
  z = 566.942
  ay = 1.49159
  old =
  label = Octopus Bay
  l3 =
  label = Saint Pierre Fort
  name = reload_fort1
  go = Fort
  goafterboard =
  location = reload_1
  emerge = see
  radius = 250.0000000
  commander = FalaiseDeFleur Commander
  fort =
  model = FalaiseDeFleur_fort1
  locators = FalaiseDeFleur_fort1_locators
  pic = 22
  tex = t1
  goto_enable = 0
  x = 17.191
  y = 10.791
  z = -2.25536
  ships =
  old =
  label = #stown_name# Fort
name = Martinique
reload_enable = 1
quest_ships =
  quest_ship_1 =
  x = -922.931
  y = 0
  z = 1409.58
  ay = 1.19057
  quest_ship_2 =
  x = -1431.44
  y = 0
  z = 994.021
  ay = 0.520044
  quest_ship_3 =
  x = -428.723
  y = 0
  z = 1352.22
  ay = 1.70474
  quest_ship_4 =
  x = 1449.13
  y = 0
  z = 919.835
  ay = 2.87634
  quest_ship_5 =
  x = 1103.28
  y = 0
  z = 1323.55
  ay = 2.87634
  quest_ship_6 =
  x = 472.5
  y = 0
  z = 1613.02
  ay = 2.1847
  quest_ship_7 =
  x = 39.0346
  y = 0
  z = -1912.33
  ay = 1.37395
  quest_ship_8 =
  x = 626.538
  y = 0
  z = -1615.03
  ay = 1.37395
  quest_ship_9 =
  x = 1042.2
  y = 0
  z = -1185.86
  ay = 0.478173
  quest_ship_10 =
  x = -1829.89
  y = 0
  z = -1093.22
  ay = 0.478173
  quest_ship_11 =
  x = -1199.44
  y = 0
  z = -1419.98
  ay = -1.05102
  quest_ship_12 =
  x = -2192.88
  y = 0
  z = -17.1268
  ay = 0.168812
  quest_ship_13 =
  x = -232.833
  y = 0
  z = -38.3755
  ay = -2.49318
  quest_ship_14 =
  x = -261.034
  y = 0
  z = 94.3859
  ay = 2.49724
  quest_ship_15 =
  x = -208.52
  y = 0
  z = 216.462
  ay = -0.0616712
  quest_ship_16 =
  x = -179.286
  y = 0
  z = 340.078
  ay = -1.60275
  quest_ship_17 =
  x = -353.224
  y = 0
  z = 281.547
  ay = 2.27208
  quest_ship_18 =
  x = -394.284
  y = 0
  z = 142.91
  ay = 0.43075
  quest_ship_19 =
  x = 1112.16
  y = 0
  z = 423.061
  ay = -0.00208524
  quest_ship_20 =
  x = 1041.38
  y = 0
  z = 706.428
  ay = -0.676995
  quest_ship_21 =
  x = 806.957
  y = 0
  z = 885.362
  ay = 1.3765
  quest_ship_22 =
  x = 654.736
  y = 0
  z = 933.357
  ay = 2.23867
smuggling =
  amount = 628
  state = 3
  date =
  year = 1578
  month = 7
  day = 10
  time = 13.0000000
  pause =
  2 =
  start = 20.6666660
  end = 22.0833340
  name = dinner
  patrol =
  0 =
  start = 0.0000000
  groups = 6
  name = patrol
  end = 11.5000000
  1 =
  start = 11.5000000
  groups = 9
  name = patrol
  end = 18.9166660
  2 =
  start = 18.9166660
  end = 24.0000000
  groups = 12
  name = patrol
  patrolversion = 1
::getCargoGood::
id = FalaiseDeFleur
model = FalaiseDeFleur
filespath =
  models = islands\FalaiseDeFleur
refl_model = FalaiseDeFleur_refl
locators = FalaiseDeFleur_locators
visible = 1
smuggling_nation = 1
interfacetextures =
  t1 = battle_interface\moor-town.tga
  h = 4
  v = 16
  t2 = battle_interface\moor-shores.tga
  h = 4
  v = 16
trade =
  export =
  id1 = 7
  id2 = 12
  id3 = 25
  id4 = 24
  id5 = 10
  import =
  id1 = 8
  id2 = 19
  id3 = 1
  id4 = 32
  id5 = 9
  id6 = 15
  contraband =
  id1 = 18
  id2 = 30
  id3 = 11
towns =
  1 = Falaise de Fleur
  quantity = 1
reload =
  l1 =
  label = Saint Pierre Port
  name = reload_1
  go = Falaise_de_fleur_port_01
  emerge = sea
  radius = 200.0000000
  pic = 15
  tex = t1
  goto_enable = 0
  x = 24.3258
  y = 0
  z = 131.444
  ships =
  l0 =
  x = 10.29
  y = 0
  z = 105.411
  ay = -0.858024
  l1 =
  x = 55.0651
  y = 0
  z = 132.727
  ay = -1.09843
  l2 =
  x = 39.9681
  y = 0
  z = 170.038
  ay = -0.801283
  l3 =
  x = -12.7078
  y = 0
  z = 194.084
  ay = -0.840789
  l4 =
  x = -56.3987
  y = 0
  z = 131.261
  ay = 0.146066
  l5 =
  x = -31.1575
  y = 0
  z = 258.423
  ay = -0.189116
  l6 =
  x = 40.7665
  y = 0
  z = 236.267
  ay = -1.46412
  l7 =
  x = -89.488
  y = 0
  z = 192.107
  ay = -0.0143101
  old =
  label = #stown_name# Port
  l2 =
  label = Octopus Bay
  name = reload_2
  go = Falaise_de_Fleur_shore
  emerge = reload1
  radius = 200.0000000
  pic = 21
  tex = t2
  goto_enable = 0
  x = 650.843
  y = 0
  z = 554.778
  ships =
  l0 =
  x = 632.701
  y = 0
  z = 647.002
  ay = 0.138386
  l1 =
  x = 696.199
  y = 0
  z = 603.633
  ay = 1.5981
  l2 =
  x = 701.562
  y = 0
  z = 495.971
  ay = 0.444826
  l3 =
  x = 765.005
  y = 0
  z = 514.076
  ay = 0.320117
  l4 =
  x = 796.451
  y = 0
  z = 629.147
  ay = 0.0146511
  l5 =
  x = 697.521
  y = 0
  z = 683.926
  ay = 0.284106
  l6 =
  x = 812.787
  y = 0
  z = 475.995
  ay = 0.902231
  l7 =
  x = 836.358
  y = 0
  z = 566.942
  ay = 1.49159
  old =
  label = Octopus Bay
  l3 =
  label = Saint Pierre Fort
  name = reload_fort1
  go = Fort
  goafterboard =
  location = reload_1
  emerge = see
  radius = 250.0000000
  commander = FalaiseDeFleur Commander
  fort =
  model = FalaiseDeFleur_fort1
  locators = FalaiseDeFleur_fort1_locators
  pic = 22
  tex = t1
  goto_enable = 0
  x = 17.191
  y = 10.791
  z = -2.25536
  ships =
  old =
  label = #stown_name# Fort
name = Martinique
reload_enable = 1
quest_ships =
  quest_ship_1 =
  x = -922.931
  y = 0
  z = 1409.58
  ay = 1.19057
  quest_ship_2 =
  x = -1431.44
  y = 0
  z = 994.021
  ay = 0.520044
  quest_ship_3 =
  x = -428.723
  y = 0
  z = 1352.22
  ay = 1.70474
  quest_ship_4 =
  x = 1449.13
  y = 0
  z = 919.835
  ay = 2.87634
  quest_ship_5 =
  x = 1103.28
  y = 0
  z = 1323.55
  ay = 2.87634
  quest_ship_6 =
  x = 472.5
  y = 0
  z = 1613.02
  ay = 2.1847
  quest_ship_7 =
  x = 39.0346
  y = 0
  z = -1912.33
  ay = 1.37395
  quest_ship_8 =
  x = 626.538
  y = 0
  z = -1615.03
  ay = 1.37395
  quest_ship_9 =
  x = 1042.2
  y = 0
  z = -1185.86
  ay = 0.478173
  quest_ship_10 =
  x = -1829.89
  y = 0
  z = -1093.22
  ay = 0.478173
  quest_ship_11 =
  x = -1199.44
  y = 0
  z = -1419.98
  ay = -1.05102
  quest_ship_12 =
  x = -2192.88
  y = 0
  z = -17.1268
  ay = 0.168812
  quest_ship_13 =
  x = -232.833
  y = 0
  z = -38.3755
  ay = -2.49318
  quest_ship_14 =
  x = -261.034
  y = 0
  z = 94.3859
  ay = 2.49724
  quest_ship_15 =
  x = -208.52
  y = 0
  z = 216.462
  ay = -0.0616712
  quest_ship_16 =
  x = -179.286
  y = 0
  z = 340.078
  ay = -1.60275
  quest_ship_17 =
  x = -353.224
  y = 0
  z = 281.547
  ay = 2.27208
  quest_ship_18 =
  x = -394.284
  y = 0
  z = 142.91
  ay = 0.43075
  quest_ship_19 =
  x = 1112.16
  y = 0
  z = 423.061
  ay = -0.00208524
  quest_ship_20 =
  x = 1041.38
  y = 0
  z = 706.428
  ay = -0.676995
  quest_ship_21 =
  x = 806.957
  y = 0
  z = 885.362
  ay = 1.3765
  quest_ship_22 =
  x = 654.736
  y = 0
  z = 933.357
  ay = 2.23867
smuggling =
  amount = 628
  state = 3
  date =
  year = 1578
  month = 7
  day = 10
  time = 13.0000000
  pause =
  2 =
  start = 20.6666660
  end = 22.0833340
  name = dinner
  patrol =
  0 =
  start = 0.0000000
  groups = 6
  name = patrol
  end = 11.5000000
  1 =
  start = 11.5000000
  groups = 9
  name = patrol
  end = 18.9166660
  2 =
  start = 18.9166660
  end = 24.0000000
  groups = 12
  name = patrol
  patrolversion = 1

Whaaaa!?!? And also that BLOODY BASTARD of a Sir Richard Dutton rears his ugly head again.
He has NO business being ANYWHERE NEAR that functionality!

NOTE: This probably works also for other tailors than the Tortuga one.
Maybe even for ALL characters featuring fetch quests.

 

[Pieter Boelen]

Never mind, PROBLEM SOLVED!
This got caused because the Tortuga tailor was missing its .townsack attribute.
Added now and no more errors.

 

[Jack Rackham]

Thanks Pieter, missed that because I copied the tailor in GoldBug Charleston.

 

[Pieter Boelen]

No worries; I was afraid this was a nasty bug. But it wasn't. So I'm quite happy.

 

[Pieter Boelen]

All updates to Fetch Quests now included in here: http://www.piratesahoy.net/threads/build-14-beta-3-5-internal-wip-for-testing.24817
These were some relatively large changes, so hopefully the code will now behave itself properly.
However, please let us know if there is ANY weirdness still happening with it.