Fixed Master at arms has no contributing perks

[Levis]

Mostly reminder to myself, it seems something goes weird here so need to look into it.

 

[Pieter Boelen]

"Master at Arms" or "Comrade in Arms"? The second one are quest characters that I don't think are supposed to contribute anything.

Of course nobody is stopping you from assigning Virginie d'Espivant as navigator after she joins you, though.
Who knows? Maybe she's really good at it!

As for "Master at Arms", aren't those the "fighter" type? I think there were originally intended as purely "brute force".

 

[Levis]

yes the fighter type. In the officers file they have set to have no contributing perks so they should only have the fighting perks. But when I hired one he did had other perks too. So need to look into that. Probably because he has none set something is going wrong there. but only noticed it later and didn't had a savegame anymore.

 

[Pieter Boelen]

Having perks and contributing them are two different things.
I know you changed the code that controls what abilities officers contribute.
But as far as I'm aware, the code that controls what abilities officers get has not been changed in a long time now.

The relevant file is PROGRAM\Loc_ai\LAi_CreateOfficer.c, specifically the LAi_Create_Officer function.
If I recall, it gives perks based on officer type. But when it still has perks but nothing left for the officer type, it'll start adding other ones.

 

[Levis]

I actually changed the code to which ones they get also so they only get perks which contribute.
But what I ment was that the master at arms had perks which where listed as contributing while they shouldn't be.

 

[Pieter Boelen]

Ah, right.

 

[Levis]

Forgot to define some stuff.
Fixed it now. Will upload a zip with some other fixes in a minute.

 

[Levis]

Fixed in here:
http://www.piratesahoy.net/threads/...nal-wip-for-testing.24817/page-30#post-511063

an F11 is needed to get the right perks for him. He will still has some old ones left if you take a old savegame. I could give you a console command if you want to get rid of those.

Seems the type fighter isn't used. This is about the abordage type. I gave him a few interesting perks .