@Jason reported a distinct lack of violence in the game as well:
And all of the random people you encounter are not carrying blades, and this is problematic when they are highway men in the jungle and they attack you and you get the undrawn blade penalty.
So far, all similar instances have been traced back to a change I made a few weeks ago:
Fixed - Merchants Equip Their Stock | PiratesAhoy!
Problem is that the "isMerchant" gets applied to a LOT more characters than are actually meant to have it.
For the "Quest Pirate" I was able to track down where and why this happened and addressed that at the source.
But for "Artois Voysey", I have yet been unable to figure out where and why he gets assigned like that.
For that line of code of mine to prevent item traders equipping items, I think I have an alternate approach that should prevent the non-violence.
In PROGRAM\Characters\characters_login.c find:
Code:
if (GetAttribute(chr,"isMerchant") == 1) return; // PB: Merchants shouldn't equip their own stock
Replace with:
Code:
if (CheckAttribute(chr,"itemtrade")) return; // PB: Merchants shouldn't equip their own stock
That should ensure only REAL item traders are affected by this behaviour and NOT any other characters who got set to "MerchantType" at some point.
However, that doesn't explain why this happens in the first place.
I think this also means that Artois may get set to OFFIC_TYPE_SHOPKEEPER by the
CheckCharacterSetup function, which of course isn't intentional either.
![Facepalm :facepalm :facepalm](/styles/emoticons/mybad.gif)
Probably
@Levis will need to shed some light on this one. But for now, hopefully this change will make the game more playable again.