1. Dismiss Notice
  2. GOG.com logo

    Thanks to YOUR votes, GOG.com now sells:
    - Sea Dogs - Sea Dogs: Caribbean Tales
    - Sea Dogs: City of Abandoned Ships

    Vote now to add Pirates of the Caribbean to the list!

    Dismiss Notice
  3. Under the Crossbones Podcast

    A Pirate Podcast with Interviews
    Music, Comedy and all things Pirate!

    - Episode Guide - About - Subscribe -
    - Twitter - Facebook - iTunes - Android -
    - Youtube - Fill the Coffers -

    Dismiss Notice
  4. New Horizons logo

    Quick links for PotC: New Horizons
    - Download latest version
    - Wiki - FAQ - Report bugs here
    - ModDB profile

  5. GOF logo

    Quick links for AoP2: Gentlemen of Fortune 2
    - Downloads and info
    - Historical Immersion Supermod
    - ModDB Profile

Dismiss Notice
New to the forum?
Please take a moment to read our Welcome Message and Forum Rules.

Included in Build Post 28th July fixes

Discussion in 'Features Archive' started by Grey Roger, Nov 17, 2016.

  1. ANSEL

    ANSEL Corsair Storm Modder Hearts of Oak Donator

    Joined:
    Aug 18, 2013
    Messages:
    1,767
    Gender:
    Male
    Occupation:
    Artist,Painter
    Location:
    Viborg.Denmark
    Well I use the" @Grey Roger's "Post 28 July 2016 Fixes" archive."
    So I think it will be this version I want to do some test in.
     
  2. LarryHookins

    LarryHookins Buccaneer Staff Member Storm Modder

    Joined:
    May 20, 2006
    Messages:
    2,291
    Location:
    Texas
    The file cccdirectsail.c is a drop-in replacement for that file. The other changes are minor and shouldn't be a problem to winmerge into whatever version you want to test them with, even if that version doesn't exist yet. Since all the changed are marked with my initials LDH and dated Oct16 or Nov16, they should be obvious.

    This has got to be easier than what Pieter was going through 7 years ago, merging changes from numerous programmers into a single new version.

    Hook
     
    Pieter Boelen likes this.
  3. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,575
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    Thanks! In that case, I think either @LarryHookins, @Grey Roger or myself should make a 100% compatible version for the "Post 28 July 2016 Fixes" archive".
    Then @Grey Roger doesn't have to include it yet now, but you can test it separately and when you approve it, then it can be included in the next version.

    Does that sound like a plan?

    True, that! :rofl
     
  4. ANSEL

    ANSEL Corsair Storm Modder Hearts of Oak Donator

    Joined:
    Aug 18, 2013
    Messages:
    1,767
    Gender:
    Male
    Occupation:
    Artist,Painter
    Location:
    Viborg.Denmark
    It sounds fine. Then I will wait for a compatible version with the "Post 28 July 2016 Fixes"
    before going testing. Right?
     
  5. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,575
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    Yes indeed. So @Grey Roger can make his file without it included and then (shortly) afterwards, one of us three should make a compatible version.

    Ideally I'm inclined to consider @Grey Roger's fixes archive + @LarryHookins' DirectSail update + whatever small fixes are made = Build 14 Beta 4.1 public release.
    I might have a quick look through the code of that "experimental" archive, but most likely I'll leave all of that aside.
    Would be pretty awesome if we could finalise such a Beta 4.1 shortly after the Christmas holidays! :woot
     
  6. ANSEL

    ANSEL Corsair Storm Modder Hearts of Oak Donator

    Joined:
    Aug 18, 2013
    Messages:
    1,767
    Gender:
    Male
    Occupation:
    Artist,Painter
    Location:
    Viborg.Denmark
    Yes I agree with that. Wise to wait with the experimental stuff. A Beta 4.1 after the
    Christmas holidays sound just great!:D
     
  7. Grey Roger

    Grey Roger Sea Dog Staff Member Storm Modder

    Joined:
    Feb 12, 2007
    Messages:
    6,383
    Good, then I've got a bit of work on "Ardent" to finish off in the next day or two, and if I manage that, it goes into the archive. Regardless, the archive goes onto the FTP site by the end of the week so you can try it out over the holidays.

    And then, early next year, while you lot are getting the DirectSail update into a usable state, I'm going to try to finish the storyline...
     
    Pieter Boelen likes this.
  8. ANSEL

    ANSEL Corsair Storm Modder Hearts of Oak Donator

    Joined:
    Aug 18, 2013
    Messages:
    1,767
    Gender:
    Male
    Occupation:
    Artist,Painter
    Location:
    Viborg.Denmark
    @Grey Roger I don't think I have access to the FTP site, could be nice if I have.
    You are waiting troubles with the DirectSail update?
     
  9. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,575
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    You don't need specific access to download from the FTP, only to upload to it.
    The link in the opening post already points to a file on the FTP. :doff

    For now, only @LarryHookins has used it. As far as I know, nobody else touched the file.
    So it may be 100% OK for all anyone knows.
     
  10. Jack Rackham

    Jack Rackham HoO Team Member Quest Writer Storm Modder

    Joined:
    Jul 5, 2004
    Messages:
    3,287
    Gender:
    Male
    Occupation:
    math teacher
    Location:
    Sund, Ramsjö, Sweden
    It's on my todo list.
     
    Pieter Boelen likes this.
  11. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,575
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    Thanks, Jack. :cheers
     
  12. Jack Rackham

    Jack Rackham HoO Team Member Quest Writer Storm Modder

    Joined:
    Jul 5, 2004
    Messages:
    3,287
    Gender:
    Male
    Occupation:
    math teacher
    Location:
    Sund, Ramsjö, Sweden
    I have changed all that kind of code in itemsbox.c now. Will be uploaded later together
    with other things. If there any other places I'll fix them when I run into them.
     
    Pieter Boelen likes this.
  13. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,575
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
  14. Grey Roger

    Grey Roger Sea Dog Staff Member Storm Modder

    Joined:
    Feb 12, 2007
    Messages:
    6,383
  15. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,575
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
  16. Jack Rackham

    Jack Rackham HoO Team Member Quest Writer Storm Modder

    Joined:
    Jul 5, 2004
    Messages:
    3,287
    Gender:
    Male
    Occupation:
    math teacher
    Location:
    Sund, Ramsjö, Sweden
    Maybe if your uploads could have different names or even better a date.
     
  17. ANSEL

    ANSEL Corsair Storm Modder Hearts of Oak Donator

    Joined:
    Aug 18, 2013
    Messages:
    1,767
    Gender:
    Male
    Occupation:
    Artist,Painter
    Location:
    Viborg.Denmark
    The version I want to test, is now named: 23 November.
     
  18. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,575
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    I just finished merging the latest fixes compiled by Grey Roger with my own game version.
    As part of this, I re-added some fixes of my own back in that either were lost to the depths of Davy Jones' Locker (=the forum) or that I forgot to ever post.
    And I also did my usual "check of all the new stuff added" and made some further tweaks and attempted improvements to that.
    So for the next "official update", I would propose taking Grey Roger's archive PLUS the attached changes proposed by me.

    @Grey Roger, @pedrwyth, @Jack Rackham and @Levis:
    If you get the chance, please compare this to your own game version to check if I didn't accidentally mess something up!
    There are some recent changes that I deliberately EXcluded, so if you know the reason why those should actually be added, please speak up.
    And if you have any questions on the other changes I made, please also let me know.

    @Grey Roger: Can you remind me again which files should be REMOVED from the next modpack update?
    I know you mentioned them several times, but I can't remember where and if I already took care of that on my side or not.
    Better be sure.... :rolleyes:
     

    Attached Files:

    ANSEL likes this.
  19. salonikasurf

    salonikasurf Freebooter Storm Modder

    Joined:
    Dec 26, 2008
    Messages:
    293
    Gender:
    Male
    Occupation:
    Engineer
    Location:
    Hay Point Australia
    Hi Pieter,
    Happy New Year to all.

    Just tried the above with a clean install. Game crashes in Tales of a Sea Hawk in the tutorial cabin when you try to open your sea chest to get your weapons etc or the weapons chest.
    Build 14 Beta 4.1 WIP, Post jul28_fixes and Post_jul28fixes_PB_updates.

    Error log, compile log and System log include in attached zip file.
     

    Attached Files:

  20. Pieter Boelen

    Pieter Boelen (Not So) Old Seadog Staff Member Administrator Storm Modder Hearts of Oak Donator

    Joined:
    Nov 11, 2004
    Messages:
    66,575
    Gender:
    Male
    Occupation:
    Maritime Research: Project Engineer (Analysis)
    Location:
    Wageningen, The Netherlands
    Ahoy @salonikasurf,

    Thanks for trying it out! I tested it in my own game version though and it seemed to work fine for me.
    Your error.log file indicates there is something wrong with the installation on your end, I'm afraid:
    Code:
    COMPILE ERROR - file: items\initItems.c; line: 4158
    Invalid Expression
    COMPILE ERROR - file: items\initItems.c; line: 4158
    Undeclared identifier: EQUIP3_ITEM_TYPE
    
    That was added as a #define to items.h quite recently, but is not a file that I changed myself.

    When is the last time you installed a new version of the "Post jul28_fixes" archive?
    There have been multiple versions of that and the most recent is dated 23 December 2016.
    Maybe you missed out on that one?

    If you want to, I'd suggest trying this:
    1. Redownload http://piratesahoy.bowengames.com/potc/Grey Roger/post_jul28_fixes.zip and then install that on your game
    2. Now install my ZIP from Fix in Progress - Post 28th July fixes | Page 5 | PiratesAhoy! on top again
    3. With a bit of luck, that will have solved the problem

    I'm currently working on making a proper new EXE, so you don't need to install so many things in sequence any longer.
    With a bit of luck, that will help.
     

Share This Page