Fixed Ship in the port graphic bug

[Schalkepirat]

Build Version: Friday 6 December 2013
Build 14 Beta 3.1 Full
At the time ENB was installed



Build version:Build 14 beta 3.1 Full - (Vers. 06.12.2013)

 

[DavyJack]

Where is this?

 

[Schalkepirat]

Bonaire - Kralendijk
Storyline Tales of a Sea Hawk

 

[DavyJack]

I don't know if the Storyline would make any difference but I sailed there at Kralendijk, Bonaire and the ships are properly moored:
The left side where a ship is not properly placed on your screenie ain't there yet. I don't know but I'll try to check it again with Tales of a Sea Hawk.

 

[DavyJack]

...I'll try to check it again with Tales of a Sea Hawk.

And its still okay: (Tales of A Sea Hawk)
Build Version: Friday 6 December 2013
Build 14 Beta 3.1 Full
---------------------------------------------------------------------------------------------------------------------------||
And I noticed some dark spots on Kralendijk too btw: (I don't know if its the Intel Graphic thingies again)

 

[Schalkepirat]

I also think it will be up to the particular ship, it is not a photomontage

 

[DavyJack]

Maybe its the ENB

 

[Hylie Pistof]

What ship is that? What Pieter was doing is just removing that ship from being able to dock at Kralendijk when we would report this. Basically anything larger than caravel causes this problem.

But I forget what file he changed.

 

[Armada]

Confirmed bug. That particular ship is too large for the Kralendjik docks, but the right size for Port Royal docks.
Easily fixed by adding this line to its entries in PROGRAM\Ships\Ships_init.c:

refShip.Jetty = false;

If anyone sees other ships doing the same, please report them here.

 

[Pieter Boelen]

What ship is that? Rossiya?

 

[sir_Grbac]

What ship is that? Rossiya?

Yes, and also, the two 6th rate frigates, lime frigate, Aurora class frigate, Neptunus(sloop of war), and a few more, that I can't put my finger on it.

There are still some ships sailing through land whilist I'm walking around in port, rare occasions, but it does happen.

 

[Hylie Pistof]

The ships sailing through land can not be helped. It is either that or no ships.

 

[Pieter Boelen]

The locators would have to be turned around to point to sea for that.

 

[Levis]

any news on this one?
is the ship changed already so it wont go trough land anymore?

 

[Pieter Boelen]

I thought it was, but I can't remember.

 

[Levis]

Can someone confirm this is fixed?

 

[Pieter Boelen]

The Rossiya does not yet have the JettyShip = false line.
But I vaguely remember Armada had suggested a change for the automated cut-off value that I applied instead.

 

[Levis]

So @Armada whats the idea?

 

[Pieter Boelen]

Looks like that change WAS indeed made in PROGRAM\Characters\CharacterUtilite.c:

bool JettyShip(ref chr)
{
   int nShipType = GetCharacterShipType(chr);
   if (nShipType == SHIP_NOTUSED) return false;
   aref ship; makearef(ship, chr.ship);
   if (CheckShipAttribute(ship, &ShipsTypes[nShipType], "Jetty"))
     return sti(GetLocalShipAttrib(ship, &ShipsTypes[nShipType], "Jetty"));
   else
     return GetMaxCrewQuantity(chr) < 400; // Armada
}

 

[Levis]

Ok, then for now I put this on fixed. Dont Forget to add that Change to the changelog