Mod Release Build 14 Beta 3.5 Internal WIP For Testing

[Pieter Boelen]

Opening post ZIP updated again. This time a relatively small changes and theoretically you should notice ABSOLUTELY NO DIFFERENCE!
I rewrote the way the "professionalnavy" and "HasAnyLetterOfMarque" checks are handled so they're now controlled by different multi-purpose functions.
These will prove useful when we start doing more advanced nation relations stuff.

Couple of notes for this:
- If you were playing as Professional Navy OR had a LoM, execute this line through console.c to make the game behave itself properly:

pchar.professionalnavy = GetServedNation();

- The Nations Relations Interface will now only indicate your rank in green if you can be promoted AND are in the service of that nation

So PRETTY PLEASE try playing around a bit as professional navy and privateer and let me know if I did accidentally break anything.
If this doesn't do what I think it does, there isn't all that much point building new systems on top of this.

 

[Pieter Boelen]

@Levis, please thoroughly WinMerge this latest zip and keep a very critical eye.
I want to be certain that this does what I think it does (Eg exactly the same that it always did, but written slightly different).

 

[A.H]

I did an hour of gameplay today and the experience rate was a bit slower than usual but I have no complaints since it makes it well worth your effort in ranking the character up.

However, during my first boarding, I crashed twice for unknown reasons.. then after several defeats against melee mode, I deleted the game and going to reinstall it in case my folders are missing something.. since crashes haven't happened at all in past 2 patch updates..

Most likely will continue playing in the new update as you said recently.


I have two queries though.. firstly, which file do I access the codes for adjusting the type of loot obtained from captured ships? I wish to change gold & silver loot to make it rare, to make the game more realistic and make every ship captured worth every penny if you get what I mean...


Seocndly.. @Pieter Boelen you said you have same video card & stats as my laptop.. where do you access the image quality? I can't seem to find that option anywhere

 

[Pieter Boelen]

I have two queries though.. firstly, which file do I access the codes for adjusting the type of loot obtained from captured ships? I wish to change gold & silver loot to make it rare, to make the game more realistic and make every ship captured worth every penny if you get what I mean...

Sounds to me like you have been running into some deliberate treasure fleets. The code generating them is in PROGRAM\SEA_AI\AIFantom.c:

  // TIH --> rare gold & silver shipments mod Sep3'06
   // PB: Treasure Fleet -->
   bool RareShipment = false;
   if(rFantom.FantomType == "trade")
   {
     if(rand(100) < 5)                   RareShipment = true; // 5% chance of finding one of these
     if(TreasureFleet && rFantom.nation == SPAIN)     RareShipment = true; // Always on Spanish Treasure Fleets
   }
   if ( RareShipment )
   // PB: Treasure Fleet <--
   {
     switch(rand(2)) // one in three chance it will be gold! all gold!
     {
       case 0:
         Fantom_SetCharacterGoods(rFantom, GOOD_GOLD, GetCharacterFreeSpace(rFantom,GOOD_GOLD));
         Trace("CARGO: Fantom_SetGoods rare chance gold shipment!");
         break;
       //default:
         Fantom_SetCharacterGoods(rFantom, GOOD_SILVER, GetCharacterFreeSpace(rFantom,GOOD_SILVER));
         Trace("CARGO: Fantom_SetGoods rare chance silver shipment!");
     }
     return;// no point in continuing with this function now, the hold is full!
   }
   // TIH <--

Not sure if you should want to edit that, though. These aren't very common, but if you DO encounter them, it is a LOT of money.

Seocndly.. @Pieter Boelen you said you have same video card & stats as my laptop.. where do you access the image quality? I can't seem to find that option anywhere

Dunno; I never bothered to try.

 

[A.H]

Ah no worries.. I'm just jealous of Hylie's high quality textures

But I didn't mean treasure fleets.. normal ships (sloops, galleons, etc.) with gold aboard.. I run into them a lot..

Treasure fleets on the other hand I barely run into them

 

[Pieter Boelen]

But I didn't mean treasure fleets.. normal ships (sloops, galleons, etc.) with gold aboard.. I run into them a lot..

You could try getting rid of this line:

if(rand(100) < 5) RareShipment = true; // 5% chance of finding one of these

That one is responsible for a 5% chance of silver and gold being carried in any random ship.

 

[Pieter Boelen]

Opening post ZIP updated again

This is very much a TESTING update and you'll notice a lot of on-screen and compile.log messages related to nation relations.
The feature list below shows how it is intended to work. However, we'll need some thorough playtesting to find out if the code actually does what we want it to.
These extra log messages are intended to provide extra insight in what is going on; for the public Beta 3.5 release, these will all be removed.

Extra functionality is also the F2>Character interface showing your Player Type like this:

If you are a Navy Officer but this text shows "Captain" instead of "Naval Captain", report it here immediately!
http://www.piratesahoy.net/threads/naval-officer-letter-of-marque-does-not-stick.25459/
You will probably have seen an on-screen message then as well indicating that you lost your LoM and I want to know when and why that may have happened.

Your current Loyalty (=Served Nation) is now also shown in F2>Questbook like this:

Note that if this is Personal, then your nation relations are NOT tied to another nation in case of a random relation change.
And allies of the nations you attack may take exception to your actions as you are not quite a legal privateer in such a case.
If this is Pirate, then you might run into danger ashore in any non-nation towns as you have committed some traitorous acts.

New stuff:

- New Features:
  . Improved Nation Relations by Pieter Boelen
  > Player loyalty (Served Nation) impacts game functionality:
  - Loyalty is indicated in the Questbook Interface by the large yellow nation name
  - Player relations will automatically follow random relation changes affecting his/her Served Nation (but not for Pirate and Personal loyalities)
  - Loyalty is set to your chosen nation at game start
  - Loyalties are updated on each promotion
  - Having multiple Letters of Marque (LoM) will set your loyalty to Personal
  - Large acts of piracy, repeated small acts of piracy and joining the pirates will set your loyalty to the Pirates
  - If your loyalty lies with the pirates, you may be recognized for this by citizens of non-pirate towns
  - When your loyalty lies with the pirates, the only way to undo this is to stop serving the pirates and get a single LoM
  > Relation Changes from player actions completely rewritten:
  - You gain point with a nation only if you have a LoM with them
  - Having multiple LoMs decreases the amount of points you get per nation, though you still get more in total by Grey Roger
  - You lose points with nations allied to the nation you attacked if you have no legal reason to do so or if you have multiple LoMs
  - You lose your LoM if you attack one of your nation's allies
  - You gain points with the pirates through acts of piracy; if you have gained enough points, your loyalties shift to the pirates
  - A small act of piracy is attacking without having a legal reason for it, which applies to ALL ships you sink/capture without having a LoM or navy commission
  - A large act of piracy is actively betraying a nation you were serving or one of their allies
  . Distinguished between Player Types by Grey Roger, Levis and Pieter Boelen
  > Current Player Type is indicated by your captain type in the bottom of the Character Interface
  . New musket style guns added by Jack Rackham
  > Errors with half-loaded guns fixed
  > Rarity and period assignments adjusted by Grey Roger and Pieter Boelen
  . Additional Personal Flags added by pedrwyth [WIP: To be improved and completed]
- Bug Fixes:
  . Corrected display of rank titles in Character Interface title by Pieter Boelen
  . Display of reputation change for female characters fixed by Pieter Boelen
  . Nation Relations Interface only shows your relation green (=awaiting promotions) if you actually have a LoM so you can receive that promotion by Pieter Boelen
  . Code removed that may remove a LoM at game start when this shouldn't happen by Pieter Boelen
- Storyline Updates:
  . Sidequests:
  > Church Help sidequest corrected for Early Explorers by Grey Roger

 

[Jason]

New game required?

 

[A.H]

Darn.. just when I freed my time up for a new game :'(



Cant even get the game to start.. I installed fresh POTC by akella... then the 2+ GB extract onto that folder.. then I installed the 300m file, followed by the extraction of the latest patch zip



EDIT: Nvm, i made a stupid mistake.. been a long day!

 

[Pieter Boelen]

EDIT: Nvm, i made a stupid mistake.. been a long day!

Problem solved? GOOD!

 

[A.H]

Yes after original POTC I extracted the 2GB file.. while I should have just left it alone & clicked on the 300mb installer

 

[Pieter Boelen]

Yes after original POTC I extracted the 2GB file.. while I should have just left it alone & clicked on the 300mb installer

Yes, you should. Just let the installer do its thing; that's always a good idea.

 

[A.H]

Oops problem is back.
I just started game without extracting the new patch update.. and it opened fine.

This problem is caused by something within the new zip file.. not sure which
Then I copied & pasted all the new update files.. and same runtime startup error again with the follow error logs:

COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
invalid function argument
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Invalid Expression
COMPILE ERROR - file: NK.c; line: 19
Undeclared identifier: FindFreeRandomOfficer

 

[Levis]

@Pieter Boelen ? I havent been able to check this yet. Any comment?

 

[Pieter Boelen]

I don't know what's going on there right now. My game still works, despite my substantial rewrites.
If I come up with something that isn't broken soon, I'll upload that instead for testing.

 

[Pieter Boelen]

Opening post ZIP updated AGAIN!

I have completed my nation relation rewrites for today. The system has been far simplified and a lot of superfluous code has been thrown out of the window.
Everything should work as well as it did before, with the exception that all fancy mod-added AI behaviour and false flag recognizing is disabled.
So the ships at sea WILL believe your false flag no matter what and they'll forget about it when you leave again.
Simple? Yes. Dumb? Very much so!

I'd definitely appreciate people testing this and letting me know if any formerly working stuff is now broken.
The changes made were... uhm... pretty large. While this should be better than it was, some more changes might be required to get it completely operational.
So we need to find what still needs tweaking. That's what this testing is for, eh?

@A.H: You could try this version instead and see what happens.

@Levis: If you have the chance, please have a good look with WinMerge at what I did and double-check that I didn't do anything completely retarded....

 

[ANSEL]

I havent seen any problems for the new install for now.

 

[Pieter Boelen]

I havent seen any problems for the new install for now.

With Friday's version, eh? That's definitely good news.

That's the version with the rewritten method for nation relation changes based on player actions.
There is nothing related to that in your compile.log file though; did you already win any sea battles with that version?
Have you checked your Nations Relations Interface afterwards? Does what you see make sense with what you'd expect?

 

[ANSEL]

This is the first version of Friday. No, havent been to any sea battle yet, next I have to do.
What about the second version, install this to?

 

[Pieter Boelen]

This is the first version of Friday. No, havent been to any sea battle yet, next I have to do.
What about the second version, install this to?

If you're willing to test that, I'd definitely appreciate.
I think I forgot to enforce a new game but that would definitely be needed as I cleared out all sorts of old variables.
Can't make any guarantees on how well this latest version will work, but it is the way forward.

This is the first version of Friday. No, havent been to any sea battle yet, next I have to do.
What about the second version, install this to?

If you're willing to test that, I'd definitely appreciate.
I think I forgot to enforce a new game but that would definitely be needed as I cleared out all sorts of old variables.
Can't make any guarantees on how well this latest version will work, but it is the way forward.