Fixed Game Crashes around Specific Islands

[Jason]

After taking a ship. Playing BFF latest update

 

[Pieter Boelen]

Do you have a save just prior to that? Does it happen all the time? Can it be replicated?

Unfortunately I don't see anything crash-worthy in those log files.

 

[Jason]

No save but I do have one for Multiple and repeated crashes to desktop during boarding. The last four times in a row.

 

[Hylie Pistof]

On another note, the game doesn't seem too stable anymore with many random CTDs making it difficult to play. It has been this way for some time now. It used to be maybe 1 CTD a day. Now it is 3-8 CTDs a day.

Here are the logs from the last one.

 

[Pieter Boelen]

When did that error occur? At sea? During a battle or not?
Is it this one by any chance?
Awaiting Info - Sea Battles: Crash for virtual function call | PiratesAhoy!

 

[Pieter Boelen]

Multiple and repeated crashes to desktop during boarding. The last four times in a row.

Did you do any looting of corpses during boarding? We found that causes the game to become crashy for unknown reasons.
See here: Low Priority - Boarding: Inconsistent Crashes Related to Looting | PiratesAhoy!

 

[Jason]

Did you do any looting of corpses during boarding? We found that causes the game to become crashy for unknown reasons.
See here: Low Priority - Boarding: Inconsistent Crashes Related to Looting | PiratesAhoy!

I do and it has caused crashes but you can get from just moving the deck.

 

[Jason]

You know this will probably sound crazy, but I have noticed they tend come in bunches in a specific map region. Maybe something to do with locators?

 

[Hylie Pistof]

I was sailing from Havana to Marigot. In the world map all went well but 3 times in a row it CTDed while direct sailing in to port with no battles or hostile ships in sight. I finally gave up and quick sailed into port.

Here is a save sailing into port before a CTD.

 

[Pieter Boelen]

Thanks for that. Seems we've got some more investigating to be done....

 

[Hylie Pistof]

I went back to Marigot and this time I sailed right in with no problems.

 

[Pieter Boelen]

So.... wonderfully inconsistent problems again? Those are THE WORST!
You can hardly ever narrow down why they even happen at all.

 

[Jason]

Well from my point of view this is a pretty serious problem. Not able to complete a boarding in 8 tries. I have need had the problem to this extent. I am wondering if you might consider assigning a higher priority to understanding the problem and finding a fix.

 

[Levis]

hmm....might have an idea here...
The Problem with the NPCharacter not being created is a known Problem which we haven't found out yet. but when this is passed to the leveling code which tries to use this in Events it might cause Problems which can result in an CTD...
I think we should add aa IsEntity check before the leveling code.
Try this please @Hylie Pistof (I wasn't able to test it here so there might be Errors. This is taken from the latest zip posted in the main Topic).
If you are still running dec22 then add this line at the top of:
InitAutoSkillsSystem

if(!IsEntity(refCharacter)) return;

and this one for InitCharacterSkills

if(!IsEntity(chref)) return;

 

[Levis]

@Jason I might be able to look at it tomorrow. What do I Need to do in your savegame to replicate the Problem?

 

[Pieter Boelen]

The Problem with the NPCharacter not being created is a known Problem which we haven't found out yet.

If I recall, I'd normally see that error show up at the same time as the "too many characters in location" note.
So in my experience, that normally occurs ashore while the instability occurs at sea.

But I'm not 100% sure if that happened here as well and for sure this check cannot hurt.

 

[Levis]

I don't have the character code here now. but We might want to add a check in there too so it will just put a notice in the compile log instead.

 

[Pieter Boelen]

I don't have the character code here now. but We might want to add a check in there too so it will just put a notice in the compile log instead.

Not sure what you mean there....?

 

[Levis]

Not sure what you mean there....?

no Problem. I will try to do it tonight, if you see the code you understand .

 

[Hylie Pistof]

hmm....might have an idea here...
The Problem with the NPCharacter not being created is a known Problem which we haven't found out yet. but when this is passed to the leveling code which tries to use this in Events it might cause Problems which can result in an CTD...
I think we should add aa IsEntity check before the leveling code.
Try this please @Hylie Pistof (I wasn't able to test it here so there might be Errors. This is taken from the latest zip posted in the main Topic).
If you are still running dec22 then add this line at the top of:
InitAutoSkillsSystem

if(!IsEntity(refCharacter)) return;

and this one for InitCharacterSkills

if(!IsEntity(chref)) return;

Huh?