• New Horizons on Maelstrom
    Maelstrom New Horizons


    Visit our website www.piratehorizons.com to quickly find download links for the newest versions of our New Horizons mods Beyond New Horizons and Maelstrom New Horizons!

Build 14 Beta 1 Feedback

I do not doubt this, I would like to help, but I dont know how to do any actual coding, all I can do is to come up with some interesting, but reasonable ideas.

Still you should do something about trade quest as it have somewhat gamebreaking potential.
 
If you want to help, we can help you help us. ;)

With the trade quests thing, you mean the upsetting of the balance of the economy, right?
Or the amount of payment? I'm pretty sure that's upposed to depend on the distance to be traveled and the value of the cargo.
 
The money you get is the problem, o rather lack of randomization of distance when you immediately take another mission, in other words: you can make consistent runs for around 15.000 gold all the time if you get right mission at the start of the chain. Im not sure if it happens all the time, but for me it does.
 
This is for the trade quests, right? Not the escort ones...?
Here's the code in MAXIMUS_functions.c that calculates the pay:
Code:
	int iQuantityGoods = GetSquadronFreeSpace(pchar, iTradeGoods) * 4/5; // NK ratio 05-05-12
float fDistance = GetTownDistance2D(GetCurrentTown(), GetTownFromID(sTown));
float fWeight = GetGoodWeightByType(iTradeGoods, iQuantityGoods);
// money was ((iQuantityGoods *10+99)/100)*100;
// should give ~40k (at scl 0.02) for 2000 goods brought 1000 distance, and you get a commission on the sale.
float pricediff = tprice - fprice;
if(pricediff<1) pricediff = 1.0;
int iMoney = round(GetCharPriceMod(&PChar, PRICE_TYPE_SELL, true) * fDistance * fWeight * TRADEQUEST_DIST_SCL + pricediff * iQuantityGoods * TRADEQUEST_COMMISSION);
Question: You say the problem only occurs if you get another quest straight away, right?
Between starting the dialog to deliver the cargo and getting the new quest, do you close/end the dialog at some point?
If you don't, what happens if you do? Does that randomize the amount of money again?
 
It went like this: I asked for a trade quest (in shop) got pretty nifty one, Barbados - Sao Jose (?) for 14.000 at Sao Jose I talked with shopkeeper and told him that I was asked to deliver a cargo to him, dialog ends and I get moniez along with exps. Without leaving the the shop I ask for another trade quest and I get one: Sao Jose - Dutch town on Saint Martin for around 15.000, there I got another quest for 15.000 again and so on and on. At some point I decided to build my own town, after that I returned to doing trade quests, but then all I got were runs for 5.000.

I didnt check if this changes if you leave shop and enter again.
 
I do lots of trade quests and almost always leave the merchants shop after selling goods to do other things, then come back and get another cargo assignment when I'm ready to leave. The money earned is dependent on distance traveled and value of cargo. Sao Jorge to Bridgetown doesn't pay much, Sao Jorge to Philipsburg makes good money, but Sao Jorge to Havana is a cash cow. There is some randomization in it also. Sometimes a run that was paying good money will suddenly pay poor money, and occasionally you hit the jackpot with a huge fee.
 
It depends on the cargo you have to transport as well, so an expensive cargo over a long distance might be a jackpot.
 
Beta1 Patch2

I have never run into this before and don't know if it is a bug or a messed up install.

I just went to Bonaire and traded with the merchant and the shipyard. Then went to the governor and bought a letter of marque. Then went back to the merchant and was told to get out before he called the guards. :eek:k I'm only on level 3 and have done nothing to offend anyone. I started over to see if it would happen again, which is why I'm only on level 3.

In the first game I bought Letters of Marque from England and Holland and had the same trouble. It was strange. I could deal with Antigua, but not Charlestown. Life got difficult as I could only trade with the Spanish and Portagees unless I snuck into a French port. Forts and ships were ok, it was just the merchants, shipyards, and innkeepers who were hostile. As an experiment I sank 2 small English ships and then sailed into Port Royale. Everyone was very friendly again. Not having a letter of marque means no land or title, so is it just me or is this a bug?
 
Is England and Holland at war? :?

I think it should be set up so you can only have one letter anyway :facepalm
 
It doesn't matter if they are at war or not. I could sail past their ships and forts and dock while flying my personal flag. The merchants were the hostile ones, which made buying food impossible as well as no trade or escort missions. The real killer is that sinking ships and losing the letter of marque makes everything ok again and I can trade normally. :shrug
 
The reason why I ask is they could see you are involved in a country you are at war with and because of this wont let you trade :yes

So again, are they at war? :?
 
I DID rewrite the code for this quite recently, but I thought the rewrite made sense... :?
Does anyone remember where my post for this one is?

Basically, whether a merchant/shipwright will trade with you depends on:
- Your reputation (higher reputation, can trade with lower nation relations)
- Your personal relation with the nation (higher relation with nation, can trade despite low reputation)

The code I wrote was intended to allow you to trade with a nation you've got a rank with always, even if you've got the worst reputation.

Admittedly, I didn't test the code much, so there is a chance it doesn't work as it was intended to.
If so, we need to figure out what it DOES do, where it goes wrong and figure out how to fix it.
 
The reason why I ask is they could see you are involved in a country you are at war with and because of this wont let you trade :yes

So again, are they at war? :?

I don't remember clearly if they were at war at the time. I recall one country was at war with everybody else. I dumped that game and started over.

So is this a new thing? That if you have a letter of marque from a country they are at war with, they will not trade with you? I could never trade with the French before until I bought forgiveness, but now I do trade with them even while sinking their ships. Tis funny. I have to fight my way into Martinique, but can trade freely once inside. Laissez Faire I suppose.

It sounds like I will have to buy letters from 2 countries and test this further. Mayhaps this is not a bug but intentional.
 
So is this a new thing? That if you have a letter of marque from a country they are at war with, they will not trade with you?
Uhm... I definitly DIDN'T code THAT in! :shock
Please see this thread: http://forum.piratesahoy.net//topic/16047-annoying-problem-at-shipyard
 
After reading that thread it seems that I got my letters too soon. I was a bloke with maybe 30 crew and a commerce level of 4. :wp



Ok, now I am really confused. And yes, it IS my natural state. :rumgone I went to Kralendik on a trade mission. Sold the cargo, then bought and sold other goods. Then went to the shipyard and bought new sails for my Pinnace. Then went to see the governor and bought a letter of marque. My only letter so far. Both the merchant and the shipwright told me to get out before they call the guards.

I am now a matey at level 13, a commerce level of 7, and 102 crew.
 
That code as intended does NOT care if you've got a Letter of Marque or not.
Only if you are promoted by the governor at least once will the store and shipyard owners always talk to you, no matter your reputation.

My main questions are:
- What nation's store/shipyard owner are you trying to talk to?
- What is your nation relation with that nation (real, not based on flag)?
- What is your reputation?

Edit: On second thought, do I understand correctly that they stop talking to you as soon as you get that Letter of Marque?
I think I might have detected the actual problem, which is a fault of mine. :eek:ops2
Stand by for a fix.
 
Can you please try attached file? Save it to your PROGRAM\Characters folder.
As you can see here, I think I found a proper fix for the problem:
http://forum.piratesahoy.net//topic/16047-annoying-problem-at-shipyard/page__st__40#entry372837

Thanks for finding this one! :woot
 
I don't always express myself well, so get misunderstood occasionally. Yes, I bought the LoM then walked to the store. Got kicked out and walked to the shipyard. Got kicked out. I've been kicked outta better dives than that before! :)) Then came here.

Will try the fix immediately. :onya

I happened to be in Port Royale, so got an English LoM. Went to the tavern, store, and shipyard immediately after buying it and everyone was friendly.
 
Did you have it < 0 or something Pieter instead of > 0 xD:

That would indeed make them be unhappy to trade all the time instead of them being happy to :yes
 
See here for what the code was: http://forum.piratesahoy.net//topic/16047-annoying-problem-at-shipyard/page__view__findpost__p__369529
Indeed it WAS some < vs. > mess-up. :facepalm

miklkit, truth be told, you expressed yourself fine. I just didn't read it properly until yesterday. :eek:ops2
 
Back
Top